| Message ID | 20220301073223.98236-2-ammarfaizi2@gnuweeb.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Two x86 fixes | expand |
On Tue, Mar 01, 2022 at 02:32:22PM +0700, Ammar Faizi wrote: > The asm constraint does not reflect that the asm statement can modify > the value of @loops. But the asm statement in delay_loop() does change > the @loops. > > If by any chance the compiler inlines this function, it may clobber > random stuff (e.g. local variable, important temporary value in reg, > etc.). > > Fortunately, delay_loop() is only called indirectly (so it can't > inline), and then the register it clobbers is %rax (which is by the > nature of the calling convention, it's a caller saved register), so it > didn't yield any bug. > > ^ That shouldn't be an excuse for using the wrong constraint anyway. > > This changes "a" (as an input) to "+a" (as an input and output). > > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Borislav Petkov <bp@alien8.de> > Cc: Dave Hansen <dave.hansen@linux.intel.com> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Fixes: e01b70ef3eb3080fecc35e15f68cd274c0a48163 ("x86: fix bug in arch/i386/lib/delay.c file, delay_loop function") You only need 12 characters here :) > Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org> > --- Why is this one not tagged for stable?
Hi Greg, On 3/1/22 3:26 PM, Greg KH wrote: > On Tue, Mar 01, 2022 at 02:32:22PM +0700, Ammar Faizi wrote: >> The asm constraint does not reflect that the asm statement can modify >> the value of @loops. But the asm statement in delay_loop() does change >> the @loops. >> >> If by any chance the compiler inlines this function, it may clobber >> random stuff (e.g. local variable, important temporary value in reg, >> etc.). >> >> Fortunately, delay_loop() is only called indirectly (so it can't >> inline), and then the register it clobbers is %rax (which is by the >> nature of the calling convention, it's a caller saved register), so it >> didn't yield any bug. >> >> ^ That shouldn't be an excuse for using the wrong constraint anyway. >> >> This changes "a" (as an input) to "+a" (as an input and output). >> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: Ingo Molnar <mingo@redhat.com> >> Cc: Borislav Petkov <bp@alien8.de> >> Cc: Dave Hansen <dave.hansen@linux.intel.com> >> Cc: "H. Peter Anvin" <hpa@zytor.com> >> Fixes: e01b70ef3eb3080fecc35e15f68cd274c0a48163 ("x86: fix bug in arch/i386/lib/delay.c file, delay_loop function") > > You only need 12 characters here :) Ah well, that's too verbose. Will fix it in the v4. >> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org> >> --- > > Why is this one not tagged for stable? As far as I can tell, the compiler will never inline that function, because despite the function is static, it's assigned to a global variable and it's called indirectly via a function pointer variable, so it can't be inline. Therefore, it will always be a function call. Note that %eax is a call clobbered register w.r.t. System V ABI. As such, *by luck*, this wrong constraint doesn't yield any bug. The compiler will not assume the %eax value is the same as before the function call is done. So the compiler isn't aware that constraint violation. Not sure if it's worth it for backport. x86 maintainers, any comment on this?
diff --git a/arch/x86/lib/delay.c b/arch/x86/lib/delay.c index 65d15df6212d..0e65d00e2339 100644 --- a/arch/x86/lib/delay.c +++ b/arch/x86/lib/delay.c @@ -54,8 +54,8 @@ static void delay_loop(u64 __loops) " jnz 2b \n" "3: dec %0 \n" - : /* we don't need output */ - :"a" (loops) + : "+a" (loops) + : ); }
The asm constraint does not reflect that the asm statement can modify the value of @loops. But the asm statement in delay_loop() does change the @loops. If by any chance the compiler inlines this function, it may clobber random stuff (e.g. local variable, important temporary value in reg, etc.). Fortunately, delay_loop() is only called indirectly (so it can't inline), and then the register it clobbers is %rax (which is by the nature of the calling convention, it's a caller saved register), so it didn't yield any bug. ^ That shouldn't be an excuse for using the wrong constraint anyway. This changes "a" (as an input) to "+a" (as an input and output). Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Fixes: e01b70ef3eb3080fecc35e15f68cd274c0a48163 ("x86: fix bug in arch/i386/lib/delay.c file, delay_loop function") Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org> --- arch/x86/lib/delay.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)