mbox series

[v3,0/3] soundwire: qcom: add pm runtime support

Message ID 20220228172528.3489-1-srinivas.kandagatla@linaro.org (mailing list archive)
Headers show
Series soundwire: qcom: add pm runtime support | expand

Message

Srinivas Kandagatla Feb. 28, 2022, 5:25 p.m. UTC 
This patchset adds pm runtime support to Qualcomm SounWire Controller using
SoundWire Clock Stop and Wake up using Headset events on supported instances and
instances like WSA which do not support clock stop a soft reset of controller
along with full rest of slaves is done to resume from a low power state.

Tested it on SM8250 MTP and Dragon Board DB845c

Changes since v2:
 - update log as suggested by Pierre
 - removing handling clk stop for cases where the controller is soft reset.
 - add more error checks when calling  sdw_bus_prep_clk_stop
 - update dt-bindings with wakeup-source and interrupt-names properties.

--srini

Srinivas Kandagatla (3):
  soundwire: qcom: add runtime pm support
  dt-bindings: soundwire: qcom: document optional wake irq
  soundwire: qcom: add in-band wake up interrupt support

 .../bindings/soundwire/qcom,sdw.txt           |  14 +-
 drivers/soundwire/qcom.c                      | 206 +++++++++++++++++-
 2 files changed, 218 insertions(+), 2 deletions(-)

Comments

Vinod Koul March 2, 2022, 3:42 p.m. UTC | #1 
On 28-02-22, 17:25, Srinivas Kandagatla wrote:
> This patchset adds pm runtime support to Qualcomm SounWire Controller using
> SoundWire Clock Stop and Wake up using Headset events on supported instances and
> instances like WSA which do not support clock stop a soft reset of controller
> along with full rest of slaves is done to resume from a low power state.
> 
> Tested it on SM8250 MTP and Dragon Board DB845c

Applied, thanks
Amit Pundir April 4, 2022, 9:42 p.m. UTC | #2 
On Wed, 2 Mar 2022 at 21:13, Vinod Koul <vkoul@kernel.org> wrote:
>
> On 28-02-22, 17:25, Srinivas Kandagatla wrote:
> > This patchset adds pm runtime support to Qualcomm SounWire Controller using
> > SoundWire Clock Stop and Wake up using Headset events on supported instances and
> > instances like WSA which do not support clock stop a soft reset of controller
> > along with full rest of slaves is done to resume from a low power state.
> >
> > Tested it on SM8250 MTP and Dragon Board DB845c
>
> Applied, thanks
>

Hi, this patch series broke audio on SDM845 running AOSP. I can
reproduce it on both DB845c and PocoF1
https://www.toptal.com/developers/hastebin/raw/rodazupayu. It is not
100% reproducible but can be triggered on every alternate reboot or
so.

Regards,
Amit Pundir

> --
> ~Vinod