| Message ID | 20220302211113.4003816-18-clabbe@baylibre.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | crypto: rockchip: permit to pass self-tests | expand |
On Wed, 02 Mar 2022 21:11:12 +0000, Corentin Labbe wrote: > convert rockchip-crypto to yaml > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > .../crypto/rockchip,rk3288-crypto.yaml | 64 +++++++++++++++++++ > .../bindings/crypto/rockchip-crypto.txt | 28 -------- > 2 files changed, 64 insertions(+), 28 deletions(-) > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml > delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1600075 cypto-controller@ff8a0000: clock-names: ['aclk', 'hclk', 'sclk', 'apb_pclk'] is too long arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml arch/arm/boot/dts/rk3288-evb-rk808.dt.yaml arch/arm/boot/dts/rk3288-firefly-beta.dt.yaml arch/arm/boot/dts/rk3288-firefly.dt.yaml arch/arm/boot/dts/rk3288-firefly-reload.dt.yaml arch/arm/boot/dts/rk3288-miqi.dt.yaml arch/arm/boot/dts/rk3288-phycore-rdk.dt.yaml arch/arm/boot/dts/rk3288-popmetal.dt.yaml arch/arm/boot/dts/rk3288-r89.dt.yaml arch/arm/boot/dts/rk3288-rock2-square.dt.yaml arch/arm/boot/dts/rk3288-rock-pi-n8.dt.yaml arch/arm/boot/dts/rk3288-tinker.dt.yaml arch/arm/boot/dts/rk3288-tinker-s.dt.yaml arch/arm/boot/dts/rk3288-veyron-brain.dt.yaml arch/arm/boot/dts/rk3288-veyron-fievel.dt.yaml arch/arm/boot/dts/rk3288-veyron-jaq.dt.yaml arch/arm/boot/dts/rk3288-veyron-jerry.dt.yaml arch/arm/boot/dts/rk3288-veyron-mickey.dt.yaml arch/arm/boot/dts/rk3288-veyron-mighty.dt.yaml arch/arm/boot/dts/rk3288-veyron-minnie.dt.yaml arch/arm/boot/dts/rk3288-veyron-pinky.dt.yaml arch/arm/boot/dts/rk3288-veyron-speedy.dt.yaml arch/arm/boot/dts/rk3288-veyron-tiger.dt.yaml arch/arm/boot/dts/rk3288-vyasa.dt.yaml cypto-controller@ff8a0000: clocks: [[7, 199], [7, 461], [7, 125], [7, 193]] is too long arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml arch/arm/boot/dts/rk3288-evb-rk808.dt.yaml arch/arm/boot/dts/rk3288-firefly-beta.dt.yaml arch/arm/boot/dts/rk3288-firefly.dt.yaml arch/arm/boot/dts/rk3288-firefly-reload.dt.yaml arch/arm/boot/dts/rk3288-miqi.dt.yaml arch/arm/boot/dts/rk3288-phycore-rdk.dt.yaml arch/arm/boot/dts/rk3288-popmetal.dt.yaml arch/arm/boot/dts/rk3288-r89.dt.yaml arch/arm/boot/dts/rk3288-rock2-square.dt.yaml arch/arm/boot/dts/rk3288-rock-pi-n8.dt.yaml arch/arm/boot/dts/rk3288-tinker.dt.yaml arch/arm/boot/dts/rk3288-tinker-s.dt.yaml arch/arm/boot/dts/rk3288-veyron-brain.dt.yaml arch/arm/boot/dts/rk3288-veyron-fievel.dt.yaml arch/arm/boot/dts/rk3288-veyron-jaq.dt.yaml arch/arm/boot/dts/rk3288-veyron-jerry.dt.yaml arch/arm/boot/dts/rk3288-veyron-mickey.dt.yaml arch/arm/boot/dts/rk3288-veyron-mighty.dt.yaml arch/arm/boot/dts/rk3288-veyron-minnie.dt.yaml arch/arm/boot/dts/rk3288-veyron-pinky.dt.yaml arch/arm/boot/dts/rk3288-veyron-speedy.dt.yaml arch/arm/boot/dts/rk3288-veyron-tiger.dt.yaml arch/arm/boot/dts/rk3288-vyasa.dt.yaml
Le Thu, Mar 03, 2022 at 07:44:38AM -0600, Rob Herring a écrit : > On Wed, 02 Mar 2022 21:11:12 +0000, Corentin Labbe wrote: > > convert rockchip-crypto to yaml > > > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > > --- > > .../crypto/rockchip,rk3288-crypto.yaml | 64 +++++++++++++++++++ > > .../bindings/crypto/rockchip-crypto.txt | 28 -------- > > 2 files changed, 64 insertions(+), 28 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml > > delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1600075 > > > cypto-controller@ff8a0000: clock-names: ['aclk', 'hclk', 'sclk', 'apb_pclk'] is too long > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml > arch/arm/boot/dts/rk3288-evb-rk808.dt.yaml > arch/arm/boot/dts/rk3288-firefly-beta.dt.yaml > arch/arm/boot/dts/rk3288-firefly.dt.yaml > arch/arm/boot/dts/rk3288-firefly-reload.dt.yaml > arch/arm/boot/dts/rk3288-miqi.dt.yaml > arch/arm/boot/dts/rk3288-phycore-rdk.dt.yaml > arch/arm/boot/dts/rk3288-popmetal.dt.yaml > arch/arm/boot/dts/rk3288-r89.dt.yaml > arch/arm/boot/dts/rk3288-rock2-square.dt.yaml > arch/arm/boot/dts/rk3288-rock-pi-n8.dt.yaml > arch/arm/boot/dts/rk3288-tinker.dt.yaml > arch/arm/boot/dts/rk3288-tinker-s.dt.yaml > arch/arm/boot/dts/rk3288-veyron-brain.dt.yaml > arch/arm/boot/dts/rk3288-veyron-fievel.dt.yaml > arch/arm/boot/dts/rk3288-veyron-jaq.dt.yaml > arch/arm/boot/dts/rk3288-veyron-jerry.dt.yaml > arch/arm/boot/dts/rk3288-veyron-mickey.dt.yaml > arch/arm/boot/dts/rk3288-veyron-mighty.dt.yaml > arch/arm/boot/dts/rk3288-veyron-minnie.dt.yaml > arch/arm/boot/dts/rk3288-veyron-pinky.dt.yaml > arch/arm/boot/dts/rk3288-veyron-speedy.dt.yaml > arch/arm/boot/dts/rk3288-veyron-tiger.dt.yaml > arch/arm/boot/dts/rk3288-vyasa.dt.yaml > > cypto-controller@ff8a0000: clocks: [[7, 199], [7, 461], [7, 125], [7, 193]] is too long > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml > arch/arm/boot/dts/rk3288-evb-rk808.dt.yaml > arch/arm/boot/dts/rk3288-firefly-beta.dt.yaml > arch/arm/boot/dts/rk3288-firefly.dt.yaml > arch/arm/boot/dts/rk3288-firefly-reload.dt.yaml > arch/arm/boot/dts/rk3288-miqi.dt.yaml > arch/arm/boot/dts/rk3288-phycore-rdk.dt.yaml > arch/arm/boot/dts/rk3288-popmetal.dt.yaml > arch/arm/boot/dts/rk3288-r89.dt.yaml > arch/arm/boot/dts/rk3288-rock2-square.dt.yaml > arch/arm/boot/dts/rk3288-rock-pi-n8.dt.yaml > arch/arm/boot/dts/rk3288-tinker.dt.yaml > arch/arm/boot/dts/rk3288-tinker-s.dt.yaml > arch/arm/boot/dts/rk3288-veyron-brain.dt.yaml > arch/arm/boot/dts/rk3288-veyron-fievel.dt.yaml > arch/arm/boot/dts/rk3288-veyron-jaq.dt.yaml > arch/arm/boot/dts/rk3288-veyron-jerry.dt.yaml > arch/arm/boot/dts/rk3288-veyron-mickey.dt.yaml > arch/arm/boot/dts/rk3288-veyron-mighty.dt.yaml > arch/arm/boot/dts/rk3288-veyron-minnie.dt.yaml > arch/arm/boot/dts/rk3288-veyron-pinky.dt.yaml > arch/arm/boot/dts/rk3288-veyron-speedy.dt.yaml > arch/arm/boot/dts/rk3288-veyron-tiger.dt.yaml > arch/arm/boot/dts/rk3288-vyasa.dt.yaml > The patch fixing thoses warning is in the serie. Regards
On Wed, 02 Mar 2022 21:11:12 +0000, Corentin Labbe wrote: > convert rockchip-crypto to yaml > > Signed-off-by: Corentin Labbe <clabbe@baylibre.com> > --- > .../crypto/rockchip,rk3288-crypto.yaml | 64 +++++++++++++++++++ > .../bindings/crypto/rockchip-crypto.txt | 28 -------- > 2 files changed, 64 insertions(+), 28 deletions(-) > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml > delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml new file mode 100644 index 000000000000..1db03165f21a --- /dev/null +++ b/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/crypto/rockchip,rk3288-crypto.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rockchip Electronics And Security Accelerator + +maintainers: + - Heiko Stuebner <heiko@sntech.de> + +properties: + compatible: + const: rockchip,rk3288-crypto + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: clock data + - description: clock data + - description: clock crypto accelerator + + clock-names: + items: + - const: aclk + - const: hclk + - const: sclk + + resets: + maxItems: 1 + + reset-names: + const: crypto-rst + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + - resets + - reset-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/rk3288-cru.h> + crypto@ff8a0000 { + compatible = "rockchip,rk3288-crypto"; + reg = <0xff8a0000 0x4000>; + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>, + <&cru SCLK_CRYPTO>; + clock-names = "aclk", "hclk", "sclk"; + resets = <&cru SRST_CRYPTO>; + reset-names = "crypto-rst"; + }; diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt b/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt deleted file mode 100644 index 5e2ba385b8c9..000000000000 --- a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt +++ /dev/null @@ -1,28 +0,0 @@ -Rockchip Electronics And Security Accelerator - -Required properties: -- compatible: Should be "rockchip,rk3288-crypto" -- reg: Base physical address of the engine and length of memory mapped - region -- interrupts: Interrupt number -- clocks: Reference to the clocks about crypto -- clock-names: "aclk" used to clock data - "hclk" used to clock data - "sclk" used to clock crypto accelerator - "apb_pclk" used to clock dma -- resets: Must contain an entry for each entry in reset-names. - See ../reset/reset.txt for details. -- reset-names: Must include the name "crypto-rst". - -Examples: - - crypto: cypto-controller@ff8a0000 { - compatible = "rockchip,rk3288-crypto"; - reg = <0xff8a0000 0x4000>; - interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>, - <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>; - clock-names = "aclk", "hclk", "sclk", "apb_pclk"; - resets = <&cru SRST_CRYPTO>; - reset-names = "crypto-rst"; - };
convert rockchip-crypto to yaml Signed-off-by: Corentin Labbe <clabbe@baylibre.com> --- .../crypto/rockchip,rk3288-crypto.yaml | 64 +++++++++++++++++++ .../bindings/crypto/rockchip-crypto.txt | 28 -------- 2 files changed, 64 insertions(+), 28 deletions(-) create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt