| Message ID | 1644581655-11568-1-git-send-email-quic_kathirav@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | arm64: dts: qcom: ipq8074: fix the sleep clock frequency | expand |
On Fri 11 Feb 06:14 CST 2022, Kathiravan T wrote: > Sleep clock frequency should be 32768Hz. Lets fix it. > > Cc: stable@vger.kernel.org > Fixes: 41dac73e243d ("arm64: dts: Add ipq8074 SoC and HK01 board support") > Link: https://lore.kernel.org/all/e2a447f8-6024-0369-f698-2027b6edcf9e@codeaurora.org/ > Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> Can you please confirm this? The documentation for GCC says that the incoming sleep clock is 32000Hz. Regards, Bjorn > --- > arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi > index 26ba7ce9222c..b6287355ad08 100644 > --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi > @@ -13,7 +13,7 @@ > clocks { > sleep_clk: sleep_clk { > compatible = "fixed-clock"; > - clock-frequency = <32000>; > + clock-frequency = <32768>; > #clock-cells = <0>; > }; > > -- > 2.7.4 >
On 2/25/2022 1:27 AM, Bjorn Andersson wrote: > On Fri 11 Feb 06:14 CST 2022, Kathiravan T wrote: > >> Sleep clock frequency should be 32768Hz. Lets fix it. >> >> Cc: stable@vger.kernel.org >> Fixes: 41dac73e243d ("arm64: dts: Add ipq8074 SoC and HK01 board support") >> Link: https://lore.kernel.org/all/e2a447f8-6024-0369-f698-2027b6edcf9e@codeaurora.org/ >> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> > Can you please confirm this? The documentation for GCC says that the > incoming sleep clock is 32000Hz. > > Regards, > Bjorn Bjorn, I checked the internal documents and it is derived from the PMIC as 32.7645KHz. I rounded off it to 32768Hz. Looks like GCC documentation is not up-to-date. All these information is available in the link https://lore.kernel.org/all/e2a447f8-6024-0369-f698-2027b6edcf9e@codeaurora.org/ Please let me know if you need any further information. Thanks, Kathiravan T. >> --- >> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi >> index 26ba7ce9222c..b6287355ad08 100644 >> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi >> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi >> @@ -13,7 +13,7 @@ >> clocks { >> sleep_clk: sleep_clk { >> compatible = "fixed-clock"; >> - clock-frequency = <32000>; >> + clock-frequency = <32768>; >> #clock-cells = <0>; >> }; >> >> -- >> 2.7.4 >>
On 2/25/2022 5:48 PM, Kathiravan Thirumoorthy wrote: > > On 2/25/2022 1:27 AM, Bjorn Andersson wrote: >> On Fri 11 Feb 06:14 CST 2022, Kathiravan T wrote: >> >>> Sleep clock frequency should be 32768Hz. Lets fix it. >>> >>> Cc: stable@vger.kernel.org >>> Fixes: 41dac73e243d ("arm64: dts: Add ipq8074 SoC and HK01 board >>> support") >>> Link: >>> https://lore.kernel.org/all/e2a447f8-6024-0369-f698-2027b6edcf9e@codeaurora.org/ >>> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> >> Can you please confirm this? The documentation for GCC says that the >> incoming sleep clock is 32000Hz. >> >> Regards, >> Bjorn > > Bjorn, > > I checked the internal documents and it is derived from the PMIC as > 32.7645KHz. I rounded off it to 32768Hz. Looks like GCC documentation > is not up-to-date. > > All these information is available in the link > https://lore.kernel.org/all/e2a447f8-6024-0369-f698-2027b6edcf9e@codeaurora.org/ > > Please let me know if you need any further information. > > Thanks, > > Kathiravan T. Bjorn, Gentle Ping. Thanks, Kathiravan T. > >>> --- >>> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi >>> b/arch/arm64/boot/dts/qcom/ipq8074.dtsi >>> index 26ba7ce9222c..b6287355ad08 100644 >>> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi >>> @@ -13,7 +13,7 @@ >>> clocks { >>> sleep_clk: sleep_clk { >>> compatible = "fixed-clock"; >>> - clock-frequency = <32000>; >>> + clock-frequency = <32768>; >>> #clock-cells = <0>; >>> }; >>> -- >>> 2.7.4 >>>
diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi index 26ba7ce9222c..b6287355ad08 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -13,7 +13,7 @@ clocks { sleep_clk: sleep_clk { compatible = "fixed-clock"; - clock-frequency = <32000>; + clock-frequency = <32768>; #clock-cells = <0>; };
Sleep clock frequency should be 32768Hz. Lets fix it. Cc: stable@vger.kernel.org Fixes: 41dac73e243d ("arm64: dts: Add ipq8074 SoC and HK01 board support") Link: https://lore.kernel.org/all/e2a447f8-6024-0369-f698-2027b6edcf9e@codeaurora.org/ Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com> --- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)