| Message ID | 20220304122425.1638370-1-vkuznets@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: hyperv: make the format of 'Hyper-V: Host Build' output match x86 | expand |
From: Vitaly Kuznetsov <vkuznets@redhat.com> Sent: Friday, March 4, 2022 4:24 AM > > Currently, the following is observed on Hyper-V/ARM: > > Hyper-V: Host Build 10.0.22477.1061-1-0 > > This differs from similar output on x86: > > Hyper-V Host Build:20348-10.0-1-0.1138 > > and this is inconvenient. As x86 was the first to introduce the current > format and to not break existing tools parsing it, change the format on > ARM to match. Interesting. I had explicitly output this line differently on ARM64 so that the output is in the standard form of a Windows version number, which is what the Host Build value actually is. My intent is to fix the x86 side as well. I had not anticipated there being automated parsing of these strings. I had also put the colon in the place to be consistent with most other Hyper-V messages. I know: picky, picky. :-) What's the impact of changing the tools that parse it so that either version could be handled? Michael > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> > --- > arch/arm64/hyperv/mshyperv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c > index bbbe351e9045..7b9c1c542a77 100644 > --- a/arch/arm64/hyperv/mshyperv.c > +++ b/arch/arm64/hyperv/mshyperv.c > @@ -60,8 +60,8 @@ static int __init hyperv_init(void) > b = result.as32.b; > c = result.as32.c; > d = result.as32.d; > - pr_info("Hyper-V: Host Build %d.%d.%d.%d-%d-%d\n", > - b >> 16, b & 0xFFFF, a, d & 0xFFFFFF, c, d >> 24); > + pr_info("Hyper-V Host Build:%d-%d.%d-%d-%d.%d\n", > + a, b >> 16, b & 0xFFFF, c, d >> 24, d & 0xFFFFFF); > > ret = hv_common_init(); > if (ret) > -- > 2.35.1
"Michael Kelley (LINUX)" <mikelley@microsoft.com> writes: > From: Vitaly Kuznetsov <vkuznets@redhat.com> Sent: Friday, March 4, 2022 4:24 AM >> >> Currently, the following is observed on Hyper-V/ARM: >> >> Hyper-V: Host Build 10.0.22477.1061-1-0 >> >> This differs from similar output on x86: >> >> Hyper-V Host Build:20348-10.0-1-0.1138 >> >> and this is inconvenient. As x86 was the first to introduce the current >> format and to not break existing tools parsing it, change the format on >> ARM to match. > > Interesting. I had explicitly output this line differently on ARM64 so > that the output is in the standard form of a Windows version number, > which is what the Host Build value actually is. My intent is to fix the > x86 side as well. I had not anticipated there being automated parsing > of these strings. > > I had also put the colon in the place to be consistent with most > other Hyper-V messages. I know: picky, picky. :-) > > What's the impact of changing the tools that parse it so that > either version could be handled? I wish we knew what tools are out there parsing this line :-) The issue got reported by QA as 'inconsistency'. As the format of this string was never promissed to be an ABI I think we can go the other way around: change x86 to match ARM. Some scripts may need fixing but IMO this is acceptable. Let's just promiss to not change it in the future :-)
diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c index bbbe351e9045..7b9c1c542a77 100644 --- a/arch/arm64/hyperv/mshyperv.c +++ b/arch/arm64/hyperv/mshyperv.c @@ -60,8 +60,8 @@ static int __init hyperv_init(void) b = result.as32.b; c = result.as32.c; d = result.as32.d; - pr_info("Hyper-V: Host Build %d.%d.%d.%d-%d-%d\n", - b >> 16, b & 0xFFFF, a, d & 0xFFFFFF, c, d >> 24); + pr_info("Hyper-V Host Build:%d-%d.%d-%d-%d.%d\n", + a, b >> 16, b & 0xFFFF, c, d >> 24, d & 0xFFFFFF); ret = hv_common_init(); if (ret)
Currently, the following is observed on Hyper-V/ARM: Hyper-V: Host Build 10.0.22477.1061-1-0 This differs from similar output on x86: Hyper-V Host Build:20348-10.0-1-0.1138 and this is inconvenient. As x86 was the first to introduce the current format and to not break existing tools parsing it, change the format on ARM to match. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> --- arch/arm64/hyperv/mshyperv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)