diff mbox series

[v7,17/22] ui/cocoa: Constify qkeycode translation arrays

Message ID 20220306231753.50277-18-philippe.mathieu.daude@gmail.com (mailing list archive)
State New, archived
Headers show
Series host: Support macOS 12 | expand

Commit Message

Philippe Mathieu-Daudé March 6, 2022, 11:17 p.m. UTC 
From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 ui/cocoa.m | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Akihiko Odaki March 7, 2022, 4:16 a.m. UTC | #1 
Reviewed-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Tested-by: Akihiko Odaki <akihiko.odaki@gmail.com>

On Mon, Mar 7, 2022 at 8:19 AM Philippe Mathieu-Daudé
<philippe.mathieu.daude@gmail.com> wrote:
>
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  ui/cocoa.m | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/cocoa.m b/ui/cocoa.m
> index 8ab9ab5e84..a6db8ebfb6 100644
> --- a/ui/cocoa.m
> +++ b/ui/cocoa.m
> @@ -671,7 +671,7 @@ QemuCocoaView *cocoaView;
>
>      /* translates Macintosh keycodes to QEMU's keysym */
>
> -    int without_control_translation[] = {
> +    static const int without_control_translation[] = {
>          [0 ... 0xff] = 0,   // invalid key
>
>          [kVK_UpArrow]       = QEMU_KEY_UP,
> @@ -686,7 +686,7 @@ QemuCocoaView *cocoaView;
>          [kVK_Delete]        = QEMU_KEY_BACKSPACE,
>      };
>
> -    int with_control_translation[] = {
> +    static const int with_control_translation[] = {
>          [0 ... 0xff] = 0,   // invalid key
>
>          [kVK_UpArrow]       = QEMU_KEY_CTRL_UP,
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/ui/cocoa.m b/ui/cocoa.m
index 8ab9ab5e84..a6db8ebfb6 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -671,7 +671,7 @@  QemuCocoaView *cocoaView;
 
     /* translates Macintosh keycodes to QEMU's keysym */
 
-    int without_control_translation[] = {
+    static const int without_control_translation[] = {
         [0 ... 0xff] = 0,   // invalid key
 
         [kVK_UpArrow]       = QEMU_KEY_UP,
@@ -686,7 +686,7 @@  QemuCocoaView *cocoaView;
         [kVK_Delete]        = QEMU_KEY_BACKSPACE,
     };
 
-    int with_control_translation[] = {
+    static const int with_control_translation[] = {
         [0 ... 0xff] = 0,   // invalid key
 
         [kVK_UpArrow]       = QEMU_KEY_CTRL_UP,