| Message ID | 20220307032859.3275-6-jason-jh.lin@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Mediatek Soc DRM (vdosys0) support for mt8195 | expand |
On Mon, Mar 7, 2022 at 11:30 AM jason-jh.lin <jason-jh.lin@mediatek.com> wrote: > > Add mtk-mutex support for mt8195 vdosys0. > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > Acked-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Tested-by: Fei Shao <fshao@chromium.org> > --- > drivers/soc/mediatek/mtk-mutex.c | 103 ++++++++++++++++++++++++++++++- > 1 file changed, 100 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c > index aaf8fc1abb43..1c7ffcdadcea 100644 > --- a/drivers/soc/mediatek/mtk-mutex.c > +++ b/drivers/soc/mediatek/mtk-mutex.c > @@ -17,6 +17,9 @@ > #define MT8183_MUTEX0_MOD0 0x30 > #define MT8183_MUTEX0_SOF0 0x2c > > +#define MT8195_DISP_MUTEX0_MOD0 0x30 > +#define MT8195_DISP_MUTEX0_SOF 0x2c > + > #define DISP_REG_MUTEX_EN(n) (0x20 + 0x20 * (n)) > #define DISP_REG_MUTEX(n) (0x24 + 0x20 * (n)) > #define DISP_REG_MUTEX_RST(n) (0x28 + 0x20 * (n)) > @@ -96,6 +99,36 @@ > #define MT8173_MUTEX_MOD_DISP_PWM1 24 > #define MT8173_MUTEX_MOD_DISP_OD 25 > > +#define MT8195_MUTEX_MOD_DISP_OVL0 0 > +#define MT8195_MUTEX_MOD_DISP_WDMA0 1 > +#define MT8195_MUTEX_MOD_DISP_RDMA0 2 > +#define MT8195_MUTEX_MOD_DISP_COLOR0 3 > +#define MT8195_MUTEX_MOD_DISP_CCORR0 4 > +#define MT8195_MUTEX_MOD_DISP_AAL0 5 > +#define MT8195_MUTEX_MOD_DISP_GAMMA0 6 > +#define MT8195_MUTEX_MOD_DISP_DITHER0 7 > +#define MT8195_MUTEX_MOD_DISP_DSI0 8 > +#define MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE0 9 > +#define MT8195_MUTEX_MOD_DISP_OVL1 10 > +#define MT8195_MUTEX_MOD_DISP_WDMA1 11 > +#define MT8195_MUTEX_MOD_DISP_RDMA1 12 > +#define MT8195_MUTEX_MOD_DISP_COLOR1 13 > +#define MT8195_MUTEX_MOD_DISP_CCORR1 14 > +#define MT8195_MUTEX_MOD_DISP_AAL1 15 > +#define MT8195_MUTEX_MOD_DISP_GAMMA1 16 > +#define MT8195_MUTEX_MOD_DISP_DITHER1 17 > +#define MT8195_MUTEX_MOD_DISP_DSI1 18 > +#define MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE1 19 > +#define MT8195_MUTEX_MOD_DISP_VPP_MERGE 20 > +#define MT8195_MUTEX_MOD_DISP_DP_INTF0 21 > +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY0 22 > +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY1 23 > +#define MT8195_MUTEX_MOD_DISP_VDO1_DL_RELAY2 24 > +#define MT8195_MUTEX_MOD_DISP_VDO0_DL_RELAY3 25 > +#define MT8195_MUTEX_MOD_DISP_VDO0_DL_RELAY4 26 > +#define MT8195_MUTEX_MOD_DISP_PWM0 27 > +#define MT8195_MUTEX_MOD_DISP_PWM1 28 > + > #define MT2712_MUTEX_MOD_DISP_PWM2 10 > #define MT2712_MUTEX_MOD_DISP_OVL0 11 > #define MT2712_MUTEX_MOD_DISP_OVL1 12 > @@ -132,9 +165,21 @@ > #define MT8167_MUTEX_SOF_DPI1 3 > #define MT8183_MUTEX_SOF_DSI0 1 > #define MT8183_MUTEX_SOF_DPI0 2 > +#define MT8195_MUTEX_SOF_DSI0 1 > +#define MT8195_MUTEX_SOF_DSI1 2 > +#define MT8195_MUTEX_SOF_DP_INTF0 3 > +#define MT8195_MUTEX_SOF_DP_INTF1 4 > +#define MT8195_MUTEX_SOF_DPI0 6 /* for HDMI_TX */ > +#define MT8195_MUTEX_SOF_DPI1 5 /* for digital video out */ > > #define MT8183_MUTEX_EOF_DSI0 (MT8183_MUTEX_SOF_DSI0 << 6) > #define MT8183_MUTEX_EOF_DPI0 (MT8183_MUTEX_SOF_DPI0 << 6) > +#define MT8195_MUTEX_EOF_DSI0 (MT8195_MUTEX_SOF_DSI0 << 7) > +#define MT8195_MUTEX_EOF_DSI1 (MT8195_MUTEX_SOF_DSI1 << 7) > +#define MT8195_MUTEX_EOF_DP_INTF0 (MT8195_MUTEX_SOF_DP_INTF0 << 7) > +#define MT8195_MUTEX_EOF_DP_INTF1 (MT8195_MUTEX_SOF_DP_INTF1 << 7) > +#define MT8195_MUTEX_EOF_DPI0 (MT8195_MUTEX_SOF_DPI0 << 7) > +#define MT8195_MUTEX_EOF_DPI1 (MT8195_MUTEX_SOF_DPI1 << 7) > > struct mtk_mutex { > int id; > @@ -149,6 +194,9 @@ enum mtk_mutex_sof_id { > MUTEX_SOF_DPI1, > MUTEX_SOF_DSI2, > MUTEX_SOF_DSI3, > + MUTEX_SOF_DP_INTF0, > + MUTEX_SOF_DP_INTF1, > + DDP_MUTEX_SOF_MAX, > }; > > struct mtk_mutex_data { > @@ -270,7 +318,23 @@ static const unsigned int mt8192_mutex_mod[DDP_COMPONENT_ID_MAX] = { > [DDP_COMPONENT_RDMA4] = MT8192_MUTEX_MOD_DISP_RDMA4, > }; > > -static const unsigned int mt2712_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > +static const unsigned int mt8195_mutex_mod[DDP_COMPONENT_ID_MAX] = { > + [DDP_COMPONENT_OVL0] = MT8195_MUTEX_MOD_DISP_OVL0, > + [DDP_COMPONENT_WDMA0] = MT8195_MUTEX_MOD_DISP_WDMA0, > + [DDP_COMPONENT_RDMA0] = MT8195_MUTEX_MOD_DISP_RDMA0, > + [DDP_COMPONENT_COLOR0] = MT8195_MUTEX_MOD_DISP_COLOR0, > + [DDP_COMPONENT_CCORR] = MT8195_MUTEX_MOD_DISP_CCORR0, > + [DDP_COMPONENT_AAL0] = MT8195_MUTEX_MOD_DISP_AAL0, > + [DDP_COMPONENT_GAMMA] = MT8195_MUTEX_MOD_DISP_GAMMA0, > + [DDP_COMPONENT_DITHER] = MT8195_MUTEX_MOD_DISP_DITHER0, > + [DDP_COMPONENT_MERGE0] = MT8195_MUTEX_MOD_DISP_VPP_MERGE, > + [DDP_COMPONENT_DSC0] = MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE0, > + [DDP_COMPONENT_DSI0] = MT8195_MUTEX_MOD_DISP_DSI0, > + [DDP_COMPONENT_PWM0] = MT8195_MUTEX_MOD_DISP_PWM0, > + [DDP_COMPONENT_DP_INTF0] = MT8195_MUTEX_MOD_DISP_DP_INTF0, > +}; > + > +static const unsigned int mt2712_mutex_sof[DDP_MUTEX_SOF_MAX] = { > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0, > [MUTEX_SOF_DSI1] = MUTEX_SOF_DSI1, > @@ -280,7 +344,7 @@ static const unsigned int mt2712_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > [MUTEX_SOF_DSI3] = MUTEX_SOF_DSI3, > }; > > -static const unsigned int mt8167_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > +static const unsigned int mt8167_mutex_sof[DDP_MUTEX_SOF_MAX] = { > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0, > [MUTEX_SOF_DPI0] = MT8167_MUTEX_SOF_DPI0, > @@ -288,7 +352,7 @@ static const unsigned int mt8167_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > }; > > /* Add EOF setting so overlay hardware can receive frame done irq */ > -static const unsigned int mt8183_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > +static const unsigned int mt8183_mutex_sof[DDP_MUTEX_SOF_MAX] = { > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0 | MT8183_MUTEX_EOF_DSI0, > [MUTEX_SOF_DPI0] = MT8183_MUTEX_SOF_DPI0 | MT8183_MUTEX_EOF_DPI0, > @@ -300,6 +364,26 @@ static const unsigned int mt8186_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > [MUTEX_SOF_DPI0] = MT8186_MUTEX_SOF_DPI0 | MT8186_MUTEX_EOF_DPI0, > }; > > +/* > + * To support refresh mode(video mode), DISP_REG_MUTEX_SOF should > + * select the EOF source and configure the EOF plus timing from the > + * module that provides the timing signal. > + * So that MUTEX can not only send a STREAM_DONE event to GCE > + * but also detect the error at end of frame(EAEOF) when EOF signal > + * arrives. > + */ > +static const unsigned int mt8195_mutex_sof[DDP_MUTEX_SOF_MAX] = { > + [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > + [MUTEX_SOF_DSI0] = MT8195_MUTEX_SOF_DSI0 | MT8195_MUTEX_EOF_DSI0, > + [MUTEX_SOF_DSI1] = MT8195_MUTEX_SOF_DSI1 | MT8195_MUTEX_EOF_DSI1, > + [MUTEX_SOF_DPI0] = MT8195_MUTEX_SOF_DPI0 | MT8195_MUTEX_EOF_DPI0, > + [MUTEX_SOF_DPI1] = MT8195_MUTEX_SOF_DPI1 | MT8195_MUTEX_EOF_DPI1, > + [MUTEX_SOF_DP_INTF0] = > + MT8195_MUTEX_SOF_DP_INTF0 | MT8195_MUTEX_EOF_DP_INTF0, > + [MUTEX_SOF_DP_INTF1] = > + MT8195_MUTEX_SOF_DP_INTF1 | MT8195_MUTEX_EOF_DP_INTF1, > +}; > + > static const struct mtk_mutex_data mt2701_mutex_driver_data = { > .mutex_mod = mt2701_mutex_mod, > .mutex_sof = mt2712_mutex_sof, > @@ -351,6 +435,13 @@ static const struct mtk_mutex_data mt8192_mutex_driver_data = { > .mutex_sof_reg = MT8183_MUTEX0_SOF0, > }; > > +static const struct mtk_mutex_data mt8195_mutex_driver_data = { > + .mutex_mod = mt8195_mutex_mod, > + .mutex_sof = mt8195_mutex_sof, > + .mutex_mod_reg = MT8195_DISP_MUTEX0_MOD0, > + .mutex_sof_reg = MT8195_DISP_MUTEX0_SOF, > +}; > + > struct mtk_mutex *mtk_mutex_get(struct device *dev) > { > struct mtk_mutex_ctx *mtx = dev_get_drvdata(dev); > @@ -423,6 +514,9 @@ void mtk_mutex_add_comp(struct mtk_mutex *mutex, > case DDP_COMPONENT_DPI1: > sof_id = MUTEX_SOF_DPI1; > break; > + case DDP_COMPONENT_DP_INTF0: > + sof_id = MUTEX_SOF_DP_INTF0; > + break; > default: > if (mtx->data->mutex_mod[id] < 32) { > offset = DISP_REG_MUTEX_MOD(mtx->data->mutex_mod_reg, > @@ -462,6 +556,7 @@ void mtk_mutex_remove_comp(struct mtk_mutex *mutex, > case DDP_COMPONENT_DSI3: > case DDP_COMPONENT_DPI0: > case DDP_COMPONENT_DPI1: > + case DDP_COMPONENT_DP_INTF0: > writel_relaxed(MUTEX_SOF_SINGLE_MODE, > mtx->regs + > DISP_REG_MUTEX_SOF(mtx->data->mutex_sof_reg, > @@ -587,6 +682,8 @@ static const struct of_device_id mutex_driver_dt_match[] = { > .data = &mt8186_mutex_driver_data}, > { .compatible = "mediatek,mt8192-disp-mutex", > .data = &mt8192_mutex_driver_data}, > + { .compatible = "mediatek,mt8195-disp-mutex", > + .data = &mt8195_mutex_driver_data}, > {}, > }; > MODULE_DEVICE_TABLE(of, mutex_driver_dt_match); > -- > 2.18.0 >
Hi, Jason: On Mon, 2022-03-07 at 11:28 +0800, jason-jh.lin wrote: > Add mtk-mutex support for mt8195 vdosys0. > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > Acked-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > --- > drivers/soc/mediatek/mtk-mutex.c | 103 > ++++++++++++++++++++++++++++++- > 1 file changed, 100 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-mutex.c > b/drivers/soc/mediatek/mtk-mutex.c > index aaf8fc1abb43..1c7ffcdadcea 100644 > --- a/drivers/soc/mediatek/mtk-mutex.c > +++ b/drivers/soc/mediatek/mtk-mutex.c > @@ -17,6 +17,9 @@ > #define MT8183_MUTEX0_MOD0 0x30 > #define MT8183_MUTEX0_SOF0 0x2c > > +#define MT8195_DISP_MUTEX0_MOD0 0x30 > +#define MT8195_DISP_MUTEX0_SOF 0x2c > + > #define DISP_REG_MUTEX_EN(n) (0x20 + 0x20 * (n)) > #define DISP_REG_MUTEX(n) (0x24 + 0x20 * (n)) > #define DISP_REG_MUTEX_RST(n) (0x28 + 0x20 * > (n)) > @@ -96,6 +99,36 @@ > #define MT8173_MUTEX_MOD_DISP_PWM1 24 > #define MT8173_MUTEX_MOD_DISP_OD 25 > > +#define MT8195_MUTEX_MOD_DISP_OVL0 0 > +#define MT8195_MUTEX_MOD_DISP_WDMA0 1 > +#define MT8195_MUTEX_MOD_DISP_RDMA0 2 > +#define MT8195_MUTEX_MOD_DISP_COLOR0 3 > +#define MT8195_MUTEX_MOD_DISP_CCORR0 4 > +#define MT8195_MUTEX_MOD_DISP_AAL0 5 > +#define MT8195_MUTEX_MOD_DISP_GAMMA0 6 > +#define MT8195_MUTEX_MOD_DISP_DITHER0 7 > +#define MT8195_MUTEX_MOD_DISP_DSI0 8 > +#define MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE0 9 > +#define MT8195_MUTEX_MOD_DISP_OVL1 10 > +#define MT8195_MUTEX_MOD_DISP_WDMA1 11 > +#define MT8195_MUTEX_MOD_DISP_RDMA1 12 > +#define MT8195_MUTEX_MOD_DISP_COLOR1 13 > +#define MT8195_MUTEX_MOD_DISP_CCORR1 14 > +#define MT8195_MUTEX_MOD_DISP_AAL1 15 > +#define MT8195_MUTEX_MOD_DISP_GAMMA1 16 > +#define MT8195_MUTEX_MOD_DISP_DITHER1 17 > +#define MT8195_MUTEX_MOD_DISP_DSI1 18 > +#define MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE1 19 > +#define MT8195_MUTEX_MOD_DISP_VPP_MERGE 20 > +#define MT8195_MUTEX_MOD_DISP_DP_INTF0 21 > +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY0 22 Useless, remove. > +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY1 23 Ditto. Regards, CK > +#define MT8195_MUTEX_MOD_DISP_VDO1_DL_RELAY2 24 > +#define MT8195_MUTEX_MOD_DISP_VDO0_DL_RELAY3 25 > +#define MT8195_MUTEX_MOD_DISP_VDO0_DL_RELAY4 26 > +#define MT8195_MUTEX_MOD_DISP_PWM0 27 > +#define MT8195_MUTEX_MOD_DISP_PWM1 28 > + > #define MT2712_MUTEX_MOD_DISP_PWM2 10 > #define MT2712_MUTEX_MOD_DISP_OVL0 11 > #define MT2712_MUTEX_MOD_DISP_OVL1 12 > @@ -132,9 +165,21 @@ > #define MT8167_MUTEX_SOF_DPI1 3 > #define MT8183_MUTEX_SOF_DSI0 1 > #define MT8183_MUTEX_SOF_DPI0 2 > +#define MT8195_MUTEX_SOF_DSI0 1 > +#define MT8195_MUTEX_SOF_DSI1 2 > +#define MT8195_MUTEX_SOF_DP_INTF0 3 > +#define MT8195_MUTEX_SOF_DP_INTF1 4 > +#define MT8195_MUTEX_SOF_DPI0 6 /* for > HDMI_TX */ > +#define MT8195_MUTEX_SOF_DPI1 5 /* for > digital video out */ > > #define MT8183_MUTEX_EOF_DSI0 (MT8183_MUTEX_S > OF_DSI0 << 6) > #define MT8183_MUTEX_EOF_DPI0 (MT8183_MUTEX_S > OF_DPI0 << 6) > +#define MT8195_MUTEX_EOF_DSI0 (MT8195_MUTEX_S > OF_DSI0 << 7) > +#define MT8195_MUTEX_EOF_DSI1 (MT8195_MUTEX_S > OF_DSI1 << 7) > +#define MT8195_MUTEX_EOF_DP_INTF0 (MT8195_MUTEX_SOF_DP_IN > TF0 << 7) > +#define MT8195_MUTEX_EOF_DP_INTF1 (MT8195_MUTEX_SOF_DP_IN > TF1 << 7) > +#define MT8195_MUTEX_EOF_DPI0 (MT8195_MUTEX_S > OF_DPI0 << 7) > +#define MT8195_MUTEX_EOF_DPI1 (MT8195_MUTEX_S > OF_DPI1 << 7) > > struct mtk_mutex { > int id; > @@ -149,6 +194,9 @@ enum mtk_mutex_sof_id { > MUTEX_SOF_DPI1, > MUTEX_SOF_DSI2, > MUTEX_SOF_DSI3, > + MUTEX_SOF_DP_INTF0, > + MUTEX_SOF_DP_INTF1, > + DDP_MUTEX_SOF_MAX, > }; > > struct mtk_mutex_data { > @@ -270,7 +318,23 @@ static const unsigned int > mt8192_mutex_mod[DDP_COMPONENT_ID_MAX] = { > [DDP_COMPONENT_RDMA4] = MT8192_MUTEX_MOD_DISP_RDMA4, > }; > > -static const unsigned int mt2712_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > +static const unsigned int mt8195_mutex_mod[DDP_COMPONENT_ID_MAX] = { > + [DDP_COMPONENT_OVL0] = MT8195_MUTEX_MOD_DISP_OVL0, > + [DDP_COMPONENT_WDMA0] = MT8195_MUTEX_MOD_DISP_WDMA0, > + [DDP_COMPONENT_RDMA0] = MT8195_MUTEX_MOD_DISP_RDMA0, > + [DDP_COMPONENT_COLOR0] = MT8195_MUTEX_MOD_DISP_COLOR0, > + [DDP_COMPONENT_CCORR] = MT8195_MUTEX_MOD_DISP_CCORR0, > + [DDP_COMPONENT_AAL0] = MT8195_MUTEX_MOD_DISP_AAL0, > + [DDP_COMPONENT_GAMMA] = MT8195_MUTEX_MOD_DISP_GAMMA0, > + [DDP_COMPONENT_DITHER] = MT8195_MUTEX_MOD_DISP_DITHER0, > + [DDP_COMPONENT_MERGE0] = MT8195_MUTEX_MOD_DISP_VPP_MERGE, > + [DDP_COMPONENT_DSC0] = MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE0, > + [DDP_COMPONENT_DSI0] = MT8195_MUTEX_MOD_DISP_DSI0, > + [DDP_COMPONENT_PWM0] = MT8195_MUTEX_MOD_DISP_PWM0, > + [DDP_COMPONENT_DP_INTF0] = MT8195_MUTEX_MOD_DISP_DP_INTF0, > +}; > + > +static const unsigned int mt2712_mutex_sof[DDP_MUTEX_SOF_MAX] = { > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0, > [MUTEX_SOF_DSI1] = MUTEX_SOF_DSI1, > @@ -280,7 +344,7 @@ static const unsigned int > mt2712_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > [MUTEX_SOF_DSI3] = MUTEX_SOF_DSI3, > }; > > -static const unsigned int mt8167_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > +static const unsigned int mt8167_mutex_sof[DDP_MUTEX_SOF_MAX] = { > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0, > [MUTEX_SOF_DPI0] = MT8167_MUTEX_SOF_DPI0, > @@ -288,7 +352,7 @@ static const unsigned int > mt8167_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > }; > > /* Add EOF setting so overlay hardware can receive frame done irq */ > -static const unsigned int mt8183_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > +static const unsigned int mt8183_mutex_sof[DDP_MUTEX_SOF_MAX] = { > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0 | MT8183_MUTEX_EOF_DSI0, > [MUTEX_SOF_DPI0] = MT8183_MUTEX_SOF_DPI0 | > MT8183_MUTEX_EOF_DPI0, > @@ -300,6 +364,26 @@ static const unsigned int > mt8186_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > [MUTEX_SOF_DPI0] = MT8186_MUTEX_SOF_DPI0 | > MT8186_MUTEX_EOF_DPI0, > }; > > +/* > + * To support refresh mode(video mode), DISP_REG_MUTEX_SOF should > + * select the EOF source and configure the EOF plus timing from the > + * module that provides the timing signal. > + * So that MUTEX can not only send a STREAM_DONE event to GCE > + * but also detect the error at end of frame(EAEOF) when EOF signal > + * arrives. > + */ > +static const unsigned int mt8195_mutex_sof[DDP_MUTEX_SOF_MAX] = { > + [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > + [MUTEX_SOF_DSI0] = MT8195_MUTEX_SOF_DSI0 | > MT8195_MUTEX_EOF_DSI0, > + [MUTEX_SOF_DSI1] = MT8195_MUTEX_SOF_DSI1 | > MT8195_MUTEX_EOF_DSI1, > + [MUTEX_SOF_DPI0] = MT8195_MUTEX_SOF_DPI0 | > MT8195_MUTEX_EOF_DPI0, > + [MUTEX_SOF_DPI1] = MT8195_MUTEX_SOF_DPI1 | > MT8195_MUTEX_EOF_DPI1, > + [MUTEX_SOF_DP_INTF0] = > + MT8195_MUTEX_SOF_DP_INTF0 | MT8195_MUTEX_EOF_DP_INTF0, > + [MUTEX_SOF_DP_INTF1] = > + MT8195_MUTEX_SOF_DP_INTF1 | MT8195_MUTEX_EOF_DP_INTF1, > +}; > + > static const struct mtk_mutex_data mt2701_mutex_driver_data = { > .mutex_mod = mt2701_mutex_mod, > .mutex_sof = mt2712_mutex_sof, > @@ -351,6 +435,13 @@ static const struct mtk_mutex_data > mt8192_mutex_driver_data = { > .mutex_sof_reg = MT8183_MUTEX0_SOF0, > }; > > +static const struct mtk_mutex_data mt8195_mutex_driver_data = { > + .mutex_mod = mt8195_mutex_mod, > + .mutex_sof = mt8195_mutex_sof, > + .mutex_mod_reg = MT8195_DISP_MUTEX0_MOD0, > + .mutex_sof_reg = MT8195_DISP_MUTEX0_SOF, > +}; > + > struct mtk_mutex *mtk_mutex_get(struct device *dev) > { > struct mtk_mutex_ctx *mtx = dev_get_drvdata(dev); > @@ -423,6 +514,9 @@ void mtk_mutex_add_comp(struct mtk_mutex *mutex, > case DDP_COMPONENT_DPI1: > sof_id = MUTEX_SOF_DPI1; > break; > + case DDP_COMPONENT_DP_INTF0: > + sof_id = MUTEX_SOF_DP_INTF0; > + break; > default: > if (mtx->data->mutex_mod[id] < 32) { > offset = DISP_REG_MUTEX_MOD(mtx->data- > >mutex_mod_reg, > @@ -462,6 +556,7 @@ void mtk_mutex_remove_comp(struct mtk_mutex > *mutex, > case DDP_COMPONENT_DSI3: > case DDP_COMPONENT_DPI0: > case DDP_COMPONENT_DPI1: > + case DDP_COMPONENT_DP_INTF0: > writel_relaxed(MUTEX_SOF_SINGLE_MODE, > mtx->regs + > DISP_REG_MUTEX_SOF(mtx->data- > >mutex_sof_reg, > @@ -587,6 +682,8 @@ static const struct of_device_id > mutex_driver_dt_match[] = { > .data = &mt8186_mutex_driver_data}, > { .compatible = "mediatek,mt8192-disp-mutex", > .data = &mt8192_mutex_driver_data}, > + { .compatible = "mediatek,mt8195-disp-mutex", > + .data = &mt8195_mutex_driver_data}, > {}, > }; > MODULE_DEVICE_TABLE(of, mutex_driver_dt_match);
Hi CK, Thanks for the reviews. On Fri, 2022-03-18 at 15:21 +0800, CK Hu wrote: > Hi, Jason: > > On Mon, 2022-03-07 at 11:28 +0800, jason-jh.lin wrote: > > Add mtk-mutex support for mt8195 vdosys0. > > > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > > Acked-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > drivers/soc/mediatek/mtk-mutex.c | 103 > > ++++++++++++++++++++++++++++++- > > 1 file changed, 100 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-mutex.c > > b/drivers/soc/mediatek/mtk-mutex.c > > index aaf8fc1abb43..1c7ffcdadcea 100644 > > --- a/drivers/soc/mediatek/mtk-mutex.c > > +++ b/drivers/soc/mediatek/mtk-mutex.c > > @@ -17,6 +17,9 @@ > > #define MT8183_MUTEX0_MOD0 0x30 > > #define MT8183_MUTEX0_SOF0 0x2c > > > > +#define MT8195_DISP_MUTEX0_MOD0 0x30 > > +#define MT8195_DISP_MUTEX0_SOF 0x2c > > + > > #define DISP_REG_MUTEX_EN(n) (0x20 + 0x20 * > > (n)) > > #define DISP_REG_MUTEX(n) (0x24 + 0x20 * (n)) > > #define DISP_REG_MUTEX_RST(n) (0x28 + 0x20 * > > (n)) > > @@ -96,6 +99,36 @@ > > #define MT8173_MUTEX_MOD_DISP_PWM1 24 > > #define MT8173_MUTEX_MOD_DISP_OD 25 > > > > +#define MT8195_MUTEX_MOD_DISP_OVL0 0 > > +#define MT8195_MUTEX_MOD_DISP_WDMA0 1 > > +#define MT8195_MUTEX_MOD_DISP_RDMA0 2 > > +#define MT8195_MUTEX_MOD_DISP_COLOR0 3 > > +#define MT8195_MUTEX_MOD_DISP_CCORR0 4 > > +#define MT8195_MUTEX_MOD_DISP_AAL0 5 > > +#define MT8195_MUTEX_MOD_DISP_GAMMA0 6 > > +#define MT8195_MUTEX_MOD_DISP_DITHER0 7 > > +#define MT8195_MUTEX_MOD_DISP_DSI0 8 > > +#define MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE0 9 > > +#define MT8195_MUTEX_MOD_DISP_OVL1 10 > > +#define MT8195_MUTEX_MOD_DISP_WDMA1 11 > > +#define MT8195_MUTEX_MOD_DISP_RDMA1 12 > > +#define MT8195_MUTEX_MOD_DISP_COLOR1 13 > > +#define MT8195_MUTEX_MOD_DISP_CCORR1 14 > > +#define MT8195_MUTEX_MOD_DISP_AAL1 15 > > +#define MT8195_MUTEX_MOD_DISP_GAMMA1 16 > > +#define MT8195_MUTEX_MOD_DISP_DITHER1 17 > > +#define MT8195_MUTEX_MOD_DISP_DSI1 18 > > +#define MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE1 19 > > +#define MT8195_MUTEX_MOD_DISP_VPP_MERGE 20 > > +#define MT8195_MUTEX_MOD_DISP_DP_INTF0 21 > > +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY0 22 > > Useless, remove. > > > +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY1 23 > > Ditto. > > Regards, > CK > Although these definitions are not used, they represent the functionality provided by this register. I think we can show that we have these capabilities by defining them. Can we keep these definitions? Regards, Jason-JH.Lin > > +#define MT8195_MUTEX_MOD_DISP_VDO1_DL_RELAY2 24 > > +#define MT8195_MUTEX_MOD_DISP_VDO0_DL_RELAY3 25 > > +#define MT8195_MUTEX_MOD_DISP_VDO0_DL_RELAY4 26 > > +#define MT8195_MUTEX_MOD_DISP_PWM0 27 > > +#define MT8195_MUTEX_MOD_DISP_PWM1 28 > > + > > #define MT2712_MUTEX_MOD_DISP_PWM2 10 > > #define MT2712_MUTEX_MOD_DISP_OVL0 11 > > #define MT2712_MUTEX_MOD_DISP_OVL1 12 > > @@ -132,9 +165,21 @@ > > #define MT8167_MUTEX_SOF_DPI1 3 > > #define MT8183_MUTEX_SOF_DSI0 1 > > #define MT8183_MUTEX_SOF_DPI0 2 > > +#define MT8195_MUTEX_SOF_DSI0 1 > > +#define MT8195_MUTEX_SOF_DSI1 2 > > +#define MT8195_MUTEX_SOF_DP_INTF0 3 > > +#define MT8195_MUTEX_SOF_DP_INTF1 4 > > +#define MT8195_MUTEX_SOF_DPI0 6 /* for > > HDMI_TX */ > > +#define MT8195_MUTEX_SOF_DPI1 5 /* for > > digital video out */ > > > > #define MT8183_MUTEX_EOF_DSI0 (MT8183_MUTEX_S > > OF_DSI0 << 6) > > #define MT8183_MUTEX_EOF_DPI0 (MT8183_MUTEX_S > > OF_DPI0 << 6) > > +#define MT8195_MUTEX_EOF_DSI0 (MT8195_MUTEX_S > > OF_DSI0 << 7) > > +#define MT8195_MUTEX_EOF_DSI1 (MT8195_MUTEX_S > > OF_DSI1 << 7) > > +#define MT8195_MUTEX_EOF_DP_INTF0 (MT8195_MUTEX_SOF_DP_IN > > TF0 << 7) > > +#define MT8195_MUTEX_EOF_DP_INTF1 (MT8195_MUTEX_SOF_DP_IN > > TF1 << 7) > > +#define MT8195_MUTEX_EOF_DPI0 (MT8195_MUTEX_S > > OF_DPI0 << 7) > > +#define MT8195_MUTEX_EOF_DPI1 (MT8195_MUTEX_S > > OF_DPI1 << 7) > > > > struct mtk_mutex { > > int id; > > @@ -149,6 +194,9 @@ enum mtk_mutex_sof_id { > > MUTEX_SOF_DPI1, > > MUTEX_SOF_DSI2, > > MUTEX_SOF_DSI3, > > + MUTEX_SOF_DP_INTF0, > > + MUTEX_SOF_DP_INTF1, > > + DDP_MUTEX_SOF_MAX, > > }; > > > > struct mtk_mutex_data { > > @@ -270,7 +318,23 @@ static const unsigned int > > mt8192_mutex_mod[DDP_COMPONENT_ID_MAX] = { > > [DDP_COMPONENT_RDMA4] = MT8192_MUTEX_MOD_DISP_RDMA4, > > }; > > > > -static const unsigned int mt2712_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > > +static const unsigned int mt8195_mutex_mod[DDP_COMPONENT_ID_MAX] = > > { > > + [DDP_COMPONENT_OVL0] = MT8195_MUTEX_MOD_DISP_OVL0, > > + [DDP_COMPONENT_WDMA0] = MT8195_MUTEX_MOD_DISP_WDMA0, > > + [DDP_COMPONENT_RDMA0] = MT8195_MUTEX_MOD_DISP_RDMA0, > > + [DDP_COMPONENT_COLOR0] = MT8195_MUTEX_MOD_DISP_COLOR0, > > + [DDP_COMPONENT_CCORR] = MT8195_MUTEX_MOD_DISP_CCORR0, > > + [DDP_COMPONENT_AAL0] = MT8195_MUTEX_MOD_DISP_AAL0, > > + [DDP_COMPONENT_GAMMA] = MT8195_MUTEX_MOD_DISP_GAMMA0, > > + [DDP_COMPONENT_DITHER] = MT8195_MUTEX_MOD_DISP_DITHER0, > > + [DDP_COMPONENT_MERGE0] = MT8195_MUTEX_MOD_DISP_VPP_MERGE, > > + [DDP_COMPONENT_DSC0] = MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE0, > > + [DDP_COMPONENT_DSI0] = MT8195_MUTEX_MOD_DISP_DSI0, > > + [DDP_COMPONENT_PWM0] = MT8195_MUTEX_MOD_DISP_PWM0, > > + [DDP_COMPONENT_DP_INTF0] = MT8195_MUTEX_MOD_DISP_DP_INTF0, > > +}; > > + > > +static const unsigned int mt2712_mutex_sof[DDP_MUTEX_SOF_MAX] = { > > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0, > > [MUTEX_SOF_DSI1] = MUTEX_SOF_DSI1, > > @@ -280,7 +344,7 @@ static const unsigned int > > mt2712_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > > [MUTEX_SOF_DSI3] = MUTEX_SOF_DSI3, > > }; > > > > -static const unsigned int mt8167_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > > +static const unsigned int mt8167_mutex_sof[DDP_MUTEX_SOF_MAX] = { > > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0, > > [MUTEX_SOF_DPI0] = MT8167_MUTEX_SOF_DPI0, > > @@ -288,7 +352,7 @@ static const unsigned int > > mt8167_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > > }; > > > > /* Add EOF setting so overlay hardware can receive frame done irq > > */ > > -static const unsigned int mt8183_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > > +static const unsigned int mt8183_mutex_sof[DDP_MUTEX_SOF_MAX] = { > > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0 | MT8183_MUTEX_EOF_DSI0, > > [MUTEX_SOF_DPI0] = MT8183_MUTEX_SOF_DPI0 | > > MT8183_MUTEX_EOF_DPI0, > > @@ -300,6 +364,26 @@ static const unsigned int > > mt8186_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > > [MUTEX_SOF_DPI0] = MT8186_MUTEX_SOF_DPI0 | > > MT8186_MUTEX_EOF_DPI0, > > }; > > > > +/* > > + * To support refresh mode(video mode), DISP_REG_MUTEX_SOF should > > + * select the EOF source and configure the EOF plus timing from > > the > > + * module that provides the timing signal. > > + * So that MUTEX can not only send a STREAM_DONE event to GCE > > + * but also detect the error at end of frame(EAEOF) when EOF > > signal > > + * arrives. > > + */ > > +static const unsigned int mt8195_mutex_sof[DDP_MUTEX_SOF_MAX] = { > > + [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > > + [MUTEX_SOF_DSI0] = MT8195_MUTEX_SOF_DSI0 | > > MT8195_MUTEX_EOF_DSI0, > > + [MUTEX_SOF_DSI1] = MT8195_MUTEX_SOF_DSI1 | > > MT8195_MUTEX_EOF_DSI1, > > + [MUTEX_SOF_DPI0] = MT8195_MUTEX_SOF_DPI0 | > > MT8195_MUTEX_EOF_DPI0, > > + [MUTEX_SOF_DPI1] = MT8195_MUTEX_SOF_DPI1 | > > MT8195_MUTEX_EOF_DPI1, > > + [MUTEX_SOF_DP_INTF0] = > > + MT8195_MUTEX_SOF_DP_INTF0 | MT8195_MUTEX_EOF_DP_INTF0, > > + [MUTEX_SOF_DP_INTF1] = > > + MT8195_MUTEX_SOF_DP_INTF1 | MT8195_MUTEX_EOF_DP_INTF1, > > +}; > > + > > static const struct mtk_mutex_data mt2701_mutex_driver_data = { > > .mutex_mod = mt2701_mutex_mod, > > .mutex_sof = mt2712_mutex_sof, > > @@ -351,6 +435,13 @@ static const struct mtk_mutex_data > > mt8192_mutex_driver_data = { > > .mutex_sof_reg = MT8183_MUTEX0_SOF0, > > }; > > > > +static const struct mtk_mutex_data mt8195_mutex_driver_data = { > > + .mutex_mod = mt8195_mutex_mod, > > + .mutex_sof = mt8195_mutex_sof, > > + .mutex_mod_reg = MT8195_DISP_MUTEX0_MOD0, > > + .mutex_sof_reg = MT8195_DISP_MUTEX0_SOF, > > +}; > > + > > struct mtk_mutex *mtk_mutex_get(struct device *dev) > > { > > struct mtk_mutex_ctx *mtx = dev_get_drvdata(dev); > > @@ -423,6 +514,9 @@ void mtk_mutex_add_comp(struct mtk_mutex > > *mutex, > > case DDP_COMPONENT_DPI1: > > sof_id = MUTEX_SOF_DPI1; > > break; > > + case DDP_COMPONENT_DP_INTF0: > > + sof_id = MUTEX_SOF_DP_INTF0; > > + break; > > default: > > if (mtx->data->mutex_mod[id] < 32) { > > offset = DISP_REG_MUTEX_MOD(mtx->data- > > > mutex_mod_reg, > > > > @@ -462,6 +556,7 @@ void mtk_mutex_remove_comp(struct mtk_mutex > > *mutex, > > case DDP_COMPONENT_DSI3: > > case DDP_COMPONENT_DPI0: > > case DDP_COMPONENT_DPI1: > > + case DDP_COMPONENT_DP_INTF0: > > writel_relaxed(MUTEX_SOF_SINGLE_MODE, > > mtx->regs + > > DISP_REG_MUTEX_SOF(mtx->data- > > > mutex_sof_reg, > > > > @@ -587,6 +682,8 @@ static const struct of_device_id > > mutex_driver_dt_match[] = { > > .data = &mt8186_mutex_driver_data}, > > { .compatible = "mediatek,mt8192-disp-mutex", > > .data = &mt8192_mutex_driver_data}, > > + { .compatible = "mediatek,mt8195-disp-mutex", > > + .data = &mt8195_mutex_driver_data}, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, mutex_driver_dt_match); > >
Hi, Jason: On Mon, 2022-03-28 at 12:45 +0800, Jason-JH Lin wrote: > Hi CK, > > Thanks for the reviews. > > On Fri, 2022-03-18 at 15:21 +0800, CK Hu wrote: > > Hi, Jason: > > > > On Mon, 2022-03-07 at 11:28 +0800, jason-jh.lin wrote: > > > Add mtk-mutex support for mt8195 vdosys0. > > > > > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > > > Acked-by: AngeloGioacchino Del Regno < > > > angelogioacchino.delregno@collabora.com> > > > --- > > > drivers/soc/mediatek/mtk-mutex.c | 103 > > > ++++++++++++++++++++++++++++++- > > > 1 file changed, 100 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/soc/mediatek/mtk-mutex.c > > > b/drivers/soc/mediatek/mtk-mutex.c > > > index aaf8fc1abb43..1c7ffcdadcea 100644 > > > --- a/drivers/soc/mediatek/mtk-mutex.c > > > +++ b/drivers/soc/mediatek/mtk-mutex.c > > > @@ -17,6 +17,9 @@ > > > #define MT8183_MUTEX0_MOD0 0x30 > > > #define MT8183_MUTEX0_SOF0 0x2c > > > > > > +#define MT8195_DISP_MUTEX0_MOD0 0x30 > > > +#define MT8195_DISP_MUTEX0_SOF 0x2c > > > + > > > #define DISP_REG_MUTEX_EN(n) (0x20 + 0x20 * > > > (n)) > > > #define DISP_REG_MUTEX(n) (0x24 + 0x20 * > > > (n)) > > > #define DISP_REG_MUTEX_RST(n) (0x28 + 0x20 * > > > (n)) > > > @@ -96,6 +99,36 @@ > > > #define MT8173_MUTEX_MOD_DISP_PWM1 24 > > > #define MT8173_MUTEX_MOD_DISP_OD 25 > > > > > > +#define MT8195_MUTEX_MOD_DISP_OVL0 0 > > > +#define MT8195_MUTEX_MOD_DISP_WDMA0 1 > > > +#define MT8195_MUTEX_MOD_DISP_RDMA0 2 > > > +#define MT8195_MUTEX_MOD_DISP_COLOR0 3 > > > +#define MT8195_MUTEX_MOD_DISP_CCORR0 4 > > > +#define MT8195_MUTEX_MOD_DISP_AAL0 5 > > > +#define MT8195_MUTEX_MOD_DISP_GAMMA0 6 > > > +#define MT8195_MUTEX_MOD_DISP_DITHER0 7 > > > +#define MT8195_MUTEX_MOD_DISP_DSI0 8 > > > +#define MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE0 9 > > > +#define MT8195_MUTEX_MOD_DISP_OVL1 10 > > > +#define MT8195_MUTEX_MOD_DISP_WDMA1 11 > > > +#define MT8195_MUTEX_MOD_DISP_RDMA1 12 > > > +#define MT8195_MUTEX_MOD_DISP_COLOR1 13 > > > +#define MT8195_MUTEX_MOD_DISP_CCORR1 14 > > > +#define MT8195_MUTEX_MOD_DISP_AAL1 15 > > > +#define MT8195_MUTEX_MOD_DISP_GAMMA1 16 > > > +#define MT8195_MUTEX_MOD_DISP_DITHER1 17 > > > +#define MT8195_MUTEX_MOD_DISP_DSI1 18 > > > +#define MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE1 19 > > > +#define MT8195_MUTEX_MOD_DISP_VPP_MERGE 20 > > > +#define MT8195_MUTEX_MOD_DISP_DP_INTF0 21 > > > +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY0 22 > > > > Useless, remove. > > > > > +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY1 23 > > > > Ditto. > > > > Regards, > > CK > > > > Although these definitions are not used, they represent the > functionality provided by this register. > > I think we can show that we have these capabilities by defining them. > > Can we keep these definitions? OK, but add some information that we could know how to use it. What's these DL_RELAY and when should we add these to mutex? Regards, CK > > Regards, > Jason-JH.Lin > > > +#define MT8195_MUTEX_MOD_DISP_VDO1_DL_RELAY2 24 > > > +#define MT8195_MUTEX_MOD_DISP_VDO0_DL_RELAY3 25 > > > +#define MT8195_MUTEX_MOD_DISP_VDO0_DL_RELAY4 26 > > > +#define MT8195_MUTEX_MOD_DISP_PWM0 27 > > > +#define MT8195_MUTEX_MOD_DISP_PWM1 28 > > > + > > > #define MT2712_MUTEX_MOD_DISP_PWM2 10 > > > #define MT2712_MUTEX_MOD_DISP_OVL0 11 > > > #define MT2712_MUTEX_MOD_DISP_OVL1 12 > > > @@ -132,9 +165,21 @@ > > > #define MT8167_MUTEX_SOF_DPI1 3 > > > #define MT8183_MUTEX_SOF_DSI0 1 > > > #define MT8183_MUTEX_SOF_DPI0 2 > > > +#define MT8195_MUTEX_SOF_DSI0 1 > > > +#define MT8195_MUTEX_SOF_DSI1 2 > > > +#define MT8195_MUTEX_SOF_DP_INTF0 3 > > > +#define MT8195_MUTEX_SOF_DP_INTF1 4 > > > +#define MT8195_MUTEX_SOF_DPI0 6 /* for > > > HDMI_TX */ > > > +#define MT8195_MUTEX_SOF_DPI1 5 /* for > > > digital video out */ > > > > > > #define MT8183_MUTEX_EOF_DSI0 (MT8183_MUTEX_S > > > OF_DSI0 << 6) > > > #define MT8183_MUTEX_EOF_DPI0 (MT8183_MUTEX_S > > > OF_DPI0 << 6) > > > +#define MT8195_MUTEX_EOF_DSI0 (MT8195_MUTEX_S > > > OF_DSI0 << 7) > > > +#define MT8195_MUTEX_EOF_DSI1 (MT8195_MUTEX_S > > > OF_DSI1 << 7) > > > +#define MT8195_MUTEX_EOF_DP_INTF0 (MT8195_MUTEX_S > > > OF_DP_IN > > > TF0 << 7) > > > +#define MT8195_MUTEX_EOF_DP_INTF1 (MT8195_MUTEX_S > > > OF_DP_IN > > > TF1 << 7) > > > +#define MT8195_MUTEX_EOF_DPI0 (MT8195_MUTEX_S > > > OF_DPI0 << 7) > > > +#define MT8195_MUTEX_EOF_DPI1 (MT8195_MUTEX_S > > > OF_DPI1 << 7) > > > > > > struct mtk_mutex { > > > int id; > > > @@ -149,6 +194,9 @@ enum mtk_mutex_sof_id { > > > MUTEX_SOF_DPI1, > > > MUTEX_SOF_DSI2, > > > MUTEX_SOF_DSI3, > > > + MUTEX_SOF_DP_INTF0, > > > + MUTEX_SOF_DP_INTF1, > > > + DDP_MUTEX_SOF_MAX, > > > }; > > > > > > struct mtk_mutex_data { > > > @@ -270,7 +318,23 @@ static const unsigned int > > > mt8192_mutex_mod[DDP_COMPONENT_ID_MAX] = { > > > [DDP_COMPONENT_RDMA4] = MT8192_MUTEX_MOD_DISP_RDMA4, > > > }; > > > > > > -static const unsigned int mt2712_mutex_sof[MUTEX_SOF_DSI3 + 1] = > > > { > > > +static const unsigned int mt8195_mutex_mod[DDP_COMPONENT_ID_MAX] > > > = > > > { > > > + [DDP_COMPONENT_OVL0] = MT8195_MUTEX_MOD_DISP_OVL0, > > > + [DDP_COMPONENT_WDMA0] = MT8195_MUTEX_MOD_DISP_WDMA0, > > > + [DDP_COMPONENT_RDMA0] = MT8195_MUTEX_MOD_DISP_RDMA0, > > > + [DDP_COMPONENT_COLOR0] = MT8195_MUTEX_MOD_DISP_COLOR0, > > > + [DDP_COMPONENT_CCORR] = MT8195_MUTEX_MOD_DISP_CCORR0, > > > + [DDP_COMPONENT_AAL0] = MT8195_MUTEX_MOD_DISP_AAL0, > > > + [DDP_COMPONENT_GAMMA] = MT8195_MUTEX_MOD_DISP_GAMMA0, > > > + [DDP_COMPONENT_DITHER] = MT8195_MUTEX_MOD_DISP_DITHER0, > > > + [DDP_COMPONENT_MERGE0] = MT8195_MUTEX_MOD_DISP_VPP_MERGE, > > > + [DDP_COMPONENT_DSC0] = MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE0, > > > + [DDP_COMPONENT_DSI0] = MT8195_MUTEX_MOD_DISP_DSI0, > > > + [DDP_COMPONENT_PWM0] = MT8195_MUTEX_MOD_DISP_PWM0, > > > + [DDP_COMPONENT_DP_INTF0] = MT8195_MUTEX_MOD_DISP_DP_INTF0, > > > +}; > > > + > > > +static const unsigned int mt2712_mutex_sof[DDP_MUTEX_SOF_MAX] = > > > { > > > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > > > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0, > > > [MUTEX_SOF_DSI1] = MUTEX_SOF_DSI1, > > > @@ -280,7 +344,7 @@ static const unsigned int > > > mt2712_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > > > [MUTEX_SOF_DSI3] = MUTEX_SOF_DSI3, > > > }; > > > > > > -static const unsigned int mt8167_mutex_sof[MUTEX_SOF_DSI3 + 1] = > > > { > > > +static const unsigned int mt8167_mutex_sof[DDP_MUTEX_SOF_MAX] = > > > { > > > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > > > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0, > > > [MUTEX_SOF_DPI0] = MT8167_MUTEX_SOF_DPI0, > > > @@ -288,7 +352,7 @@ static const unsigned int > > > mt8167_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > > > }; > > > > > > /* Add EOF setting so overlay hardware can receive frame done > > > irq > > > */ > > > -static const unsigned int mt8183_mutex_sof[MUTEX_SOF_DSI3 + 1] = > > > { > > > +static const unsigned int mt8183_mutex_sof[DDP_MUTEX_SOF_MAX] = > > > { > > > [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > > > [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0 | MT8183_MUTEX_EOF_DSI0, > > > [MUTEX_SOF_DPI0] = MT8183_MUTEX_SOF_DPI0 | > > > MT8183_MUTEX_EOF_DPI0, > > > @@ -300,6 +364,26 @@ static const unsigned int > > > mt8186_mutex_sof[MUTEX_SOF_DSI3 + 1] = { > > > [MUTEX_SOF_DPI0] = MT8186_MUTEX_SOF_DPI0 | > > > MT8186_MUTEX_EOF_DPI0, > > > }; > > > > > > +/* > > > + * To support refresh mode(video mode), DISP_REG_MUTEX_SOF > > > should > > > + * select the EOF source and configure the EOF plus timing from > > > the > > > + * module that provides the timing signal. > > > + * So that MUTEX can not only send a STREAM_DONE event to GCE > > > + * but also detect the error at end of frame(EAEOF) when EOF > > > signal > > > + * arrives. > > > + */ > > > +static const unsigned int mt8195_mutex_sof[DDP_MUTEX_SOF_MAX] = > > > { > > > + [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, > > > + [MUTEX_SOF_DSI0] = MT8195_MUTEX_SOF_DSI0 | > > > MT8195_MUTEX_EOF_DSI0, > > > + [MUTEX_SOF_DSI1] = MT8195_MUTEX_SOF_DSI1 | > > > MT8195_MUTEX_EOF_DSI1, > > > + [MUTEX_SOF_DPI0] = MT8195_MUTEX_SOF_DPI0 | > > > MT8195_MUTEX_EOF_DPI0, > > > + [MUTEX_SOF_DPI1] = MT8195_MUTEX_SOF_DPI1 | > > > MT8195_MUTEX_EOF_DPI1, > > > + [MUTEX_SOF_DP_INTF0] = > > > + MT8195_MUTEX_SOF_DP_INTF0 | MT8195_MUTEX_EOF_DP_INTF0, > > > + [MUTEX_SOF_DP_INTF1] = > > > + MT8195_MUTEX_SOF_DP_INTF1 | MT8195_MUTEX_EOF_DP_INTF1, > > > +}; > > > + > > > static const struct mtk_mutex_data mt2701_mutex_driver_data = { > > > .mutex_mod = mt2701_mutex_mod, > > > .mutex_sof = mt2712_mutex_sof, > > > @@ -351,6 +435,13 @@ static const struct mtk_mutex_data > > > mt8192_mutex_driver_data = { > > > .mutex_sof_reg = MT8183_MUTEX0_SOF0, > > > }; > > > > > > +static const struct mtk_mutex_data mt8195_mutex_driver_data = { > > > + .mutex_mod = mt8195_mutex_mod, > > > + .mutex_sof = mt8195_mutex_sof, > > > + .mutex_mod_reg = MT8195_DISP_MUTEX0_MOD0, > > > + .mutex_sof_reg = MT8195_DISP_MUTEX0_SOF, > > > +}; > > > + > > > struct mtk_mutex *mtk_mutex_get(struct device *dev) > > > { > > > struct mtk_mutex_ctx *mtx = dev_get_drvdata(dev); > > > @@ -423,6 +514,9 @@ void mtk_mutex_add_comp(struct mtk_mutex > > > *mutex, > > > case DDP_COMPONENT_DPI1: > > > sof_id = MUTEX_SOF_DPI1; > > > break; > > > + case DDP_COMPONENT_DP_INTF0: > > > + sof_id = MUTEX_SOF_DP_INTF0; > > > + break; > > > default: > > > if (mtx->data->mutex_mod[id] < 32) { > > > offset = DISP_REG_MUTEX_MOD(mtx->data- > > > > mutex_mod_reg, > > > > > > @@ -462,6 +556,7 @@ void mtk_mutex_remove_comp(struct mtk_mutex > > > *mutex, > > > case DDP_COMPONENT_DSI3: > > > case DDP_COMPONENT_DPI0: > > > case DDP_COMPONENT_DPI1: > > > + case DDP_COMPONENT_DP_INTF0: > > > writel_relaxed(MUTEX_SOF_SINGLE_MODE, > > > mtx->regs + > > > DISP_REG_MUTEX_SOF(mtx->data- > > > > mutex_sof_reg, > > > > > > @@ -587,6 +682,8 @@ static const struct of_device_id > > > mutex_driver_dt_match[] = { > > > .data = &mt8186_mutex_driver_data}, > > > { .compatible = "mediatek,mt8192-disp-mutex", > > > .data = &mt8192_mutex_driver_data}, > > > + { .compatible = "mediatek,mt8195-disp-mutex", > > > + .data = &mt8195_mutex_driver_data}, > > > {}, > > > }; > > > MODULE_DEVICE_TABLE(of, mutex_driver_dt_match); > > > >
Hi CK, Thanks for the reviews. On Fri, 2022-03-18 at 15:21 +0800, CK Hu wrote: > Hi, Jason: > > On Mon, 2022-03-07 at 11:28 +0800, jason-jh.lin wrote: > > Add mtk-mutex support for mt8195 vdosys0. > > > > Signed-off-by: jason-jh.lin <jason-jh.lin@mediatek.com> > > Acked-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > drivers/soc/mediatek/mtk-mutex.c | 103 > > ++++++++++++++++++++++++++++++- > > 1 file changed, 100 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-mutex.c > > b/drivers/soc/mediatek/mtk-mutex.c > > index aaf8fc1abb43..1c7ffcdadcea 100644 > > --- a/drivers/soc/mediatek/mtk-mutex.c > > +++ b/drivers/soc/mediatek/mtk-mutex.c > > @@ -17,6 +17,9 @@ > > #define MT8183_MUTEX0_MOD0 0x30 > > #define MT8183_MUTEX0_SOF0 0x2c > > > > +#define MT8195_DISP_MUTEX0_MOD0 0x30 > > +#define MT8195_DISP_MUTEX0_SOF 0x2c > > + > > #define DISP_REG_MUTEX_EN(n) (0x20 + 0x20 * > > (n)) > > #define DISP_REG_MUTEX(n) (0x24 + 0x20 * (n)) > > #define DISP_REG_MUTEX_RST(n) (0x28 + 0x20 * > > (n)) > > @@ -96,6 +99,36 @@ > > #define MT8173_MUTEX_MOD_DISP_PWM1 24 > > #define MT8173_MUTEX_MOD_DISP_OD 25 > > [snip] > > > +#define MT8195_MUTEX_MOD_DISP_VPP_MERGE 20 > > > +#define MT8195_MUTEX_MOD_DISP_DP_INTF0 21 > > > +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY0 22 > > > > > > Useless, remove. > > > > > > > +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY1 23 > > > > > > Ditto. > > > > > > Regards, > > > CK > > > > Although these definitions are not used, they represent the > > functionality provided by this register. > > > > I think we can show that we have these capabilities by defining > them. > > > > Can we keep these definitions? > > OK, but add some information that we could know how to use it. What's > these DL_RELAY and when should we add these to mutex? > > Regards, > CK DL_RELAY is used for the cross mmsys mux settings. We won't use these setting currently, so I think I just remove these useless define. Thanks. Regards, Jason-JH.Lin [snip]
diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c index aaf8fc1abb43..1c7ffcdadcea 100644 --- a/drivers/soc/mediatek/mtk-mutex.c +++ b/drivers/soc/mediatek/mtk-mutex.c @@ -17,6 +17,9 @@ #define MT8183_MUTEX0_MOD0 0x30 #define MT8183_MUTEX0_SOF0 0x2c +#define MT8195_DISP_MUTEX0_MOD0 0x30 +#define MT8195_DISP_MUTEX0_SOF 0x2c + #define DISP_REG_MUTEX_EN(n) (0x20 + 0x20 * (n)) #define DISP_REG_MUTEX(n) (0x24 + 0x20 * (n)) #define DISP_REG_MUTEX_RST(n) (0x28 + 0x20 * (n)) @@ -96,6 +99,36 @@ #define MT8173_MUTEX_MOD_DISP_PWM1 24 #define MT8173_MUTEX_MOD_DISP_OD 25 +#define MT8195_MUTEX_MOD_DISP_OVL0 0 +#define MT8195_MUTEX_MOD_DISP_WDMA0 1 +#define MT8195_MUTEX_MOD_DISP_RDMA0 2 +#define MT8195_MUTEX_MOD_DISP_COLOR0 3 +#define MT8195_MUTEX_MOD_DISP_CCORR0 4 +#define MT8195_MUTEX_MOD_DISP_AAL0 5 +#define MT8195_MUTEX_MOD_DISP_GAMMA0 6 +#define MT8195_MUTEX_MOD_DISP_DITHER0 7 +#define MT8195_MUTEX_MOD_DISP_DSI0 8 +#define MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE0 9 +#define MT8195_MUTEX_MOD_DISP_OVL1 10 +#define MT8195_MUTEX_MOD_DISP_WDMA1 11 +#define MT8195_MUTEX_MOD_DISP_RDMA1 12 +#define MT8195_MUTEX_MOD_DISP_COLOR1 13 +#define MT8195_MUTEX_MOD_DISP_CCORR1 14 +#define MT8195_MUTEX_MOD_DISP_AAL1 15 +#define MT8195_MUTEX_MOD_DISP_GAMMA1 16 +#define MT8195_MUTEX_MOD_DISP_DITHER1 17 +#define MT8195_MUTEX_MOD_DISP_DSI1 18 +#define MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE1 19 +#define MT8195_MUTEX_MOD_DISP_VPP_MERGE 20 +#define MT8195_MUTEX_MOD_DISP_DP_INTF0 21 +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY0 22 +#define MT8195_MUTEX_MOD_DISP_VPP1_DL_RELAY1 23 +#define MT8195_MUTEX_MOD_DISP_VDO1_DL_RELAY2 24 +#define MT8195_MUTEX_MOD_DISP_VDO0_DL_RELAY3 25 +#define MT8195_MUTEX_MOD_DISP_VDO0_DL_RELAY4 26 +#define MT8195_MUTEX_MOD_DISP_PWM0 27 +#define MT8195_MUTEX_MOD_DISP_PWM1 28 + #define MT2712_MUTEX_MOD_DISP_PWM2 10 #define MT2712_MUTEX_MOD_DISP_OVL0 11 #define MT2712_MUTEX_MOD_DISP_OVL1 12 @@ -132,9 +165,21 @@ #define MT8167_MUTEX_SOF_DPI1 3 #define MT8183_MUTEX_SOF_DSI0 1 #define MT8183_MUTEX_SOF_DPI0 2 +#define MT8195_MUTEX_SOF_DSI0 1 +#define MT8195_MUTEX_SOF_DSI1 2 +#define MT8195_MUTEX_SOF_DP_INTF0 3 +#define MT8195_MUTEX_SOF_DP_INTF1 4 +#define MT8195_MUTEX_SOF_DPI0 6 /* for HDMI_TX */ +#define MT8195_MUTEX_SOF_DPI1 5 /* for digital video out */ #define MT8183_MUTEX_EOF_DSI0 (MT8183_MUTEX_SOF_DSI0 << 6) #define MT8183_MUTEX_EOF_DPI0 (MT8183_MUTEX_SOF_DPI0 << 6) +#define MT8195_MUTEX_EOF_DSI0 (MT8195_MUTEX_SOF_DSI0 << 7) +#define MT8195_MUTEX_EOF_DSI1 (MT8195_MUTEX_SOF_DSI1 << 7) +#define MT8195_MUTEX_EOF_DP_INTF0 (MT8195_MUTEX_SOF_DP_INTF0 << 7) +#define MT8195_MUTEX_EOF_DP_INTF1 (MT8195_MUTEX_SOF_DP_INTF1 << 7) +#define MT8195_MUTEX_EOF_DPI0 (MT8195_MUTEX_SOF_DPI0 << 7) +#define MT8195_MUTEX_EOF_DPI1 (MT8195_MUTEX_SOF_DPI1 << 7) struct mtk_mutex { int id; @@ -149,6 +194,9 @@ enum mtk_mutex_sof_id { MUTEX_SOF_DPI1, MUTEX_SOF_DSI2, MUTEX_SOF_DSI3, + MUTEX_SOF_DP_INTF0, + MUTEX_SOF_DP_INTF1, + DDP_MUTEX_SOF_MAX, }; struct mtk_mutex_data { @@ -270,7 +318,23 @@ static const unsigned int mt8192_mutex_mod[DDP_COMPONENT_ID_MAX] = { [DDP_COMPONENT_RDMA4] = MT8192_MUTEX_MOD_DISP_RDMA4, }; -static const unsigned int mt2712_mutex_sof[MUTEX_SOF_DSI3 + 1] = { +static const unsigned int mt8195_mutex_mod[DDP_COMPONENT_ID_MAX] = { + [DDP_COMPONENT_OVL0] = MT8195_MUTEX_MOD_DISP_OVL0, + [DDP_COMPONENT_WDMA0] = MT8195_MUTEX_MOD_DISP_WDMA0, + [DDP_COMPONENT_RDMA0] = MT8195_MUTEX_MOD_DISP_RDMA0, + [DDP_COMPONENT_COLOR0] = MT8195_MUTEX_MOD_DISP_COLOR0, + [DDP_COMPONENT_CCORR] = MT8195_MUTEX_MOD_DISP_CCORR0, + [DDP_COMPONENT_AAL0] = MT8195_MUTEX_MOD_DISP_AAL0, + [DDP_COMPONENT_GAMMA] = MT8195_MUTEX_MOD_DISP_GAMMA0, + [DDP_COMPONENT_DITHER] = MT8195_MUTEX_MOD_DISP_DITHER0, + [DDP_COMPONENT_MERGE0] = MT8195_MUTEX_MOD_DISP_VPP_MERGE, + [DDP_COMPONENT_DSC0] = MT8195_MUTEX_MOD_DISP_DSC_WRAP0_CORE0, + [DDP_COMPONENT_DSI0] = MT8195_MUTEX_MOD_DISP_DSI0, + [DDP_COMPONENT_PWM0] = MT8195_MUTEX_MOD_DISP_PWM0, + [DDP_COMPONENT_DP_INTF0] = MT8195_MUTEX_MOD_DISP_DP_INTF0, +}; + +static const unsigned int mt2712_mutex_sof[DDP_MUTEX_SOF_MAX] = { [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0, [MUTEX_SOF_DSI1] = MUTEX_SOF_DSI1, @@ -280,7 +344,7 @@ static const unsigned int mt2712_mutex_sof[MUTEX_SOF_DSI3 + 1] = { [MUTEX_SOF_DSI3] = MUTEX_SOF_DSI3, }; -static const unsigned int mt8167_mutex_sof[MUTEX_SOF_DSI3 + 1] = { +static const unsigned int mt8167_mutex_sof[DDP_MUTEX_SOF_MAX] = { [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0, [MUTEX_SOF_DPI0] = MT8167_MUTEX_SOF_DPI0, @@ -288,7 +352,7 @@ static const unsigned int mt8167_mutex_sof[MUTEX_SOF_DSI3 + 1] = { }; /* Add EOF setting so overlay hardware can receive frame done irq */ -static const unsigned int mt8183_mutex_sof[MUTEX_SOF_DSI3 + 1] = { +static const unsigned int mt8183_mutex_sof[DDP_MUTEX_SOF_MAX] = { [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, [MUTEX_SOF_DSI0] = MUTEX_SOF_DSI0 | MT8183_MUTEX_EOF_DSI0, [MUTEX_SOF_DPI0] = MT8183_MUTEX_SOF_DPI0 | MT8183_MUTEX_EOF_DPI0, @@ -300,6 +364,26 @@ static const unsigned int mt8186_mutex_sof[MUTEX_SOF_DSI3 + 1] = { [MUTEX_SOF_DPI0] = MT8186_MUTEX_SOF_DPI0 | MT8186_MUTEX_EOF_DPI0, }; +/* + * To support refresh mode(video mode), DISP_REG_MUTEX_SOF should + * select the EOF source and configure the EOF plus timing from the + * module that provides the timing signal. + * So that MUTEX can not only send a STREAM_DONE event to GCE + * but also detect the error at end of frame(EAEOF) when EOF signal + * arrives. + */ +static const unsigned int mt8195_mutex_sof[DDP_MUTEX_SOF_MAX] = { + [MUTEX_SOF_SINGLE_MODE] = MUTEX_SOF_SINGLE_MODE, + [MUTEX_SOF_DSI0] = MT8195_MUTEX_SOF_DSI0 | MT8195_MUTEX_EOF_DSI0, + [MUTEX_SOF_DSI1] = MT8195_MUTEX_SOF_DSI1 | MT8195_MUTEX_EOF_DSI1, + [MUTEX_SOF_DPI0] = MT8195_MUTEX_SOF_DPI0 | MT8195_MUTEX_EOF_DPI0, + [MUTEX_SOF_DPI1] = MT8195_MUTEX_SOF_DPI1 | MT8195_MUTEX_EOF_DPI1, + [MUTEX_SOF_DP_INTF0] = + MT8195_MUTEX_SOF_DP_INTF0 | MT8195_MUTEX_EOF_DP_INTF0, + [MUTEX_SOF_DP_INTF1] = + MT8195_MUTEX_SOF_DP_INTF1 | MT8195_MUTEX_EOF_DP_INTF1, +}; + static const struct mtk_mutex_data mt2701_mutex_driver_data = { .mutex_mod = mt2701_mutex_mod, .mutex_sof = mt2712_mutex_sof, @@ -351,6 +435,13 @@ static const struct mtk_mutex_data mt8192_mutex_driver_data = { .mutex_sof_reg = MT8183_MUTEX0_SOF0, }; +static const struct mtk_mutex_data mt8195_mutex_driver_data = { + .mutex_mod = mt8195_mutex_mod, + .mutex_sof = mt8195_mutex_sof, + .mutex_mod_reg = MT8195_DISP_MUTEX0_MOD0, + .mutex_sof_reg = MT8195_DISP_MUTEX0_SOF, +}; + struct mtk_mutex *mtk_mutex_get(struct device *dev) { struct mtk_mutex_ctx *mtx = dev_get_drvdata(dev); @@ -423,6 +514,9 @@ void mtk_mutex_add_comp(struct mtk_mutex *mutex, case DDP_COMPONENT_DPI1: sof_id = MUTEX_SOF_DPI1; break; + case DDP_COMPONENT_DP_INTF0: + sof_id = MUTEX_SOF_DP_INTF0; + break; default: if (mtx->data->mutex_mod[id] < 32) { offset = DISP_REG_MUTEX_MOD(mtx->data->mutex_mod_reg, @@ -462,6 +556,7 @@ void mtk_mutex_remove_comp(struct mtk_mutex *mutex, case DDP_COMPONENT_DSI3: case DDP_COMPONENT_DPI0: case DDP_COMPONENT_DPI1: + case DDP_COMPONENT_DP_INTF0: writel_relaxed(MUTEX_SOF_SINGLE_MODE, mtx->regs + DISP_REG_MUTEX_SOF(mtx->data->mutex_sof_reg, @@ -587,6 +682,8 @@ static const struct of_device_id mutex_driver_dt_match[] = { .data = &mt8186_mutex_driver_data}, { .compatible = "mediatek,mt8192-disp-mutex", .data = &mt8192_mutex_driver_data}, + { .compatible = "mediatek,mt8195-disp-mutex", + .data = &mt8195_mutex_driver_data}, {}, }; MODULE_DEVICE_TABLE(of, mutex_driver_dt_match);