diff mbox series

[resend] turbostat: fix PC6 displaying on some systems

Message ID 20220308114101.3872868-1-dedekind1@gmail.com (mailing list archive)
State Mainlined, archived
Headers show
Series [resend] turbostat: fix PC6 displaying on some systems | expand

Commit Message

Artem Bityutskiy March 8, 2022, 11:41 a.m. UTC 
From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

'MSR_PKG_CST_CONFIG_CONTROL' encodes the deepest allowed package C-state limit,
and turbostat decodes it.

Before this patch: turbostat does not recognize value "3" on Ice Lake Xeon
(ICX) and Sapphire Rapids Xeon (SPR), treats it as "unknown", and does not
display any package C-states in the results table.

After this patch: turbostat recognizes value 3 on ICX and SPR, treats it as
"PC6", and correctly displays package C-states in the results table.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 tools/power/x86/turbostat/turbostat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Note 1: I apologize for submitting this patch several times. I clearly forgot
how to use 'git send-email' and missed the '--dry-run' option. Sorry for this.

Note 2: this patch is a rebased version of the same patch I sent earlier:
https://patchwork.kernel.org/project/linux-pm/patch/20211004105224.3145916-1-dedekind1@gmail.com/

Comments

Rafael J. Wysocki March 8, 2022, 1:32 p.m. UTC | #1 
On Tue, Mar 8, 2022 at 12:41 PM Artem Bityutskiy <dedekind1@gmail.com> wrote:
>
> From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
>
> 'MSR_PKG_CST_CONFIG_CONTROL' encodes the deepest allowed package C-state limit,
> and turbostat decodes it.
>
> Before this patch: turbostat does not recognize value "3" on Ice Lake Xeon
> (ICX) and Sapphire Rapids Xeon (SPR), treats it as "unknown", and does not
> display any package C-states in the results table.
>
> After this patch: turbostat recognizes value 3 on ICX and SPR, treats it as
> "PC6", and correctly displays package C-states in the results table.
>
> Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> ---
>  tools/power/x86/turbostat/turbostat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Note 1: I apologize for submitting this patch several times. I clearly forgot
> how to use 'git send-email' and missed the '--dry-run' option. Sorry for this.
>
> Note 2: this patch is a rebased version of the same patch I sent earlier:
> https://patchwork.kernel.org/project/linux-pm/patch/20211004105224.3145916-1-dedekind1@gmail.com/
>
> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> index 47d3ba895d6d..bc5ae0872fed 100644
> --- a/tools/power/x86/turbostat/turbostat.c
> +++ b/tools/power/x86/turbostat/turbostat.c
> @@ -2323,7 +2323,7 @@ int skx_pkg_cstate_limits[16] =
>  };
>
>  int icx_pkg_cstate_limits[16] =
> -    { PCL__0, PCL__2, PCL__6, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLUNL, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV,
> +    { PCL__0, PCL__2, PCL__6, PCL__6, PCLRSV, PCLRSV, PCLRSV, PCLUNL, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV,
>         PCLRSV, PCLRSV
>  };
>
> --

turbostat material has been handled by Len so far, but I've queued up
this patch for 5.18.

Thanks!
diff mbox series

Patch

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 47d3ba895d6d..bc5ae0872fed 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -2323,7 +2323,7 @@  int skx_pkg_cstate_limits[16] =
 };
 
 int icx_pkg_cstate_limits[16] =
-    { PCL__0, PCL__2, PCL__6, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLUNL, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV,
+    { PCL__0, PCL__2, PCL__6, PCL__6, PCLRSV, PCLRSV, PCLRSV, PCLUNL, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV, PCLRSV,
 	PCLRSV, PCLRSV
 };