diff mbox series

[net-next,v2] net/fungible: CONFIG_FUN_CORE needs SBITMAP

Message ID 20220308081234.3517-1-dmichail@fungible.com (mailing list archive)
State Accepted
Commit 40bb09c87f0b00c991f6c2fb367f0a2711760332
Delegated to: Netdev Maintainers
Headers show
Series [net-next,v2] net/fungible: CONFIG_FUN_CORE needs SBITMAP | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers fail 1 blamed authors not CCed: dmichail@fungible.com; 1 maintainers not CCed: dmichail@fungible.com
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch warning WARNING: From:/Signed-off-by: email address mismatch: 'From: Dimitris Michailidis <d.michailidis@fungible.com>' != 'Signed-off-by: Dimitris Michailidis <dmichail@fungible.com>'
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Dimitris Michailidis March 8, 2022, 8:12 a.m. UTC
fun_core.ko uses sbitmaps and needs to select SBITMAP.
Fixes below errors:

ERROR: modpost: "__sbitmap_queue_get"
[drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
ERROR: modpost: "sbitmap_finish_wait"
[drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
ERROR: modpost: "sbitmap_queue_clear"
[drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
ERROR: modpost: "sbitmap_prepare_to_wait"
[drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
ERROR: modpost: "sbitmap_queue_init_node"
[drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
ERROR: modpost: "sbitmap_queue_wake_all"
[drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!

v2: correct "Fixes" SHA

Fixes: 749efb1e6d73 ("net/fungible: Kconfig, Makefiles, and MAINTAINERS")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Dimitris Michailidis <dmichail@fungible.com>
---
 drivers/net/ethernet/fungible/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Randy Dunlap March 9, 2022, 2:57 a.m. UTC | #1
On 3/8/22 00:12, Dimitris Michailidis wrote:
> fun_core.ko uses sbitmaps and needs to select SBITMAP.
> Fixes below errors:
> 
> ERROR: modpost: "__sbitmap_queue_get"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_finish_wait"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_queue_clear"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_prepare_to_wait"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_queue_init_node"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_queue_wake_all"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> 
> v2: correct "Fixes" SHA
> 
> Fixes: 749efb1e6d73 ("net/fungible: Kconfig, Makefiles, and MAINTAINERS")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Dimitris Michailidis <dmichail@fungible.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>


> ---
>  drivers/net/ethernet/fungible/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/fungible/Kconfig b/drivers/net/ethernet/fungible/Kconfig
> index 2ff5138d0448..1ecedecc0f6c 100644
> --- a/drivers/net/ethernet/fungible/Kconfig
> +++ b/drivers/net/ethernet/fungible/Kconfig
> @@ -18,6 +18,7 @@ if NET_VENDOR_FUNGIBLE
>  
>  config FUN_CORE
>  	tristate
> +	select SBITMAP
>  	help
>  	  A service module offering basic common services to Fungible
>  	  device drivers.
patchwork-bot+netdevbpf@kernel.org March 9, 2022, 11:30 a.m. UTC | #2
Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue,  8 Mar 2022 00:12:34 -0800 you wrote:
> fun_core.ko uses sbitmaps and needs to select SBITMAP.
> Fixes below errors:
> 
> ERROR: modpost: "__sbitmap_queue_get"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_finish_wait"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_queue_clear"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_prepare_to_wait"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_queue_init_node"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> ERROR: modpost: "sbitmap_queue_wake_all"
> [drivers/net/ethernet/fungible/funcore/funcore.ko] undefined!
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net/fungible: CONFIG_FUN_CORE needs SBITMAP
    https://git.kernel.org/netdev/net-next/c/40bb09c87f0b

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/fungible/Kconfig b/drivers/net/ethernet/fungible/Kconfig
index 2ff5138d0448..1ecedecc0f6c 100644
--- a/drivers/net/ethernet/fungible/Kconfig
+++ b/drivers/net/ethernet/fungible/Kconfig
@@ -18,6 +18,7 @@  if NET_VENDOR_FUNGIBLE
 
 config FUN_CORE
 	tristate
+	select SBITMAP
 	help
 	  A service module offering basic common services to Fungible
 	  device drivers.