| Message ID | 20220307181704.149076-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/rockchip: remove redundant assignment to pointer connector | expand |
On Mon, Mar 7, 2022 at 10:17 AM Colin Ian King <colin.i.king@gmail.com> wrote: > > The pointer connector is being assigned a value that is never read, > it is being re-assigned in the following statement. The assignment > is redundant and can be removed. > > Cleans up clang scan build warning: > drivers/gpu/drm/rockchip/rockchip_rgb.c:153:2: warning: Value stored > to 'connector' is never read [deadcode.DeadStores] + Author & reviewer of: Fixes: 2e87bf389e13 ("drm/rockchip: add DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to drm_bridge_attach") > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c > index 2494b079489d..92a727931a49 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c > +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c > @@ -150,7 +150,6 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev, > if (ret) > goto err_free_encoder; > > - connector = &rgb->connector; > connector = drm_bridge_connector_init(rgb->drm_dev, encoder); > if (IS_ERR(connector)) { > DRM_DEV_ERROR(drm_dev->dev, > -- > 2.35.1 > >
Hi, looks like I wasn't in the original recipient list, so only got Nick's answer. Am Mittwoch, 9. März 2022, 00:10:31 CET schrieb Nick Desaulniers: > On Mon, Mar 7, 2022 at 10:17 AM Colin Ian King <colin.i.king@gmail.com> wrote: > > > > The pointer connector is being assigned a value that is never read, > > it is being re-assigned in the following statement. The assignment > > is redundant and can be removed. > > > > Cleans up clang scan build warning: > > drivers/gpu/drm/rockchip/rockchip_rgb.c:153:2: warning: Value stored > > to 'connector' is never read [deadcode.DeadStores] > > + Author & reviewer of: > Fixes: 2e87bf389e13 ("drm/rockchip: add DRM_BRIDGE_ATTACH_NO_CONNECTOR > flag to drm_bridge_attach") > > > > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > --- > > drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c > > index 2494b079489d..92a727931a49 100644 > > --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c > > +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c > > @@ -150,7 +150,6 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev, > > if (ret) > > goto err_free_encoder; > > > > - connector = &rgb->connector; > > connector = drm_bridge_connector_init(rgb->drm_dev, encoder); I don't think this will work as expected. Yes, the whole thing looks a bit broken right now, but the connector field in the rockchip_rgb struct still exists and rockchip_rgb_fini also still uses it when calling drm_connector_cleanup. Same issue seems to exist in in rockchip_lvds.c with drm_connector_cleanup it seems. I guess drm_bridge_connector_destroy() is responsible for the cleanup so the drm_connector_cleanup call both in rockchip_rgb and rockchip_lvds as well as the local connector elements can go away as well? Heiko > > if (IS_ERR(connector)) { > > DRM_DEV_ERROR(drm_dev->dev, > > -- > > 2.35.1 > > > > > > >
diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c index 2494b079489d..92a727931a49 100644 --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c @@ -150,7 +150,6 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev, if (ret) goto err_free_encoder; - connector = &rgb->connector; connector = drm_bridge_connector_init(rgb->drm_dev, encoder); if (IS_ERR(connector)) { DRM_DEV_ERROR(drm_dev->dev,
The pointer connector is being assigned a value that is never read, it is being re-assigned in the following statement. The assignment is redundant and can be removed. Cleans up clang scan build warning: drivers/gpu/drm/rockchip/rockchip_rgb.c:153:2: warning: Value stored to 'connector' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 - 1 file changed, 1 deletion(-)