| Message ID | 20220308072125.38381-2-singh.kuldeep87k@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Mark Brown |
| Headers | show |
| Series | [v2,1/2] dt-bindings: spi: Update clocks property for ARM pl022 | expand |
On Tue, Mar 08, 2022 at 12:51:25PM +0530, Kuldeep Singh wrote: > Pl022 clock-names can be one of following: > ['apb_pclk'] or ['sspclk', 'apb_pclk'] > > The current schema refers to second case only. Make necessary changes to > incorporate both the cases and resolve below dtc warning: > clock-names: 'apb_pclk' is not one of ['sspclk'] > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > --- > v2: > - Reword commit message > - Drop SSPCLK > > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > index 7d36e15db5b3..6cfab948624e 100644 > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > @@ -38,11 +38,13 @@ properties: > maxItems: 2 > > clock-names: > - items: > + oneOf: > - enum: > - - SSPCLK > - - sspclk > - - const: apb_pclk > + - apb_pclk Are you going to make the driver work with no SPI clock? Because this change is saying that it is valid to have the APB bus clock and no SPI clock. Rob > + - items: > + - enum: > + - sspclk > + - const: apb_pclk > > pl022,autosuspend-delay: > description: delay in ms following transfer completion before the > -- > 2.25.1 > >
On Thu, Mar 10, 2022 at 04:08:42PM -0600, Rob Herring wrote: > On Tue, Mar 08, 2022 at 12:51:25PM +0530, Kuldeep Singh wrote: > > Pl022 clock-names can be one of following: > > ['apb_pclk'] or ['sspclk', 'apb_pclk'] > > > > The current schema refers to second case only. Make necessary changes to > > incorporate both the cases and resolve below dtc warning: > > clock-names: 'apb_pclk' is not one of ['sspclk'] > > > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > > --- > > v2: > > - Reword commit message > > - Drop SSPCLK > > > > Documentation/devicetree/bindings/spi/spi-pl022.yaml | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > > index 7d36e15db5b3..6cfab948624e 100644 > > --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml > > +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml > > @@ -38,11 +38,13 @@ properties: > > maxItems: 2 > > > > clock-names: > > - items: > > + oneOf: > > - enum: > > - - SSPCLK > > - - sspclk > > - - const: apb_pclk > > + - apb_pclk > > Are you going to make the driver work with no SPI clock? Because this > change is saying that it is valid to have the APB bus clock and no SPI > clock. Kindly take a loot at newer version to this series as this one is deprecated. https://lore.kernel.org/linux-spi/20220309171847.5345-1-singh.kuldeep87k@gmail.com/ - Kuldeep > > Rob > > > + - items: > > + - enum: > > + - sspclk > > + - const: apb_pclk > > > > pl022,autosuspend-delay: > > description: delay in ms following transfer completion before the > > -- > > 2.25.1 > > > >
diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml index 7d36e15db5b3..6cfab948624e 100644 --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml @@ -38,11 +38,13 @@ properties: maxItems: 2 clock-names: - items: + oneOf: - enum: - - SSPCLK - - sspclk - - const: apb_pclk + - apb_pclk + - items: + - enum: + - sspclk + - const: apb_pclk pl022,autosuspend-delay: description: delay in ms following transfer completion before the
Pl022 clock-names can be one of following: ['apb_pclk'] or ['sspclk', 'apb_pclk'] The current schema refers to second case only. Make necessary changes to incorporate both the cases and resolve below dtc warning: clock-names: 'apb_pclk' is not one of ['sspclk'] Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> --- v2: - Reword commit message - Drop SSPCLK Documentation/devicetree/bindings/spi/spi-pl022.yaml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)