| Message ID | 20220310152227.2122960-1-kieran.bingham+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/bridge: ti-sn65dsi86: Support non-eDP DisplayPort connectors | expand |
Hi, On Thu, Mar 10, 2022 at 7:22 AM Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> wrote: > > Implement support for non eDP connectors on the TI-SN65DSI86 bridge, and > provide IRQ based hotplug detect to identify when the connector is > present. > > no-hpd is extended to be the default behaviour for non DisplayPort > connectors. > > This series is based upon Sam Ravnborgs and Rob Clarks series [0] to > support DRM_BRIDGE_STATE_OPS and NO_CONNECTOR support on the SN65DSI86, > however some extra modifications have been made on the top of Sam's > series to fix compile breakage and the NO_CONNECTOR support. This confused me a little bit. As far as I know Rob's series is abandoned and he's not working on it. I assume that Sam will eventually re-post his series, but it had unsolved problems and the bpp solution he had totally didn't work because nobody was setting "output_bus_cfg.format" [1]. Did you solve that? ...or you're just going to let your patches sit there and hope that Sam will solve the problem and re-post his series? I'll admit I didn't go through your git tree to figure out if you solved it some way. If you did, I would have assumed you'd have re-posted his patches in your series w/ the solution... [1] https://lore.kernel.org/r/CAD=FV=WW6HWLOD9AzTpjwva9UHY=AR+LABEWqJQznz6Nbb4sOw@mail.gmail.com/ -Doug
Hi Doug, Sam, Quoting Doug Anderson (2022-03-10 23:21:38) > Hi, > > On Thu, Mar 10, 2022 at 7:22 AM Kieran Bingham > <kieran.bingham+renesas@ideasonboard.com> wrote: > > > > Implement support for non eDP connectors on the TI-SN65DSI86 bridge, and > > provide IRQ based hotplug detect to identify when the connector is > > present. > > > > no-hpd is extended to be the default behaviour for non DisplayPort > > connectors. > > > > This series is based upon Sam Ravnborgs and Rob Clarks series [0] to > > support DRM_BRIDGE_STATE_OPS and NO_CONNECTOR support on the SN65DSI86, > > however some extra modifications have been made on the top of Sam's > > series to fix compile breakage and the NO_CONNECTOR support. > > This confused me a little bit. As far as I know Rob's series is > abandoned and he's not working on it. I assume that Sam will > eventually re-post his series, but it had unsolved problems and the > bpp solution he had totally didn't work because nobody was setting > "output_bus_cfg.format" [1]. Did you solve that? ...or you're just > going to let your patches sit there and hope that Sam will solve the > problem and re-post his series? I applied Sam's series, and fixed it to work for me. It looked like Rob's patch had been rolled into Sam's series, and I didn't take ownership of Sam's series, as I assume he'll continue on it, but I haven't asked or heard either way yet. Sam's series is only from February, so I would not presume to consider that it is abandoned yet. The changes I made have either already been highlighted by the build bots on Sam's series, or I have replied to his series with the fixes I made. > I'll admit I didn't go through your git tree to figure out if you > solved it some way. If you did, I would have assumed you'd have > re-posted his patches in your series w/ the solution... My changes to his series are on my branch as separate squash: commits so they're easy to see or take if Sam wants to collect the fixes, but there's nothing complex there, that isn't easily solved locally. If Sam's series is abandoned, then I guess my 'Implement SN65DSI86 IRQ HPD' patch will now have a 11:1 ratio of patches that I have to take custodianship of vs author myself ;-) (And even most of the work I have done has been squashed into Laurent's patches already) Sam, What is your plan on your series at [1], are you still actively planning to work on it? -- Kieran > [1] https://lore.kernel.org/r/CAD=FV=WW6HWLOD9AzTpjwva9UHY=AR+LABEWqJQznz6Nbb4sOw@mail.gmail.com/ > > -Doug
Implement support for non eDP connectors on the TI-SN65DSI86 bridge, and provide IRQ based hotplug detect to identify when the connector is present. no-hpd is extended to be the default behaviour for non DisplayPort connectors. This series is based upon Sam Ravnborgs and Rob Clarks series [0] to support DRM_BRIDGE_STATE_OPS and NO_CONNECTOR support on the SN65DSI86, however some extra modifications have been made on the top of Sam's series to fix compile breakage and the NO_CONNECTOR support. A full branch with these changes is available at [1] [0] https://lore.kernel.org/all/20220206154405.1243333-1-sam@ravnborg.org/ [1] git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git branch: kbingham/drm-misc/next/sn65dsi86/hpd Kieran Bingham (1): drm/bridge: ti-sn65dsi86: Support hotplug detection Laurent Pinchart (2): drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode drm/bridge: ti-sn65dsi86: Implement bridge connector operations drivers/gpu/drm/bridge/ti-sn65dsi86.c | 180 +++++++++++++++++++++++--- 1 file changed, 165 insertions(+), 15 deletions(-)