| Message ID | 20220309102118.8131-2-peng.fan@oss.nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | remoteproc: imx_rproc: support i.MX8QM/QXP | expand |
On 09/03/2022 11:21, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Add i.MX8QXP compatible > > Add a new property rsrc-id(resource id) for SoC which supports > SCFW(System Controller Firmware). SCFW manages resources using resource > id, here the rsrc-id is used to check whether remote process is under > control of Linux or not. > > To i.MX8QM/QXP, when M4 is in the same hardware partition with Cortex-A > cores, need power up M4 through SCFW, then M4 could start. So introduce > power-domains property. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > .../bindings/remoteproc/fsl,imx-rproc.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > index fc16d903353e..f25c203dd2f9 100644 > --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > @@ -19,6 +19,7 @@ properties: > - fsl,imx8mm-cm4 > - fsl,imx8mn-cm7 > - fsl,imx8mp-cm7 > + - fsl,imx8qxp-cm4 > - fsl,imx8ulp-cm33 > - fsl,imx7d-cm4 > - fsl,imx7ulp-cm4 > @@ -27,6 +28,11 @@ properties: > clocks: > maxItems: 1 > > + entry: > + $ref: /schemas/types.yaml#/definitions/uint32 Does not look like a generic property, so please add vendor prefix. Suffix also would look good, so: "fsl,entry-address" > + description: | > + Specify cpu entry address for SCU enabled processor. s/cpu/CPU/ > + > syscon: > $ref: /schemas/types.yaml#/definitions/phandle > description: > @@ -59,6 +65,15 @@ properties: > Indicate whether need to load the default firmware and start the remote > processor automatically. > > + power-domains: > + maxItems: 8 > + > + rsrc-id: > + description: > + This property is to specify the resource id of the remote processor in SoC > + which supports SCFW Needs type, vendor prefix. > + maxItems: 1 > + > required: > - compatible > Best regards, Krzysztof
> Subject: Re: [PATCH V2 1/6] dt-bindings: remoteproc: imx_rproc: support > i.MX8QXP > > On 09/03/2022 11:21, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Add i.MX8QXP compatible > > > > Add a new property rsrc-id(resource id) for SoC which supports > > SCFW(System Controller Firmware). SCFW manages resources using > > resource id, here the rsrc-id is used to check whether remote process > > is under control of Linux or not. > > > > To i.MX8QM/QXP, when M4 is in the same hardware partition with > > Cortex-A cores, need power up M4 through SCFW, then M4 could start. So > > introduce power-domains property. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > .../bindings/remoteproc/fsl,imx-rproc.yaml | 15 > +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > > b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > > index fc16d903353e..f25c203dd2f9 100644 > > --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > > +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml > > @@ -19,6 +19,7 @@ properties: > > - fsl,imx8mm-cm4 > > - fsl,imx8mn-cm7 > > - fsl,imx8mp-cm7 > > + - fsl,imx8qxp-cm4 > > - fsl,imx8ulp-cm33 > > - fsl,imx7d-cm4 > > - fsl,imx7ulp-cm4 > > @@ -27,6 +28,11 @@ properties: > > clocks: > > maxItems: 1 > > > > + entry: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > Does not look like a generic property, so please add vendor prefix. > Suffix also would look good, so: > "fsl,entry-address" Fix in next version > > > + description: | > > + Specify cpu entry address for SCU enabled processor. > > s/cpu/CPU/ Fix in next version. > > > + > > syscon: > > $ref: /schemas/types.yaml#/definitions/phandle > > description: > > @@ -59,6 +65,15 @@ properties: > > Indicate whether need to load the default firmware and start the > remote > > processor automatically. > > > > + power-domains: > > + maxItems: 8 > > + > > + rsrc-id: > > + description: > > + This property is to specify the resource id of the remote processor > in SoC > > + which supports SCFW > > Needs type, vendor prefix. Fix in next version. Thanks, Peng > > > + maxItems: 1 > > + > > required: > > - compatible > > > > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml index fc16d903353e..f25c203dd2f9 100644 --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml @@ -19,6 +19,7 @@ properties: - fsl,imx8mm-cm4 - fsl,imx8mn-cm7 - fsl,imx8mp-cm7 + - fsl,imx8qxp-cm4 - fsl,imx8ulp-cm33 - fsl,imx7d-cm4 - fsl,imx7ulp-cm4 @@ -27,6 +28,11 @@ properties: clocks: maxItems: 1 + entry: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Specify cpu entry address for SCU enabled processor. + syscon: $ref: /schemas/types.yaml#/definitions/phandle description: @@ -59,6 +65,15 @@ properties: Indicate whether need to load the default firmware and start the remote processor automatically. + power-domains: + maxItems: 8 + + rsrc-id: + description: + This property is to specify the resource id of the remote processor in SoC + which supports SCFW + maxItems: 1 + required: - compatible