[V3,00/15] rtla: Improved tracing support

Message

Daniel Bristot de Oliveira March 2, 2022, 7:01 p.m. UTC

This set introduces some tracing facilities to rtla tools:

- Add the possibility to change the tracing_thresh to osnoise,
allowing a fine tune of OS noise detection.

- Add the auto-tracing feature (-a threshold us), which aims
helping the first approach to a problem by setting common
tracing features with a single parameter.

- Add -e/--event option, allowing osnoise and timerlat to
enable additional trace events via (possible multiple)
-e sys:event options.

- Add the --filter option to filter the previous -e event.

- Add the --trigger option to allow the usage of tracing
trigger of the previously set -e event. If the trigger
is hist: one, rtla automatically saves the hist file
associated with the -e event.

And some more improvements:

- Add --dma-latency option to tune exit from idle latencies

- Some minor fixes

Changes from V2:
 - Rebased to for-next
 - Add --dma-latency
 - Some more fixes
Changes from V1:
 - Add -e to osnoise/timerlat hist
 - Add --trigger
 - Add --filter
 - Add support to save hist file
 - Function name refactoring

Daniel Bristot de Oliveira (15):
  rtla/osnoise: Add support to adjust the tracing_thresh
  rtla/osnoise: Add an option to set the threshold
  rtla/osnoise: Add the automatic trace option
  rtla/timerlat: Add the automatic trace option
  rtla/trace: Add trace events helpers
  rtla: Add -e/--event support
  rtla/trace: Add trace event trigger helpers
  rtla: Add --trigger support
  rtla/trace: Add trace event filter helpers
  rtla: Add --filter support
  rtla/trace: Save event histogram output to a file
  rtla: Check for trace off also in the trace instance
  rtla/osnoise: Fix osnoise hist stop tracing message
  rtla/timerlat: Add --dma-latency option
  rtla: Tools main loop cleanup

 Documentation/tools/rtla/common_options.rst   |  19 +
 .../tools/rtla/common_osnoise_options.rst     |  10 +
 .../tools/rtla/common_timerlat_options.rst    |  12 +
 tools/tracing/rtla/src/osnoise.c              |  83 +++++
 tools/tracing/rtla/src/osnoise.h              |   8 +
 tools/tracing/rtla/src/osnoise_hist.c         |  95 ++++-
 tools/tracing/rtla/src/osnoise_top.c          |  91 ++++-
 tools/tracing/rtla/src/timerlat_hist.c        | 108 +++++-
 tools/tracing/rtla/src/timerlat_top.c         | 103 +++++-
 tools/tracing/rtla/src/trace.c                | 345 ++++++++++++++++++
 tools/tracing/rtla/src/trace.h                |  23 ++
 tools/tracing/rtla/src/utils.c                |  33 ++
 tools/tracing/rtla/src/utils.h                |   1 +
 13 files changed, 903 insertions(+), 28 deletions(-)

Comments

Juri Lelli March 11, 2022, 4:32 p.m. UTC | #1

Hi,

On 02/03/22 20:01, Daniel Bristot de Oliveira wrote:
> This set introduces some tracing facilities to rtla tools:
> 
> - Add the possibility to change the tracing_thresh to osnoise,
> allowing a fine tune of OS noise detection.
> 
> - Add the auto-tracing feature (-a threshold us), which aims
> helping the first approach to a problem by setting common
> tracing features with a single parameter.
> 
> - Add -e/--event option, allowing osnoise and timerlat to
> enable additional trace events via (possible multiple)
> -e sys:event options.
> 
> - Add the --filter option to filter the previous -e event.
> 
> - Add the --trigger option to allow the usage of tracing
> trigger of the previously set -e event. If the trigger
> is hist: one, rtla automatically saves the hist file
> associated with the -e event.
> 
> And some more improvements:
> 
> - Add --dma-latency option to tune exit from idle latencies
> 
> - Some minor fixes
> 
> Changes from V2:
>  - Rebased to for-next
>  - Add --dma-latency
>  - Some more fixes
> Changes from V1:
>  - Add -e to osnoise/timerlat hist
>  - Add --trigger
>  - Add --filter
>  - Add support to save hist file
>  - Function name refactoring

I took this for a spin and it looked good to me!

Tested-by: Juri Lelli <[e-mail]>

Thanks,
Juri