mbox series

[v4,0/4] btrfs: inode creation cleanups and fixes

Message ID cover.1647306546.git.osandov@fb.com (mailing list archive)
Headers show
Series btrfs: inode creation cleanups and fixes | expand

Message

Omar Sandoval March 15, 2022, 1:12 a.m. UTC
From: Omar Sandoval <osandov@fb.com>

This series contains minor updates of the final four patches of my
previous series [1].

Based on misc-next with the previous version of "btrfs: allocate inode
outside of btrfs_new_inode()" removed.

Changes since v3 [2]:

- Fixed a struct btrfs_root leak [3] in patch 1 which was fixed later in
  the same series by patch 3 for the sake of git bisect.

Changes since v2:

- Mentioned reason for removal of btrfs_lookup_dentry() call in
  create_subvol() in commit message of patch 1.
- Made btrfs_init_inode_security() also take btrfs_new_inode_args in
  patch 2.

Thanks!

1: https://lore.kernel.org/linux-btrfs/cover.1646875648.git.osandov@fb.com/
2: https://lore.kernel.org/linux-btrfs/cover.1647288019.git.osandov@fb.com/
3: https://lore.kernel.org/linux-btrfs/CAL3q7H5ACv3ej1=7P2y7mA1vCJoAcHkCqro6_VBuAUxeaw25rw@mail.gmail.com/

Omar Sandoval (4):
  btrfs: allocate inode outside of btrfs_new_inode()
  btrfs: factor out common part of btrfs_{mknod,create,mkdir}()
  btrfs: reserve correct number of items for inode creation
  btrfs: move common inode creation code into btrfs_create_new_inode()

 fs/btrfs/acl.c   |  36 +--
 fs/btrfs/ctree.h |  37 ++-
 fs/btrfs/inode.c | 800 +++++++++++++++++++++++------------------------
 fs/btrfs/ioctl.c | 140 +++++----
 fs/btrfs/props.c |  40 +--
 fs/btrfs/props.h |   4 -
 6 files changed, 489 insertions(+), 568 deletions(-)

Comments

Sweet Tea Dorminy March 15, 2022, 3 p.m. UTC | #1
All looks good to me still. Thanks!

On 3/14/22 21:12, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> This series contains minor updates of the final four patches of my
> previous series [1].
>
> Based on misc-next with the previous version of "btrfs: allocate inode
> outside of btrfs_new_inode()" removed.
>
> Changes since v3 [2]:
>
> - Fixed a struct btrfs_root leak [3] in patch 1 which was fixed later in
>    the same series by patch 3 for the sake of git bisect.
>
> Changes since v2:
>
> - Mentioned reason for removal of btrfs_lookup_dentry() call in
>    create_subvol() in commit message of patch 1.
> - Made btrfs_init_inode_security() also take btrfs_new_inode_args in
>    patch 2.
>
> Thanks!
>
> 1: https://lore.kernel.org/linux-btrfs/cover.1646875648.git.osandov@fb.com/
> 2: https://lore.kernel.org/linux-btrfs/cover.1647288019.git.osandov@fb.com/
> 3: https://lore.kernel.org/linux-btrfs/CAL3q7H5ACv3ej1=7P2y7mA1vCJoAcHkCqro6_VBuAUxeaw25rw@mail.gmail.com/
>
> Omar Sandoval (4):
>    btrfs: allocate inode outside of btrfs_new_inode()
>    btrfs: factor out common part of btrfs_{mknod,create,mkdir}()
>    btrfs: reserve correct number of items for inode creation
>    btrfs: move common inode creation code into btrfs_create_new_inode()
>
>   fs/btrfs/acl.c   |  36 +--
>   fs/btrfs/ctree.h |  37 ++-
>   fs/btrfs/inode.c | 800 +++++++++++++++++++++++------------------------
>   fs/btrfs/ioctl.c | 140 +++++----
>   fs/btrfs/props.c |  40 +--
>   fs/btrfs/props.h |   4 -
>   6 files changed, 489 insertions(+), 568 deletions(-)
>
David Sterba March 17, 2022, 8:21 p.m. UTC | #2
On Mon, Mar 14, 2022 at 06:12:31PM -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
> 
> This series contains minor updates of the final four patches of my
> previous series [1].
> 
> Based on misc-next with the previous version of "btrfs: allocate inode
> outside of btrfs_new_inode()" removed.
> 
> Changes since v3 [2]:
> 
> - Fixed a struct btrfs_root leak [3] in patch 1 which was fixed later in
>   the same series by patch 3 for the sake of git bisect.
> 
> Changes since v2:
> 
> - Mentioned reason for removal of btrfs_lookup_dentry() call in
>   create_subvol() in commit message of patch 1.
> - Made btrfs_init_inode_security() also take btrfs_new_inode_args in
>   patch 2.
> 
> Thanks!
> 
> 1: https://lore.kernel.org/linux-btrfs/cover.1646875648.git.osandov@fb.com/
> 2: https://lore.kernel.org/linux-btrfs/cover.1647288019.git.osandov@fb.com/
> 3: https://lore.kernel.org/linux-btrfs/CAL3q7H5ACv3ej1=7P2y7mA1vCJoAcHkCqro6_VBuAUxeaw25rw@mail.gmail.com/
> 
> Omar Sandoval (4):
>   btrfs: allocate inode outside of btrfs_new_inode()
>   btrfs: factor out common part of btrfs_{mknod,create,mkdir}()
>   btrfs: reserve correct number of items for inode creation
>   btrfs: move common inode creation code into btrfs_create_new_inode()

Added to misc-next, thanks.