Message ID | 20220316115155.17834-2-rex-bc.chen@mediatek.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | add display support for MediaTek SoC MT8186 | expand |
On 16/03/2022 12:51, Rex-BC Chen wrote: > Add aal binding for MT8183. > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> > --- > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml > index 61f0ed1e388f..eb0299b80522 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml > @@ -22,7 +22,9 @@ properties: > compatible: > oneOf: > - items: > - - const: mediatek,mt8173-disp-aal > + - enum: > + - mediatek,mt8173-disp-aal > + - mediatek,mt8183-disp-aal This should not be under items. You have just one element here, so directly "enum" under oneOf. Best regards, Krzysztof
On Wed, 2022-03-16 at 16:18 +0100, Krzysztof Kozlowski wrote: > On 16/03/2022 12:51, Rex-BC Chen wrote: > > Add aal binding for MT8183. > > > > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> > > --- > > .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 4 > > +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y > > aml > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y > > aml > > index 61f0ed1e388f..eb0299b80522 100644 > > --- > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y > > aml > > +++ > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y > > aml > > @@ -22,7 +22,9 @@ properties: > > compatible: > > oneOf: > > - items: > > - - const: mediatek,mt8173-disp-aal > > + - enum: > > + - mediatek,mt8173-disp-aal > > + - mediatek,mt8183-disp-aal > > This should not be under items. You have just one element here, so > directly "enum" under oneOf. > > > Best regards, > Krzysztof Hello Krzysztof, OK, I will do this in next version. Thanks! BRs, Rex
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml index 61f0ed1e388f..eb0299b80522 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml @@ -22,7 +22,9 @@ properties: compatible: oneOf: - items: - - const: mediatek,mt8173-disp-aal + - enum: + - mediatek,mt8173-disp-aal + - mediatek,mt8183-disp-aal - items: - enum: - mediatek,mt2712-disp-aal
Add aal binding for MT8183. Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> --- .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)