| Message ID | 20220317085130.36388-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 18146f25ac6695ce2ed09503de46dafd2b1f36a6 |
| Headers | show |
| Series | [-next] PCI: hv: Remove unused function hv_set_msi_entry_from_desc() | expand |
On Thu, Mar 17, 2022 at 04:51:30PM +0800, YueHaibing wrote: > This patch fix the following build error: > > drivers/pci/controller/pci-hyperv.c:769:13: error: ‘hv_set_msi_entry_from_desc’ defined but not used [-Werror=unused-function] > 769 | static void hv_set_msi_entry_from_desc(union hv_msi_entry *msi_entry, > > On arm64 hv_set_msi_entry_from_desc() is not used anymore since > commit d06957d7a692 ("PCI: hv: Avoid the retarget interrupt hypercall in irq_unmask() on ARM64"). > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Good catch! Acked-by: Boqun Feng <boqun.feng@gmail.com> Regards, Boqun > --- > drivers/pci/controller/pci-hyperv.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c > index df84d221e3de..558b35aba610 100644 > --- a/drivers/pci/controller/pci-hyperv.c > +++ b/drivers/pci/controller/pci-hyperv.c > @@ -766,14 +766,6 @@ static unsigned int hv_msi_get_int_vector(struct irq_data *irqd) > return irqd->parent_data->hwirq; > } > > -static void hv_set_msi_entry_from_desc(union hv_msi_entry *msi_entry, > - struct msi_desc *msi_desc) > -{ > - msi_entry->address = ((u64)msi_desc->msg.address_hi << 32) | > - msi_desc->msg.address_lo; > - msi_entry->data = msi_desc->msg.data; > -} > - > /* > * @nr_bm_irqs: Indicates the number of IRQs that were allocated from > * the bitmap. > -- > 2.17.1 >
On Thu, Mar 17, 2022 at 04:51:30PM +0800, YueHaibing wrote: > This patch fix the following build error: > > drivers/pci/controller/pci-hyperv.c:769:13: error: ‘hv_set_msi_entry_from_desc’ defined but not used [-Werror=unused-function] > 769 | static void hv_set_msi_entry_from_desc(union hv_msi_entry *msi_entry, > > On arm64 hv_set_msi_entry_from_desc() is not used anymore since > commit d06957d7a692 ("PCI: hv: Avoid the retarget interrupt hypercall in irq_unmask() on ARM64"). > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Reviewed-by: Nathan Chancellor <nathan@kernel.org> This build breakage is now in mainline, can it please be picked up in a timely manner? > --- > drivers/pci/controller/pci-hyperv.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c > index df84d221e3de..558b35aba610 100644 > --- a/drivers/pci/controller/pci-hyperv.c > +++ b/drivers/pci/controller/pci-hyperv.c > @@ -766,14 +766,6 @@ static unsigned int hv_msi_get_int_vector(struct irq_data *irqd) > return irqd->parent_data->hwirq; > } > > -static void hv_set_msi_entry_from_desc(union hv_msi_entry *msi_entry, > - struct msi_desc *msi_desc) > -{ > - msi_entry->address = ((u64)msi_desc->msg.address_hi << 32) | > - msi_desc->msg.address_lo; > - msi_entry->data = msi_desc->msg.data; > -} > - > /* > * @nr_bm_irqs: Indicates the number of IRQs that were allocated from > * the bitmap. > -- > 2.17.1 > >
On Thu, Mar 17, 2022 at 04:51:30PM +0800, YueHaibing wrote: > This patch fix the following build error: > > drivers/pci/controller/pci-hyperv.c:769:13: error: ‘hv_set_msi_entry_from_desc’ defined but not used [-Werror=unused-function] > 769 | static void hv_set_msi_entry_from_desc(union hv_msi_entry *msi_entry, > > On arm64 hv_set_msi_entry_from_desc() is not used anymore since > commit d06957d7a692 ("PCI: hv: Avoid the retarget interrupt hypercall in irq_unmask() on ARM64"). > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied to for-linus for v5.18, thanks! > --- > drivers/pci/controller/pci-hyperv.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c > index df84d221e3de..558b35aba610 100644 > --- a/drivers/pci/controller/pci-hyperv.c > +++ b/drivers/pci/controller/pci-hyperv.c > @@ -766,14 +766,6 @@ static unsigned int hv_msi_get_int_vector(struct irq_data *irqd) > return irqd->parent_data->hwirq; > } > > -static void hv_set_msi_entry_from_desc(union hv_msi_entry *msi_entry, > - struct msi_desc *msi_desc) > -{ > - msi_entry->address = ((u64)msi_desc->msg.address_hi << 32) | > - msi_desc->msg.address_lo; > - msi_entry->data = msi_desc->msg.data; > -} > - > /* > * @nr_bm_irqs: Indicates the number of IRQs that were allocated from > * the bitmap. > -- > 2.17.1 >
diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c index df84d221e3de..558b35aba610 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -766,14 +766,6 @@ static unsigned int hv_msi_get_int_vector(struct irq_data *irqd) return irqd->parent_data->hwirq; } -static void hv_set_msi_entry_from_desc(union hv_msi_entry *msi_entry, - struct msi_desc *msi_desc) -{ - msi_entry->address = ((u64)msi_desc->msg.address_hi << 32) | - msi_desc->msg.address_lo; - msi_entry->data = msi_desc->msg.data; -} - /* * @nr_bm_irqs: Indicates the number of IRQs that were allocated from * the bitmap.
This patch fix the following build error: drivers/pci/controller/pci-hyperv.c:769:13: error: ‘hv_set_msi_entry_from_desc’ defined but not used [-Werror=unused-function] 769 | static void hv_set_msi_entry_from_desc(union hv_msi_entry *msi_entry, On arm64 hv_set_msi_entry_from_desc() is not used anymore since commit d06957d7a692 ("PCI: hv: Avoid the retarget interrupt hypercall in irq_unmask() on ARM64"). Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/pci/controller/pci-hyperv.c | 8 -------- 1 file changed, 8 deletions(-)