| Message ID | 20220318183004.858707-2-luca.weiss@fairphone.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | UFS support on SM6350 & FP4 | expand |
On 18/03/2022 19:29, Luca Weiss wrote: > Document the compatible for the UFS found on SM6350. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On 19/03/2022 15:38, Krzysztof Kozlowski wrote: > On 18/03/2022 19:29, Luca Weiss wrote: >> Document the compatible for the UFS found on SM6350. >> >> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> >> --- >> Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 1 + >> 1 file changed, 1 insertion(+) >> > > > Acked-by: Krzysztof Kozlowski <krzk@kernel.org> No, I revoke it. You also missed the constraints in if:then. Best regards, Krzysztof
>-----Original Message----- >From: Luca Weiss [mailto:luca.weiss@fairphone.com] >Sent: Saturday, March 19, 2022 12:00 AM >To: linux-arm-msm@vger.kernel.org >Cc: ~postmarketos/upstreaming@lists.sr.ht; phone-devel@vger.kernel.org; >Luca Weiss <luca.weiss@fairphone.com>; Andy Gross <agross@kernel.org>; >Bjorn Andersson <bjorn.andersson@linaro.org>; Alim Akhtar ><alim.akhtar@samsung.com>; Avri Altman <avri.altman@wdc.com>; Rob >Herring <robh+dt@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; >linux-scsi@vger.kernel.org; devicetree@vger.kernel.org; linux- >kernel@vger.kernel.org >Subject: [PATCH 1/6] scsi: ufs: dt-bindings: Add SM6350 compatible string > >Document the compatible for the UFS found on SM6350. > >Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> >--- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >index 5b3a2157f7e5..d17db2cdf3c2 100644 >--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml >@@ -27,6 +27,7 @@ properties: > - qcom,msm8996-ufshc > - qcom,msm8998-ufshc > - qcom,sdm845-ufshc >+ - qcom,sm6350-ufshc You need to update "if:then" below as well, as this SoC is different than other in the series > - qcom,sm8150-ufshc > - qcom,sm8250-ufshc > - qcom,sm8350-ufshc >-- >2.35.1
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 5b3a2157f7e5..d17db2cdf3c2 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -27,6 +27,7 @@ properties: - qcom,msm8996-ufshc - qcom,msm8998-ufshc - qcom,sdm845-ufshc + - qcom,sm6350-ufshc - qcom,sm8150-ufshc - qcom,sm8250-ufshc - qcom,sm8350-ufshc
Document the compatible for the UFS found on SM6350. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 1 + 1 file changed, 1 insertion(+)