mbox series

[v2,0/4] PCI: mvebu: Slot support

Message ID 20220302145733.12606-1-pali@kernel.org (mailing list archive)
Headers show
Series PCI: mvebu: Slot support | expand

Message

Pali Rohár March 2, 2022, 2:57 p.m. UTC
This patch series add slot support to pci-mvebu.c driver.

It is based on branch pci/mvebu of git repository:
https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git

Changes in v2:
* Dropped patch with PCI_EXP_SLTCAP_*_SHIFT macros as it is not needed anymore
* Dropped patch "ARM: dts: turris-omnia: Set PCIe slot-power-limit-milliwatt properties" which was applied
* Added support for PCIe 6.0 slot power limit encodings
* Round down slot power limit value
* Fix handling of slot power limit with scale x1.0 (0x00 value)
* Use FIELD_PREP instead of _SHIFT macros
* Changed commit message to Bjorn's suggestion
* Changed comments in the code to match PCIe spec
* Preserve user settings of PCI_EXP_SLTCTL_ASPL_DISABLE bit

Pali Rohár (4):
  PCI: Add PCI_EXP_SLTCTL_ASPL_DISABLE macro
  dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property
  PCI: Add function for parsing 'slot-power-limit-milliwatt' DT property
  PCI: mvebu: Add support for sending Set_Slot_Power_Limit message

 Documentation/devicetree/bindings/pci/pci.txt |  6 ++
 drivers/pci/controller/pci-mvebu.c            | 96 ++++++++++++++++++-
 drivers/pci/of.c                              | 64 +++++++++++++
 drivers/pci/pci.h                             | 15 +++
 include/uapi/linux/pci_regs.h                 |  1 +
 5 files changed, 177 insertions(+), 5 deletions(-)

Comments

Pali Rohár March 8, 2022, 11:38 a.m. UTC | #1
Hello Bjorn! Could you look if v2 changes are now fine?

On Wednesday 02 March 2022 15:57:29 Pali Rohár wrote:
> This patch series add slot support to pci-mvebu.c driver.
> 
> It is based on branch pci/mvebu of git repository:
> https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> 
> Changes in v2:
> * Dropped patch with PCI_EXP_SLTCAP_*_SHIFT macros as it is not needed anymore
> * Dropped patch "ARM: dts: turris-omnia: Set PCIe slot-power-limit-milliwatt properties" which was applied
> * Added support for PCIe 6.0 slot power limit encodings
> * Round down slot power limit value
> * Fix handling of slot power limit with scale x1.0 (0x00 value)
> * Use FIELD_PREP instead of _SHIFT macros
> * Changed commit message to Bjorn's suggestion
> * Changed comments in the code to match PCIe spec
> * Preserve user settings of PCI_EXP_SLTCTL_ASPL_DISABLE bit
> 
> Pali Rohár (4):
>   PCI: Add PCI_EXP_SLTCTL_ASPL_DISABLE macro
>   dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property
>   PCI: Add function for parsing 'slot-power-limit-milliwatt' DT property
>   PCI: mvebu: Add support for sending Set_Slot_Power_Limit message
> 
>  Documentation/devicetree/bindings/pci/pci.txt |  6 ++
>  drivers/pci/controller/pci-mvebu.c            | 96 ++++++++++++++++++-
>  drivers/pci/of.c                              | 64 +++++++++++++
>  drivers/pci/pci.h                             | 15 +++
>  include/uapi/linux/pci_regs.h                 |  1 +
>  5 files changed, 177 insertions(+), 5 deletions(-)
> 
> -- 
> 2.20.1
>
Pali Rohár March 21, 2022, 6:29 p.m. UTC | #2
PING?

On Tuesday 08 March 2022 12:38:31 Pali Rohár wrote:
> Hello Bjorn! Could you look if v2 changes are now fine?
> 
> On Wednesday 02 March 2022 15:57:29 Pali Rohár wrote:
> > This patch series add slot support to pci-mvebu.c driver.
> > 
> > It is based on branch pci/mvebu of git repository:
> > https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > 
> > Changes in v2:
> > * Dropped patch with PCI_EXP_SLTCAP_*_SHIFT macros as it is not needed anymore
> > * Dropped patch "ARM: dts: turris-omnia: Set PCIe slot-power-limit-milliwatt properties" which was applied
> > * Added support for PCIe 6.0 slot power limit encodings
> > * Round down slot power limit value
> > * Fix handling of slot power limit with scale x1.0 (0x00 value)
> > * Use FIELD_PREP instead of _SHIFT macros
> > * Changed commit message to Bjorn's suggestion
> > * Changed comments in the code to match PCIe spec
> > * Preserve user settings of PCI_EXP_SLTCTL_ASPL_DISABLE bit
> > 
> > Pali Rohár (4):
> >   PCI: Add PCI_EXP_SLTCTL_ASPL_DISABLE macro
> >   dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property
> >   PCI: Add function for parsing 'slot-power-limit-milliwatt' DT property
> >   PCI: mvebu: Add support for sending Set_Slot_Power_Limit message
> > 
> >  Documentation/devicetree/bindings/pci/pci.txt |  6 ++
> >  drivers/pci/controller/pci-mvebu.c            | 96 ++++++++++++++++++-
> >  drivers/pci/of.c                              | 64 +++++++++++++
> >  drivers/pci/pci.h                             | 15 +++
> >  include/uapi/linux/pci_regs.h                 |  1 +
> >  5 files changed, 177 insertions(+), 5 deletions(-)
> > 
> > -- 
> > 2.20.1
> >
Bjorn Helgaas March 24, 2022, 5:12 p.m. UTC | #3
On Mon, Mar 21, 2022 at 07:29:08PM +0100, Pali Rohár wrote:
> PING?

Sorry, my fault.  I reviewed v1 of this patch, so obviously Lorenzo
would wait for me to chime in here.

> On Tuesday 08 March 2022 12:38:31 Pali Rohár wrote:
> > Hello Bjorn! Could you look if v2 changes are now fine?
> > 
> > On Wednesday 02 March 2022 15:57:29 Pali Rohár wrote:
> > > This patch series add slot support to pci-mvebu.c driver.
> > > 
> > > It is based on branch pci/mvebu of git repository:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > > 
> > > Changes in v2:
> > > * Dropped patch with PCI_EXP_SLTCAP_*_SHIFT macros as it is not needed anymore
> > > * Dropped patch "ARM: dts: turris-omnia: Set PCIe slot-power-limit-milliwatt properties" which was applied
> > > * Added support for PCIe 6.0 slot power limit encodings
> > > * Round down slot power limit value
> > > * Fix handling of slot power limit with scale x1.0 (0x00 value)
> > > * Use FIELD_PREP instead of _SHIFT macros
> > > * Changed commit message to Bjorn's suggestion
> > > * Changed comments in the code to match PCIe spec
> > > * Preserve user settings of PCI_EXP_SLTCTL_ASPL_DISABLE bit
> > > 
> > > Pali Rohár (4):
> > >   PCI: Add PCI_EXP_SLTCTL_ASPL_DISABLE macro
> > >   dt-bindings: Add 'slot-power-limit-milliwatt' PCIe port property
> > >   PCI: Add function for parsing 'slot-power-limit-milliwatt' DT property
> > >   PCI: mvebu: Add support for sending Set_Slot_Power_Limit message
> > > 
> > >  Documentation/devicetree/bindings/pci/pci.txt |  6 ++
> > >  drivers/pci/controller/pci-mvebu.c            | 96 ++++++++++++++++++-
> > >  drivers/pci/of.c                              | 64 +++++++++++++
> > >  drivers/pci/pci.h                             | 15 +++
> > >  include/uapi/linux/pci_regs.h                 |  1 +
> > >  5 files changed, 177 insertions(+), 5 deletions(-)
> > > 
> > > -- 
> > > 2.20.1
> > > 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel