mbox series

[v4,00/16] Support external boost at CS35l41 ASoC driver

Message ID 20220317093120.168534-1-tanureal@opensource.cirrus.com (mailing list archive)
Headers show
Series Support external boost at CS35l41 ASoC driver | expand

Message

Lucas Tanure March 17, 2022, 9:31 a.m. UTC 
Move the support for CS35L41 external boost to its shared library
for ASoC use.
This move resulted in cs35l41_hda_reg_sequence being removed,
and its steps were broken down into regmap writes or functions
from the library. And hardware configuration struct was unified
for its use in the shared lib.
While at it, some minor bugs were found and fixed it.

v4 changelog:
 - Separated GPIO 1 and 2 function enums

v3 changelog:
 - Remove patches already accepted
 - Improved logic in documentation patch
 - Documentation patch goes before its code
 - Fixed missing Signed-off-by
 - Fixed subject for HDA patches

v2 changelog:
 - Instead of removing the log, playback actions will log the last regmap access.
 - Documentation patch with the correct subject line and fixed bug reported by Rob Herring on the
 provided example.

Previous versions:
 v1: https://lkml.org/lkml/2022/3/3/759
 v2: https://lkml.org/lkml/2022/3/4/743
 v3: https://lkml.org/lkml/2022/3/8/975

David Rhodes (1):
  ASoC: dt-bindings: cs35l41: Document CS35l41 External Boost

Lucas Tanure (15):
  sound: cs35l41: Unify hardware configuration
  sound: cs35l41: Check hw_config before using it
  sound: cs35l41: Move cs35l41_gpio_config to shared lib
  ALSA: hda: cs35l41: Fix I2S params comments
  ALSA: hda: cs35l41: Always configure the DAI
  ALSA: hda: cs35l41: Add Boost type flag
  hda: cs35l41: Put the device into safe mode for external boost
  hda: cs35l41: Mute the device before shutdown
  sound: cs35l41: Enable Internal Boost in shared lib
  ALSA: hda: cs35l41: Move boost config to initialization code
  ALSA: hda: cs35l41: Remove cs35l41_hda_reg_sequence struct
  ALSA: hda: cs35l41: Reorganize log for playback actions
  ALSA: hda: cs35l41: Handle all external boost setups the same way
  ALSA: hda: cs35l41: Move external boost handling to lib for ASoC use
  ASoC: cs35l41: Support external boost

 .../bindings/sound/cirrus,cs35l41.yaml        |  44 ++-
 include/sound/cs35l41.h                       |  59 +++-
 sound/pci/hda/cs35l41_hda.c                   | 295 ++++++------------
 sound/pci/hda/cs35l41_hda.h                   |  27 +-
 sound/soc/codecs/cs35l41-i2c.c                |   4 +-
 sound/soc/codecs/cs35l41-lib.c                | 190 ++++++++++-
 sound/soc/codecs/cs35l41-spi.c                |   4 +-
 sound/soc/codecs/cs35l41.c                    | 166 +++++-----
 sound/soc/codecs/cs35l41.h                    |   5 +-
 9 files changed, 443 insertions(+), 351 deletions(-)

Comments

Takashi Iwai March 22, 2022, 1:21 p.m. UTC | #1 
On Thu, 17 Mar 2022 10:31:04 +0100,
Lucas Tanure wrote:
> 
> Move the support for CS35L41 external boost to its shared library
> for ASoC use.
> This move resulted in cs35l41_hda_reg_sequence being removed,
> and its steps were broken down into regmap writes or functions
> from the library. And hardware configuration struct was unified
> for its use in the shared lib.
> While at it, some minor bugs were found and fixed it.
> 
> v4 changelog:
>  - Separated GPIO 1 and 2 function enums
> 
> v3 changelog:
>  - Remove patches already accepted
>  - Improved logic in documentation patch
>  - Documentation patch goes before its code
>  - Fixed missing Signed-off-by
>  - Fixed subject for HDA patches
> 
> v2 changelog:
>  - Instead of removing the log, playback actions will log the last regmap access.
>  - Documentation patch with the correct subject line and fixed bug reported by Rob Herring on the
>  provided example.
> 
> Previous versions:
>  v1: https://lkml.org/lkml/2022/3/3/759
>  v2: https://lkml.org/lkml/2022/3/4/743
>  v3: https://lkml.org/lkml/2022/3/8/975
> 
> David Rhodes (1):
>   ASoC: dt-bindings: cs35l41: Document CS35l41 External Boost
> 
> Lucas Tanure (15):
>   sound: cs35l41: Unify hardware configuration
>   sound: cs35l41: Check hw_config before using it
>   sound: cs35l41: Move cs35l41_gpio_config to shared lib
>   ALSA: hda: cs35l41: Fix I2S params comments
>   ALSA: hda: cs35l41: Always configure the DAI
>   ALSA: hda: cs35l41: Add Boost type flag
>   hda: cs35l41: Put the device into safe mode for external boost
>   hda: cs35l41: Mute the device before shutdown
>   sound: cs35l41: Enable Internal Boost in shared lib
>   ALSA: hda: cs35l41: Move boost config to initialization code
>   ALSA: hda: cs35l41: Remove cs35l41_hda_reg_sequence struct
>   ALSA: hda: cs35l41: Reorganize log for playback actions
>   ALSA: hda: cs35l41: Handle all external boost setups the same way
>   ALSA: hda: cs35l41: Move external boost handling to lib for ASoC use
>   ASoC: cs35l41: Support external boost

The code changes look OK (but for the issue Rob reported for
dt-bindings stuff).

But, could you try to use more consistent prefix for the subject
lines?  We don't use "sound:" prefix in general unless the patch is
about (native) OSS drivers.  Instead, use "ALSA:" for the general
ALSA/ASoC patches.  Also, "hda:" should be "ALSA: hda:" instead.


thanks,

Takashi