| Message ID | 20220324175015.232794-8-victortoso@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix some qapi examples and a TODO section | expand |
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso <victortoso@redhat.com> wrote: > > * Timestamp is not optional, let's add for completeness. > * Add '<-' to signalize it is receiving the data > * Break likes like most of examples do Oh, I think you meant "break lines like". That took a long minute to parse. > > Signed-off-by: Victor Toso <victortoso@redhat.com> > --- > qapi/migration.json | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/qapi/migration.json b/qapi/migration.json > index 18e2610e88..092a63354b 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -1736,7 +1736,9 @@ > # Since: 4.2 > # > # Example: > -# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} } > +# <- { "event": "UNPLUG_PRIMARY", > +# "data": { "device-id": "hostdev0" }, > +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } > # > ## > { 'event': 'UNPLUG_PRIMARY', > -- > 2.35.1 > With commit message amended: Reviewed-by: John Snow <jsnow@redhat.com>
diff --git a/qapi/migration.json b/qapi/migration.json index 18e2610e88..092a63354b 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -1736,7 +1736,9 @@ # Since: 4.2 # # Example: -# {"event": "UNPLUG_PRIMARY", "data": {"device-id": "hostdev0"} } +# <- { "event": "UNPLUG_PRIMARY", +# "data": { "device-id": "hostdev0" }, +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } } # ## { 'event': 'UNPLUG_PRIMARY',
* Timestamp is not optional, let's add for completeness. * Add '<-' to signalize it is receiving the data * Break likes like most of examples do Signed-off-by: Victor Toso <victortoso@redhat.com> --- qapi/migration.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)