| Message ID | 20220328143035.519909-7-vkoul@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: qcom: Get rid of some warnings | expand |
On 28/03/2022 16:30, Vinod Koul wrote: > The child of dsi nodes do not have unit address, this causes warnings: > > arch/arm64/boot/dts/qcom/sm8250.dtsi:3249.22-3301.6: > Warning (avoid_unnecessary_addr_size): /soc@0/mdss@ae00000/dsi@ae94000: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > arch/arm64/boot/dts/qcom/sm8250.dtsi:3322.22-3374.6: > Warning (avoid_unnecessary_addr_size): /soc@0/mdss@ae00000/dsi@ae96000: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > So remove #address-cells/#size-cells for dsi nodes. Looks good. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 28/03/2022 16:30, Vinod Koul wrote: > The child of dsi nodes do not have unit address, this causes warnings: > > arch/arm64/boot/dts/qcom/sm8250.dtsi:3249.22-3301.6: > Warning (avoid_unnecessary_addr_size): /soc@0/mdss@ae00000/dsi@ae94000: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > arch/arm64/boot/dts/qcom/sm8250.dtsi:3322.22-3374.6: > Warning (avoid_unnecessary_addr_size): /soc@0/mdss@ae00000/dsi@ae96000: > unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > So remove #address-cells/#size-cells for dsi nodes. I think this needs different fix and my review was not correct. MIPI DSI is a bus, so it can have children with unit addresses. This DTSI (and several others) should have address/size cells, so downstream could add easily children (e.g. panel nodes). However I don't know how to combine it with "ports" not having unit address. Maybe Rob has some ideas? Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index fb94b342f2d1..a76089ebf9ca 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -3275,9 +3275,6 @@ dsi0: dsi@ae94000 { status = "disabled"; - #address-cells = <1>; - #size-cells = <0>; - ports { #address-cells = <1>; #size-cells = <0>; @@ -3348,9 +3345,6 @@ dsi1: dsi@ae96000 { status = "disabled"; - #address-cells = <1>; - #size-cells = <0>; - ports { #address-cells = <1>; #size-cells = <0>;
The child of dsi nodes do not have unit address, this causes warnings: arch/arm64/boot/dts/qcom/sm8250.dtsi:3249.22-3301.6: Warning (avoid_unnecessary_addr_size): /soc@0/mdss@ae00000/dsi@ae94000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property arch/arm64/boot/dts/qcom/sm8250.dtsi:3322.22-3374.6: Warning (avoid_unnecessary_addr_size): /soc@0/mdss@ae00000/dsi@ae96000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property So remove #address-cells/#size-cells for dsi nodes. Signed-off-by: Vinod Koul <vkoul@kernel.org> --- arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 ------ 1 file changed, 6 deletions(-)