| Message ID | 20220328134650.72265-1-naresh.kamboju@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d9142e1cf3bbdaf21337767114ecab26fe702d47 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: net: Add tls config dependency for tls selftests | expand |
Hello: This patch was applied to bpf/bpf.git (master) by David S. Miller <davem@davemloft.net>: On Mon, 28 Mar 2022 19:16:50 +0530 you wrote: > selftest net tls test cases need TLS=m without this the test hangs. > Enabling config TLS solves this problem and runs to complete. > - CONFIG_TLS=m > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org> > > [...] Here is the summary with links: - selftests: net: Add tls config dependency for tls selftests https://git.kernel.org/bpf/bpf/c/d9142e1cf3bb You are awesome, thank you!
On Mon, 28 Mar 2022 19:16:50 +0530 Naresh Kamboju wrote: > selftest net tls test cases need TLS=m without this the test hangs. The test is supposed to fall back / skip cleanly when TLS is not built. That's useful to test compatibility with TCP. It'd be great if you could reply to questions I asked you on your report instead of sending out incorrect patches. > Enabling config TLS solves this problem and runs to complete. > - CONFIG_TLS=m > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Hi Jakub On Tue, 29 Mar 2022 at 02:24, Jakub Kicinski <kuba@kernel.org> wrote: > > On Mon, 28 Mar 2022 19:16:50 +0530 Naresh Kamboju wrote: > > selftest net tls test cases need TLS=m without this the test hangs. > > The test is supposed to fall back / skip cleanly when TLS is not built. > That's useful to test compatibility with TCP. > > It'd be great if you could reply to questions I asked you on your > report instead of sending out incorrect patches. I have replied to your question on other email thread [1] - Naresh [1] https://lore.kernel.org/linux-next/CA+G9fYsjP2+20YLbKTFU-4_v+VLq6MfaagjERL9PWETs+sX8Zg@mail.gmail.com/
diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config index ead7963b9bf0..cecb921a0dbf 100644 --- a/tools/testing/selftests/net/config +++ b/tools/testing/selftests/net/config @@ -43,5 +43,6 @@ CONFIG_NET_ACT_TUNNEL_KEY=m CONFIG_NET_ACT_MIRRED=m CONFIG_BAREUDP=m CONFIG_IPV6_IOAM6_LWTUNNEL=y +CONFIG_TLS=m CONFIG_CRYPTO_SM4=y CONFIG_AMT=m
selftest net tls test cases need TLS=m without this the test hangs. Enabling config TLS solves this problem and runs to complete. - CONFIG_TLS=m Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org> --- tools/testing/selftests/net/config | 1 + 1 file changed, 1 insertion(+)