| Message ID | 20220328214324.252472-1-marex@denx.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/bridge: tc358767: Add DSI-to-DPI mode support | expand |
Hi Marek, Am Montag, dem 28.03.2022 um 23:43 +0200 schrieb Marek Vasut: > The TC358767/TC358867/TC9595 are all capable of operating in multiple > modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Clean up the driver, > switch to atomic ops, and add support for the DSI-to-DPI mode in > addition to already supported DPI-to-(e)DP mode. > Not sure if anyone else has any more comments. For what it is worth, I just skimmed through the series again and it looks good to me now. Regards, Lucas > Cc: Jonas Karlman <jonas@kwiboo.se> > Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> > Cc: Maxime Ripard <maxime@cerno.tech> > Cc: Neil Armstrong <narmstrong@baylibre.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > To: dri-devel@lists.freedesktop.org > > Marek Vasut (11): > dt-bindings: display: bridge: tc358867: Document DPI output support > dt-bindings: display: bridge: tc358867: Document DSI data-lanes > property > drm/bridge: tc358767: Change tc_ prefix to tc_edp_ for (e)DP specific > functions > drm/bridge: tc358767: Convert to atomic ops > drm/bridge: tc358767: Implement atomic_check callback > drm/bridge: tc358767: Move (e)DP bridge endpoint parsing into > dedicated function > drm/bridge: tc358767: Wrap (e)DP aux I2C registration into > tc_aux_link_setup() > drm/bridge: tc358767: Move bridge ops setup into > tc_probe_edp_bridge_endpoint() > drm/bridge: tc358767: Detect bridge mode from connected endpoints in > DT > drm/bridge: tc358767: Split tc_set_video_mode() into common and (e)DP > part > drm/bridge: tc358767: Add DSI-to-DPI mode support > > .../display/bridge/toshiba,tc358767.yaml | 22 +- > drivers/gpu/drm/bridge/Kconfig | 1 + > drivers/gpu/drm/bridge/tc358767.c | 566 ++++++++++++++++-- > 3 files changed, 529 insertions(+), 60 deletions(-) >
On 3/29/22 09:47, Lucas Stach wrote: > Hi Marek, Hi, > Am Montag, dem 28.03.2022 um 23:43 +0200 schrieb Marek Vasut: >> The TC358767/TC358867/TC9595 are all capable of operating in multiple >> modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Clean up the driver, >> switch to atomic ops, and add support for the DSI-to-DPI mode in >> addition to already supported DPI-to-(e)DP mode. >> > Not sure if anyone else has any more comments. For what it is worth, I > just skimmed through the series again and it looks good to me now. The robot does, but that should be easy to fix.
The TC358767/TC358867/TC9595 are all capable of operating in multiple modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Clean up the driver, switch to atomic ops, and add support for the DSI-to-DPI mode in addition to already supported DPI-to-(e)DP mode. Cc: Jonas Karlman <jonas@kwiboo.se> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: Maxime Ripard <maxime@cerno.tech> Cc: Neil Armstrong <narmstrong@baylibre.com> Cc: Sam Ravnborg <sam@ravnborg.org> To: dri-devel@lists.freedesktop.org Marek Vasut (11): dt-bindings: display: bridge: tc358867: Document DPI output support dt-bindings: display: bridge: tc358867: Document DSI data-lanes property drm/bridge: tc358767: Change tc_ prefix to tc_edp_ for (e)DP specific functions drm/bridge: tc358767: Convert to atomic ops drm/bridge: tc358767: Implement atomic_check callback drm/bridge: tc358767: Move (e)DP bridge endpoint parsing into dedicated function drm/bridge: tc358767: Wrap (e)DP aux I2C registration into tc_aux_link_setup() drm/bridge: tc358767: Move bridge ops setup into tc_probe_edp_bridge_endpoint() drm/bridge: tc358767: Detect bridge mode from connected endpoints in DT drm/bridge: tc358767: Split tc_set_video_mode() into common and (e)DP part drm/bridge: tc358767: Add DSI-to-DPI mode support .../display/bridge/toshiba,tc358767.yaml | 22 +- drivers/gpu/drm/bridge/Kconfig | 1 + drivers/gpu/drm/bridge/tc358767.c | 566 ++++++++++++++++-- 3 files changed, 529 insertions(+), 60 deletions(-)