| Message ID | 1648605588-19269-1-git-send-email-baihaowen@meizu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2609f635a20d3691e7b5725edc3bdadb7bedf8fb |
| Headers | show |
| Series | [V2] selftests/bpf: Fix warning comparing pointer to 0 | expand |
On 3/29/22 6:59 PM, Haowen Bai wrote: > Avoid pointer type value compared with 0 to make code clear. > > reported by coccicheck: > tools/testing/selftests/bpf/progs/map_ptr_kern.c:370:21-22: > WARNING comparing pointer to 0 > tools/testing/selftests/bpf/progs/map_ptr_kern.c:397:21-22: > WARNING comparing pointer to 0 > > Signed-off-by: Haowen Bai <baihaowen@meizu.com> Acked-by: Yonghong Song <yhs@fb.com>
Hello: This patch was applied to bpf/bpf.git (master) by Daniel Borkmann <daniel@iogearbox.net>: On Wed, 30 Mar 2022 09:59:48 +0800 you wrote: > Avoid pointer type value compared with 0 to make code clear. > > reported by coccicheck: > tools/testing/selftests/bpf/progs/map_ptr_kern.c:370:21-22: > WARNING comparing pointer to 0 > tools/testing/selftests/bpf/progs/map_ptr_kern.c:397:21-22: > WARNING comparing pointer to 0 > > [...] Here is the summary with links: - [V2] selftests/bpf: Fix warning comparing pointer to 0 https://git.kernel.org/bpf/bpf/c/2609f635a20d You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/progs/map_ptr_kern.c b/tools/testing/selftests/bpf/progs/map_ptr_kern.c index b64df94..db388f5 100644 --- a/tools/testing/selftests/bpf/progs/map_ptr_kern.c +++ b/tools/testing/selftests/bpf/progs/map_ptr_kern.c @@ -367,7 +367,7 @@ static inline int check_array_of_maps(void) VERIFY(check_default(&array_of_maps->map, map)); inner_map = bpf_map_lookup_elem(array_of_maps, &key); - VERIFY(inner_map != 0); + VERIFY(inner_map != NULL); VERIFY(inner_map->map.max_entries == INNER_MAX_ENTRIES); return 1; @@ -394,7 +394,7 @@ static inline int check_hash_of_maps(void) VERIFY(check_default(&hash_of_maps->map, map)); inner_map = bpf_map_lookup_elem(hash_of_maps, &key); - VERIFY(inner_map != 0); + VERIFY(inner_map != NULL); VERIFY(inner_map->map.max_entries == INNER_MAX_ENTRIES); return 1;
Avoid pointer type value compared with 0 to make code clear. reported by coccicheck: tools/testing/selftests/bpf/progs/map_ptr_kern.c:370:21-22: WARNING comparing pointer to 0 tools/testing/selftests/bpf/progs/map_ptr_kern.c:397:21-22: WARNING comparing pointer to 0 Signed-off-by: Haowen Bai <baihaowen@meizu.com> --- V1->V2: include the error/warn message. tools/testing/selftests/bpf/progs/map_ptr_kern.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)