| Message ID | 1648101804-3584-3-git-send-email-xinlei.lee@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format | expand |
Hi Xinlei, > Remove dt-binding documentation of pwm for MediaTek MT8167 SoC. > I did not find the compatiable corresponding to mt8167 > in the latest version of the pwm-mtk-disp.c driver file. > It may be disabled but not updated to the dt_binding file. > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > --- > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > index f844695d605a..f18e8bbd13d2 100644 > --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > @@ -20,9 +20,6 @@ properties: > - mediatek,mt2701-disp-pwm > - mediatek,mt6595-disp-pwm > - mediatek,mt8173-disp-pwm > - - items: > - - const: mediatek,mt8167-disp-pwm > - - const: mediatek,mt8173-disp-pwm I checked: grep -e 'mediatek,mt8167-disp-pwm' -e 'mediatek,mt8173-disp-pwm' drivers/ -RnH drivers/gpu/drm/mediatek/mtk_drm_drv.c:486: { .compatible = "mediatek,mt8167-disp-pwm", drivers/gpu/drm/mediatek/mtk_drm_drv.c:488: { .compatible = "mediatek,mt8173-disp-pwm", mediatek,mt8167-disp-pwm and mediatek,mt8173-disp-pwm are used in drivers/gpu/drm/mediatek/mtk_drm_drv.c. (added by commit 58e4c5398200 ("drm/mediatek: Add support for main DDP path on MT8167")) Is it ok to remove mediatek,mt8167-disp-pwm and mediatek,mt8173-disp-pwm? Thanks, Miles > > reg: > maxItems: 1
On Fri, 2022-03-25 at 07:48 +0800, Miles Chen wrote: > Hi Xinlei, > > > Remove dt-binding documentation of pwm for MediaTek MT8167 SoC. > > I did not find the compatiable corresponding to mt8167 > > in the latest version of the pwm-mtk-disp.c driver file. > > It may be disabled but not updated to the dt_binding file. > > > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > > --- > > Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 3 > > --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm- > > disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm- > > disp.yaml > > index f844695d605a..f18e8bbd13d2 100644 > > --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > > +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml > > @@ -20,9 +20,6 @@ properties: > > - mediatek,mt2701-disp-pwm > > - mediatek,mt6595-disp-pwm > > - mediatek,mt8173-disp-pwm > > - - items: > > - - const: mediatek,mt8167-disp-pwm > > - - const: mediatek,mt8173-disp-pwm > > I checked: > grep -e 'mediatek,mt8167-disp-pwm' -e 'mediatek,mt8173-disp-pwm' > drivers/ -RnH > drivers/gpu/drm/mediatek/mtk_drm_drv.c:486: { .compatible = > "mediatek,mt8167-disp-pwm", > drivers/gpu/drm/mediatek/mtk_drm_drv.c:488: { .compatible = > "mediatek,mt8173-disp-pwm", > > mediatek,mt8167-disp-pwm and mediatek,mt8173-disp-pwm are used in > drivers/gpu/drm/mediatek/mtk_drm_drv.c. > (added by commit 58e4c5398200 ("drm/mediatek: Add support for main > DDP path on MT8167")) > > Is it ok to remove mediatek,mt8167-disp-pwm and mediatek,mt8173-disp- > pwm? > > Thanks, > Miles > > > > reg: > > maxItems: 1 hi Miles: Thanks for your suggestion. Maybe I misunderstood this mt8167 driver before. It is a reused mt8173 driver and not removed. I will remove this patch from this series in the next version. Best Regards! xinlei
diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml index f844695d605a..f18e8bbd13d2 100644 --- a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml @@ -20,9 +20,6 @@ properties: - mediatek,mt2701-disp-pwm - mediatek,mt6595-disp-pwm - mediatek,mt8173-disp-pwm - - items: - - const: mediatek,mt8167-disp-pwm - - const: mediatek,mt8173-disp-pwm reg: maxItems: 1