| Message ID | 20220330061335.1015533-1-kai.heng.feng@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f30741cded62f87bb4b1cc58bc627f076abcaba8 |
| Headers | show |
| Series | [v2] ALSA: hda/realtek: Fix audio regression on Mi Notebook Pro 2020 | expand |
On Wed, 30 Mar 2022 08:13:33 +0200, Kai-Heng Feng wrote: > > Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording > issue") is to solve recording issue met on AL236, by matching codec > variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256. > > This match can be too broad and Mi Notebook Pro 2020 is broken by the > patch. > > Instead, use codec ID to be narrow down the scope, in order to make > ALC256 unaffected. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484 > Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > v2: > Fix wrong comparison, || -> && Thanks, applied now. Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 4c33cb57963db..aace474a899de 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -3617,8 +3617,8 @@ static void alc256_shutup(struct hda_codec *codec) /* If disable 3k pulldown control for alc257, the Mic detection will not work correctly * when booting with headset plugged. So skip setting it for the codec alc257 */ - if (spec->codec_variant != ALC269_TYPE_ALC257 && - spec->codec_variant != ALC269_TYPE_ALC256) + if (codec->core.vendor_id != 0x10ec0236 && + codec->core.vendor_id != 0x10ec0257) alc_update_coef_idx(codec, 0x46, 0, 3 << 12); if (!spec->no_shutup_pins)
Commit 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue") is to solve recording issue met on AL236, by matching codec variant ALC269_TYPE_ALC257 and ALC269_TYPE_ALC256. This match can be too broad and Mi Notebook Pro 2020 is broken by the patch. Instead, use codec ID to be narrow down the scope, in order to make ALC256 unaffected. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215484 Fixes: 5aec98913095 ("ALSA: hda/realtek - ALC236 headset MIC recording issue") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- v2: Fix wrong comparison, || -> && sound/pci/hda/patch_realtek.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)