| Message ID | 20220331190633.121077-3-victortoso@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix some qapi examples | expand |
Victor Toso <victortoso@redhat.com> writes: > Both examples outputs are using @data member for the arguments. This > is wrong. The expected member for the QMP is @arguments. Fix it. > > Signed-off-by: Victor Toso <victortoso@redhat.com> > --- > qapi/replay.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qapi/replay.json b/qapi/replay.json > index b4d1ba253b..351898f60d 100644 > --- a/qapi/replay.json > +++ b/qapi/replay.json > @@ -81,7 +81,7 @@ > # > # Example: > # > -# -> { "execute": "replay-break", "data": { "icount": 220414 } } > +# -> { "execute": "replay-break", "arguments": { "icount": 220414 } } > # > ## > { 'command': 'replay-break', 'data': { 'icount': 'int' } } > @@ -117,6 +117,6 @@ > # > # Example: > # > -# -> { "execute": "replay-seek", "data": { "icount": 220414 } } > +# -> { "execute": "replay-seek", "arguments": { "icount": 220414 } } > ## > { 'command': 'replay-seek', 'data': { 'icount': 'int' } } I should've flagged these when I reviewed commit b1ca53224a "qapi/migration: Fix examples document wrong field name for arguments". Reviewed-by: Markus Armbruster <armbru@redhat.com>
diff --git a/qapi/replay.json b/qapi/replay.json index b4d1ba253b..351898f60d 100644 --- a/qapi/replay.json +++ b/qapi/replay.json @@ -81,7 +81,7 @@ # # Example: # -# -> { "execute": "replay-break", "data": { "icount": 220414 } } +# -> { "execute": "replay-break", "arguments": { "icount": 220414 } } # ## { 'command': 'replay-break', 'data': { 'icount': 'int' } } @@ -117,6 +117,6 @@ # # Example: # -# -> { "execute": "replay-seek", "data": { "icount": 220414 } } +# -> { "execute": "replay-seek", "arguments": { "icount": 220414 } } ## { 'command': 'replay-seek', 'data': { 'icount': 'int' } }
Both examples outputs are using @data member for the arguments. This is wrong. The expected member for the QMP is @arguments. Fix it. Signed-off-by: Victor Toso <victortoso@redhat.com> --- qapi/replay.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)