| Message ID | 20220319223306.60782-3-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Under Review |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: r8a77961: improvements from BSP | expand |
Hi Wolfram, On Mon, Mar 21, 2022 at 11:00 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > From: LUU HOAI <hoai.luu.ub@renesas.com> > > Keep aligned with other Gen3 SoCs and sort the I2C busses. > > Signed-off-by: LUU HOAI <hoai.luu.ub@renesas.com> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Do we really need them? Aliases are meant to refer to labels on physical ports on boards, so even if these labels would be present, they do not belong to .dtsi files. Unless you have a good reason to keep them, I'd rather remove them everywhere. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
> Unless you have a good reason to keep them, I'd rather remove them > everywhere. Would you agree to move them to salvator-common.dtsi then? The schematics name them that way, also on the connectors.
Hi Wolfram, On Fri, Apr 1, 2022 at 5:25 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > Unless you have a good reason to keep them, I'd rather remove them > > everywhere. > > Would you agree to move them to salvator-common.dtsi then? The > schematics name them that way, also on the connectors. That might be a good compromise... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r8a77961.dtsi b/arch/arm64/boot/dts/renesas/r8a77961.dtsi index 87bb903954ed..91ccd3dfd526 100644 --- a/arch/arm64/boot/dts/renesas/r8a77961.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77961.dtsi @@ -16,6 +16,17 @@ / { #address-cells = <2>; #size-cells = <2>; + aliases { + i2c0 = &i2c0; + i2c1 = &i2c1; + i2c2 = &i2c2; + i2c3 = &i2c3; + i2c4 = &i2c4; + i2c5 = &i2c5; + i2c6 = &i2c6; + i2c7 = &i2c_dvfs; + }; + /* * The external audio clocks are configured as 0 Hz fixed frequency * clocks by default.