| Message ID | 20220331214526.95529-2-alan.adamson@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [blktests] nvme tests should use nvme_trtype when setting up passthru target | expand |
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
(+Logan) On 3/31/22 14:45, Alan Adamson wrote: > No matter what was passed in with nvme_trtype, the target was being > set up with trtype as "loop". This caused several passthru tests > to fail when testing tcp or rdma. > > Signed-off-by: Alan Adamson <alan.adamson@oracle.com> > --- Thanks for your fix, looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck
> On Mar 31, 2022, at 2:45 PM, Alan Adamson <ALAN.ADAMSON@ORACLE.COM> wrote: > > No matter what was passed in with nvme_trtype, the target was being > set up with trtype as "loop". This caused several passthru tests > to fail when testing tcp or rdma. > > Signed-off-by: Alan Adamson <alan.adamson@oracle.com> > --- > tests/nvme/rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/nvme/rc b/tests/nvme/rc > index 1c27cdee1b5f..3c38408a0bfe 100644 > --- a/tests/nvme/rc > +++ b/tests/nvme/rc > @@ -335,7 +335,7 @@ _nvmet_passthru_target_setup() { > local subsys_name=$1 > > _create_nvmet_passthru "${subsys_name}" > - port="$(_create_nvmet_port "loop")" > + port="$(_create_nvmet_port "${nvme_trtype}")" > _add_nvmet_subsys_to_port "${port}" "${subsys_name}" > > echo "$port" > -- > 2.27.0 > Looks Good Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> -- Himanshu Madhani Oracle Linux Engineering
On Thu, Mar 31, 2022 at 02:45:26PM -0700, Alan Adamson wrote: > No matter what was passed in with nvme_trtype, the target was being > set up with trtype as "loop". This caused several passthru tests > to fail when testing tcp or rdma. > > Signed-off-by: Alan Adamson <alan.adamson@oracle.com> > --- > tests/nvme/rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks.
diff --git a/tests/nvme/rc b/tests/nvme/rc index 1c27cdee1b5f..3c38408a0bfe 100644 --- a/tests/nvme/rc +++ b/tests/nvme/rc @@ -335,7 +335,7 @@ _nvmet_passthru_target_setup() { local subsys_name=$1 _create_nvmet_passthru "${subsys_name}" - port="$(_create_nvmet_port "loop")" + port="$(_create_nvmet_port "${nvme_trtype}")" _add_nvmet_subsys_to_port "${port}" "${subsys_name}" echo "$port"
No matter what was passed in with nvme_trtype, the target was being set up with trtype as "loop". This caused several passthru tests to fail when testing tcp or rdma. Signed-off-by: Alan Adamson <alan.adamson@oracle.com> --- tests/nvme/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)