| Message ID | 20220402051206.6115-6-singh.kuldeep87k@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/5] dt-bindings: i2c: Add Qualcomm Geni based QUP i2c bindings | expand |
On 02/04/2022 07:12, Kuldeep Singh wrote: > Now that Geni serial engine controllers(spi, i2c and uart) have their > own individual bindings, it's time to remove all common properties of > the controllers from parent schema. > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > --- > .../bindings/soc/qcom/qcom,geni-se.yaml | 33 ------------------- > 1 file changed, 33 deletions(-) > This should be squashed with your previous commit, because removal of last direct child schema, makes the common parts obsolete. IOW, the common parts are only because there is children are open-coded here. Best regards, Krzysztof
On Sat, Apr 02, 2022 at 05:41:57PM +0200, Krzysztof Kozlowski wrote: > On 02/04/2022 07:12, Kuldeep Singh wrote: > > Now that Geni serial engine controllers(spi, i2c and uart) have their > > own individual bindings, it's time to remove all common properties of > > the controllers from parent schema. > > > > Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> > > --- > > .../bindings/soc/qcom/qcom,geni-se.yaml | 33 ------------------- > > 1 file changed, 33 deletions(-) > > > > This should be squashed with your previous commit, because removal of > last direct child schema, makes the common parts obsolete. IOW, the > common parts are only because there is children are open-coded here. Initially I thought the same, but then this patch will do more than what commit description says, that's why I kept separate patch. Nevermind, I will squash it with previous one. -Kuldeep
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml index 9f72c676b22c..c8e1a4a87ba8 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml @@ -64,39 +64,6 @@ required: - ranges patternProperties: - "^.*@[0-9a-f]+$": - type: object - description: Common properties for GENI Serial Engine based I2C, SPI and - UART controller. - - properties: - reg: - description: GENI Serial Engine register address and length. - maxItems: 1 - - clock-names: - const: se - - clocks: - description: Serial engine core clock needed by the device. - maxItems: 1 - - interconnects: - minItems: 2 - maxItems: 3 - - interconnect-names: - minItems: 2 - items: - - const: qup-core - - const: qup-config - - const: qup-memory - - required: - - reg - - clock-names - - clocks - "spi@[0-9a-f]+$": type: object description: GENI serial engine based SPI controller. SPI in master mode
Now that Geni serial engine controllers(spi, i2c and uart) have their own individual bindings, it's time to remove all common properties of the controllers from parent schema. Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com> --- .../bindings/soc/qcom/qcom,geni-se.yaml | 33 ------------------- 1 file changed, 33 deletions(-)