| Message ID | 20220401163755.302548-1-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RFC,1/3] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory | expand |
On Fri, Apr 1, 2022 at 11:38 AM Marek Vasut <marex@denx.de> wrote: > > Make the width-mm/height-mm panel properties mandatory > to correctly report the panel dimensions to the OS. Adding required properties is an ABI break. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Dmitry Osipenko <digetx@gmail.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Noralf Trønnes <noralf@tronnes.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Robert Foss <robert.foss@linaro.org> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: devicetree@vger.kernel.org > To: dri-devel@lists.freedesktop.org > --- > .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > index f29789994b18..c2df8d28aaf5 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > @@ -83,6 +83,8 @@ properties: > required: > - compatible > - reg > + - width-mm > + - height-mm > - panel-timing > > unevaluatedProperties: false > -- > 2.35.1 >
On Fri, Apr 01, 2022 at 01:36:53PM -0500, Rob Herring wrote: > On Fri, Apr 1, 2022 at 11:38 AM Marek Vasut <marex@denx.de> wrote: > > > > Make the width-mm/height-mm panel properties mandatory > > to correctly report the panel dimensions to the OS. > > Adding required properties is an ABI break. Only if drivers don't provide backward compatibility. There's still the issue of validation warnings of course. We can ensure that DT sources in the kernel are updated. For out-of-tree DT, I'll argue that a validation warning is a good thing, it will notify that an update is needed. > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Cc: Dmitry Osipenko <digetx@gmail.com> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Cc: Noralf Trønnes <noralf@tronnes.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Robert Foss <robert.foss@linaro.org> > > Cc: Sam Ravnborg <sam@ravnborg.org> > > Cc: Thomas Zimmermann <tzimmermann@suse.de> > > Cc: devicetree@vger.kernel.org > > To: dri-devel@lists.freedesktop.org > > --- > > .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > > index f29789994b18..c2df8d28aaf5 100644 > > --- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > > @@ -83,6 +83,8 @@ properties: > > required: > > - compatible > > - reg > > + - width-mm > > + - height-mm > > - panel-timing > > > > unevaluatedProperties: false
On 4/1/22 20:36, Rob Herring wrote: > On Fri, Apr 1, 2022 at 11:38 AM Marek Vasut <marex@denx.de> wrote: >> >> Make the width-mm/height-mm panel properties mandatory >> to correctly report the panel dimensions to the OS. > > Adding required properties is an ABI break. Per discussion with Noralf in 2/3, these bindings entered in 5.18 merge window, so maybe there is still chance to fix them before rc1/rc2 ? I.e. they were not shipped in any kernel release yet.
diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml index f29789994b18..c2df8d28aaf5 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml @@ -83,6 +83,8 @@ properties: required: - compatible - reg + - width-mm + - height-mm - panel-timing unevaluatedProperties: false
Make the width-mm/height-mm panel properties mandatory to correctly report the panel dimensions to the OS. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Dmitry Osipenko <digetx@gmail.com> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Noralf Trønnes <noralf@tronnes.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Robert Foss <robert.foss@linaro.org> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: devicetree@vger.kernel.org To: dri-devel@lists.freedesktop.org --- .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml | 2 ++ 1 file changed, 2 insertions(+)