| Message ID | 20220331140949.1410056-1-nborisov@suse.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e299bcd4d16ff86f46c48df1062c8aae0eca1ed8 |
| Delegated to: | BPF |
| Headers | show |
| Series | selftest/bpf: Fix vfs_link kprobe definition | expand |
| Context | Check | Description |
|---|---|---|
| bpf/vmtest-bpf-next-PR | success | PR summary |
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <andrii@kernel.org>: On Thu, 31 Mar 2022 17:09:49 +0300 you wrote: > Since commit 6521f8917082 ("namei: prepare for idmapped mounts") > vfs_link's prototype was changed, the kprobe definition in > profiler selftest in turn wasn't updated. The result is that all > argument after the first are now stored in different registers. This > means that self-test has been broken ever since. Fix it by updating the > kprobe definition accordingly. > > [...] Here is the summary with links: - selftest/bpf: Fix vfs_link kprobe definition https://git.kernel.org/bpf/bpf-next/c/e299bcd4d16f You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/progs/profiler.inc.h b/tools/testing/selftests/bpf/progs/profiler.inc.h index 4896fdf816f7..92331053dba3 100644 --- a/tools/testing/selftests/bpf/progs/profiler.inc.h +++ b/tools/testing/selftests/bpf/progs/profiler.inc.h @@ -826,8 +826,9 @@ int kprobe_ret__do_filp_open(struct pt_regs* ctx) SEC("kprobe/vfs_link") int BPF_KPROBE(kprobe__vfs_link, - struct dentry* old_dentry, struct inode* dir, - struct dentry* new_dentry, struct inode** delegated_inode) + struct dentry* old_dentry, struct user_namespace *mnt_userns, + struct inode* dir, struct dentry* new_dentry, + struct inode** delegated_inode) { struct bpf_func_stats_ctx stats_ctx; bpf_stats_enter(&stats_ctx, profiler_bpf_vfs_link);
Since commit 6521f8917082 ("namei: prepare for idmapped mounts") vfs_link's prototype was changed, the kprobe definition in profiler selftest in turn wasn't updated. The result is that all argument after the first are now stored in different registers. This means that self-test has been broken ever since. Fix it by updating the kprobe definition accordingly. Signed-off-by: Nikolay Borisov <nborisov@suse.com> --- tools/testing/selftests/bpf/progs/profiler.inc.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)