| Message ID | 7b345a16-60bd-001f-edec-724ca2b3c47a@semihalf.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Jiri Kosina |
| Headers | show |
| Series | HID: multitouch: Add support for Google Whiskers Touchpad | expand |
Hi Marek, On Mon, Apr 4, 2022 at 10:22 PM Marek Maślanka <mm@semihalf.com> wrote: > > The Google Whiskers touchpad does not work properly with the default > multitouch configuration. Instead, use the same configuration as Google > Rose. > > Signed-off-by: Marek Maslanka <mm@semihalf.com> > --- > drivers/hid/hid-multitouch.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 99eabfb4145b..bda79197273b 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -2178,6 +2178,9 @@ static const struct hid_device_id mt_devices[] = { > { .driver_data = MT_CLS_GOOGLE, > HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY, USB_VENDOR_ID_GOOGLE, > USB_DEVICE_ID_GOOGLE_TOUCH_ROSE) }, > + { .driver_data = MT_CLS_GOOGLE, > + HID_USB_DEVICE(USB_VENDOR_ID_GOOGLE, > + USB_DEVICE_ID_GOOGLE_WHISKERS) }, You probably want to restrict the group to only multitouch devices. This device is already handled through hid-google-hammer.c, and adding this line will make both drivers fight for the resource. The hid-google-hammer.c line is only for HID_GROUP_GENERIC, so you should be able to add something along HID_GROUP_MULTITOUCH_WIN_8 or use MT_USB_DEVICE() if it's not declared as Win8 compatible. Cheers, Benjamin > > /* Generic MT device */ > { HID_DEVICE(HID_BUS_ANY, HID_GROUP_MULTITOUCH, HID_ANY_ID, > HID_ANY_ID) }, > -- > 2.32.0 >
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 99eabfb4145b..bda79197273b 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -2178,6 +2178,9 @@ static const struct hid_device_id mt_devices[] = { { .driver_data = MT_CLS_GOOGLE, HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY, USB_VENDOR_ID_GOOGLE, USB_DEVICE_ID_GOOGLE_TOUCH_ROSE) }, + { .driver_data = MT_CLS_GOOGLE, + HID_USB_DEVICE(USB_VENDOR_ID_GOOGLE, + USB_DEVICE_ID_GOOGLE_WHISKERS) }, /* Generic MT device */ { HID_DEVICE(HID_BUS_ANY, HID_GROUP_MULTITOUCH, HID_ANY_ID,
The Google Whiskers touchpad does not work properly with the default multitouch configuration. Instead, use the same configuration as Google Rose. Signed-off-by: Marek Maslanka <mm@semihalf.com> --- drivers/hid/hid-multitouch.c | 3 +++ 1 file changed, 3 insertions(+) HID_ANY_ID) },