| Message ID | 5eaae8e215d84dd3a4f7e09782478a29@hyperstone.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] mmc: mmc_spi: parse speed mode options | expand |
On Thu, Mar 31, 2022 at 07:29:37AM +0000, Christian Löhle wrote: > Any setup supporting more than 25MHz is able to utilize > highspeed, so enable it even when not explicitly specified. I'm not sure about this. I prefer to be on the safer side, i.e. follow only what is supplied by firmware (ACPI / DT).
Understood and sure, then I'll take 2/2 back. @Ulf, would you like a v2 just containing 1/2 or is it fine like this? From: andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> Sent: Thursday, March 31, 2022 4:07 PM To: Christian Löhle Cc: Ulf Hansson; linux-kernel@vger.kernel.org; linux-mmc@vger.kernel.org; adrian.hunter@intel.com; digetx@gmail.com; avri.altman@wdc.com Subject: Re: [PATCH 2/2] mmc: mmc_spi: enable Highspeed for above 25MHz On Thu, Mar 31, 2022 at 07:29:37AM +0000, Christian Löhle wrote: > Any setup supporting more than 25MHz is able to utilize > highspeed, so enable it even when not explicitly specified. I'm not sure about this. I prefer to be on the safer side, i.e. follow only what is supplied by firmware (ACPI / DT).
On Tue, 5 Apr 2022 at 11:20, Christian Löhle <CLoehle@hyperstone.com> wrote: > > Understood and sure, then I'll take 2/2 back. > @Ulf, would you like a v2 just containing 1/2 or is it fine like this? It's fine as is, I will pick up patch1 very soon. Kind regards Uffe > > > > > From: andriy.shevchenko@linux.intel.com <andriy.shevchenko@linux.intel.com> > Sent: Thursday, March 31, 2022 4:07 PM > To: Christian Löhle > Cc: Ulf Hansson; linux-kernel@vger.kernel.org; linux-mmc@vger.kernel.org; adrian.hunter@intel.com; digetx@gmail.com; avri.altman@wdc.com > Subject: Re: [PATCH 2/2] mmc: mmc_spi: enable Highspeed for above 25MHz > > On Thu, Mar 31, 2022 at 07:29:37AM +0000, Christian Löhle wrote: > > Any setup supporting more than 25MHz is able to utilize > > highspeed, so enable it even when not explicitly specified. > > I'm not sure about this. I prefer to be on the safer side, i.e. > follow only what is supplied by firmware (ACPI / DT). > > -- > With Best Regards, > Andy Shevchenko > > > = > Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz > Managing Director: Dr. Jan Peter Berns. > Commercial register of local courts: Freiburg HRB381782 >
diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c index 106dd204b1a7..0a74c2f55542 100644 --- a/drivers/mmc/host/mmc_spi.c +++ b/drivers/mmc/host/mmc_spi.c @@ -1378,6 +1378,9 @@ static int mmc_spi_probe(struct spi_device *spi) mmc->f_min = 400000; mmc->f_max = spi->max_speed_hz; + if (mmc->f_max > 25000000) + mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; + host = mmc_priv(mmc); host->mmc = mmc; host->spi = spi;
Any setup supporting more than 25MHz is able to utilize highspeed, so enable it even when not explicitly specified. Signed-off-by: Christian Loehle <cloehle@hyperstone.com> --- drivers/mmc/host/mmc_spi.c | 3 +++ 1 file changed, 3 insertions(+)