diff mbox series

[v6,1/1] Split i915_run_as_guest into x86 and non-x86

Message ID 20220331204343.1256150-2-casey.g.bowman@intel.com (mailing list archive)
State New, archived
Headers show
Series Splitting up platform-specific calls | expand

Commit Message

Bowman, Casey G March 31, 2022, 8:43 p.m. UTC 
Splitting i915_run_as_guest into a more arch-friendly function
as non-x86 builds do not support this functionality.

Signed-off-by: Casey Bowman <casey.g.bowman@intel.com>
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
 drivers/gpu/drm/i915/i915_utils.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Bowman, Casey G April 5, 2022, 6:04 p.m. UTC | #1 
@Jani/Lucas, any other thoughts here?

Regards,
Casey

On 3/31/22 13:43, Casey Bowman wrote:
> Splitting i915_run_as_guest into a more arch-friendly function
> as non-x86 builds do not support this functionality.
>
> Signed-off-by: Casey Bowman <casey.g.bowman@intel.com>
> Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_utils.h | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
> index b2d89c43f24d..ea7648e3aa0e 100644
> --- a/drivers/gpu/drm/i915/i915_utils.h
> +++ b/drivers/gpu/drm/i915/i915_utils.h
> @@ -32,7 +32,10 @@
>   #include <linux/types.h>
>   #include <linux/workqueue.h>
>   #include <linux/sched/clock.h>
> +
> +#ifdef CONFIG_X86
>   #include <asm/hypervisor.h>
> +#endif
>   
>   struct drm_i915_private;
>   struct timer_list;
> @@ -428,7 +431,12 @@ static inline bool timer_expired(const struct timer_list *t)
>   
>   static inline bool i915_run_as_guest(void)
>   {
> +#if IS_ENABLED(CONFIG_X86)
>   	return !hypervisor_is_type(X86_HYPER_NATIVE);
> +#else
> +	/* Not supported yet */
> +	return false;
> +#endif
>   }
>   
>   bool i915_vtd_active(struct drm_i915_private *i915);
Lucas De Marchi April 5, 2022, 8:06 p.m. UTC | #2 
On Tue, Apr 05, 2022 at 11:04:54AM -0700, Casey Bowman wrote:
>@Jani/Lucas, any other thoughts here?

last version didn't pass CI:

https://patchwork.freedesktop.org/series/102041/

when this happens, developer should analyze the results to check if it's
a regression from their changes. When it's not a regression we can merge
it, but in this case it didn't pass BAT, so there wasn't even a full
run.

Lucas De Marchi
Lucas De Marchi April 6, 2022, 4:24 p.m. UTC | #3 
On Thu, Mar 31, 2022 at 01:43:43PM -0700, Casey Bowman wrote:
>Splitting i915_run_as_guest into a more arch-friendly function
>as non-x86 builds do not support this functionality.
>
>Signed-off-by: Casey Bowman <casey.g.bowman@intel.com>
>Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

now we have CI results and they look ok. I reworded the commit message
to use imperative sentence and added the required "drm/i915: " prefix.

pushed to drm-intel-next.

thanks
Lucas De Marchi
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
index b2d89c43f24d..ea7648e3aa0e 100644
--- a/drivers/gpu/drm/i915/i915_utils.h
+++ b/drivers/gpu/drm/i915/i915_utils.h
@@ -32,7 +32,10 @@ 
 #include <linux/types.h>
 #include <linux/workqueue.h>
 #include <linux/sched/clock.h>
+
+#ifdef CONFIG_X86
 #include <asm/hypervisor.h>
+#endif
 
 struct drm_i915_private;
 struct timer_list;
@@ -428,7 +431,12 @@  static inline bool timer_expired(const struct timer_list *t)
 
 static inline bool i915_run_as_guest(void)
 {
+#if IS_ENABLED(CONFIG_X86)
 	return !hypervisor_is_type(X86_HYPER_NATIVE);
+#else
+	/* Not supported yet */
+	return false;
+#endif
 }
 
 bool i915_vtd_active(struct drm_i915_private *i915);