| Message ID | 20220216074927.3619425-10-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 1c6add99c2bf1b19175e80826534b025c967afdd |
| Headers | show |
| Series | document dt-schema and fix node names for some USB Ethernet controllers | expand |
+ Frieder Schrempf who is the board owner. On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote: > The node name of Ethernet controller should be "ethernet" instead of > "usbether" as required by Ethernet controller devicetree schema: > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > This patch can potentially affect boot loaders patching against full > node path instead of using device aliases. Frieder, Are you okay with that? Shawn > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > index d40caf14ac4a..23be1ec538ba 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts > @@ -182,7 +182,7 @@ usb1@1 { > #address-cells = <1>; > #size-cells = <0>; > > - usbnet: usbether@1 { > + usbnet: ethernet@1 { > compatible = "usb424,ec00"; > reg = <1>; > local-mac-address = [ 00 00 00 00 00 00 ]; > -- > 2.30.2 >
Am 06.04.22 um 03:13 schrieb Shawn Guo: > + Frieder Schrempf who is the board owner. > > On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote: >> The node name of Ethernet controller should be "ethernet" instead of >> "usbether" as required by Ethernet controller devicetree schema: >> Documentation/devicetree/bindings/net/ethernet-controller.yaml >> >> This patch can potentially affect boot loaders patching against full >> node path instead of using device aliases. > > Frieder, > > Are you okay with that? Yes! > > Shawn > >> >> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Acked-by: Frieder Schrempf <frieder.schrempf@kontron.de> >> --- >> arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> index d40caf14ac4a..23be1ec538ba 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts >> @@ -182,7 +182,7 @@ usb1@1 { >> #address-cells = <1>; >> #size-cells = <0>; >> >> - usbnet: usbether@1 { >> + usbnet: ethernet@1 { >> compatible = "usb424,ec00"; >> reg = <1>; >> local-mac-address = [ 00 00 00 00 00 00 ]; >> -- >> 2.30.2 >>
On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote: > The node name of Ethernet controller should be "ethernet" instead of > "usbether" as required by Ethernet controller devicetree schema: > Documentation/devicetree/bindings/net/ethernet-controller.yaml > > This patch can potentially affect boot loaders patching against full > node path instead of using device aliases. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Applied, thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts index d40caf14ac4a..23be1ec538ba 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts @@ -182,7 +182,7 @@ usb1@1 { #address-cells = <1>; #size-cells = <0>; - usbnet: usbether@1 { + usbnet: ethernet@1 { compatible = "usb424,ec00"; reg = <1>; local-mac-address = [ 00 00 00 00 00 00 ];
The node name of Ethernet controller should be "ethernet" instead of "usbether" as required by Ethernet controller devicetree schema: Documentation/devicetree/bindings/net/ethernet-controller.yaml This patch can potentially affect boot loaders patching against full node path instead of using device aliases. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)