| Message ID | 51953618-79b6-0df7-2d28-d5dce4dc86c7@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: meson: aiu: fix duplicate debugfs directory error | expand |
On 09.03.2022 21:20, Heiner Kallweit wrote: > On a S905W-based system I get the following error: > debugfs: Directory 'c1105400.audio-controller' with parent 'P230-Q200' already present! > > Turned out that multiple components having the same name triggers this > error in soc_init_component_debugfs(). The proposed solution allows > other drivers to adopt the same approach with minimal effort. > With the patch the error is gone and that's the debugfs entries. > > /sys/kernel/debug/asoc/P230-Q200/acodec:c1105400.audio-controller > /sys/kernel/debug/asoc/P230-Q200/hdmi:c1105400.audio-controller > /sys/kernel/debug/asoc/P230-Q200/cpu:c1105400.audio-controller > > v2: > - Reworked approach based on [0] > > [0] https://www.spinics.net/lists/arm-kernel/msg960881.html > > Heiner Kallweit (2): > ASoC: soc-core: add debugfs_prefix member to snd_soc_component_driver > ASoC: meson: aiu: fix duplicate debugfs directory error > > include/sound/soc-component.h | 4 ++++ > sound/soc/meson/aiu-acodec-ctrl.c | 3 +++ > sound/soc/meson/aiu-codec-ctrl.c | 3 +++ > sound/soc/meson/aiu.c | 3 +++ > sound/soc/soc-core.c | 5 +++++ > 5 files changed, 18 insertions(+) > Any feedback here?
On Thu, Mar 31, 2022 at 07:56:03AM +0200, Heiner Kallweit wrote:
> Any feedback here?
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.
On Wed, 9 Mar 2022 21:20:01 +0100, Heiner Kallweit wrote: > On a S905W-based system I get the following error: > debugfs: Directory 'c1105400.audio-controller' with parent 'P230-Q200' already present! > > Turned out that multiple components having the same name triggers this > error in soc_init_component_debugfs(). The proposed solution allows > other drivers to adopt the same approach with minimal effort. > With the patch the error is gone and that's the debugfs entries. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: soc-core: add debugfs_prefix member to snd_soc_component_driver commit: d462f6ed2aeac30c0b440a91fb05d964956935f9 [2/2] ASoC: meson: aiu: fix duplicate debugfs directory error commit: 89bac792faf03fae5a9564bebfaacab53a029932 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark