| Message ID | 20220406172956.3953-1-wens@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/ssd130x: Add support for SINO WEALTH SH1106 | expand |
Hello Chen-Yu, On Wed, Apr 6, 2022 at 7:30 PM Chen-Yu Tsai <wens@kernel.org> wrote: > > From: Chen-Yu Tsai <wens@csie.org> > > Hi everyone, > > This series adds support for SH1106 to the ssd130x OLED display > driver. > Thanks for re-spinning your series. I believe that gave you my Acked-by for most of the patches in v1 already? But it seems you didn't pick them up. You addressed the comments I had in v1 so those stand, for all patches: Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Best regards, Javier
On 4/6/22 19:29, Chen-Yu Tsai wrote: Pushed this series to drm-misc (drm-misc-next), thanks again for your patches!
From: Chen-Yu Tsai <wens@csie.org> Hi everyone, This series adds support for SH1106 to the ssd130x OLED display driver. Changes since v1: - Fixed ordering of SINO WEALTH in vendor prefix list - Updated allOf:if: blocks in DT binding, i.e. added default values for solomon,dclk-{div,frq} - Added SSD130X_PAGE_COL_START_{HIGH,LOW}_SET and used that to set the bitfields for the two commands. I didn't feel SSD130X_PAGE_COL_START_{HIGH,LOW}_MASK was needed, as it was the same between both commands. - Added SH110x to the SSD130X Kconfig help texts There are SH110[789] as well, but they don't seem to be easy to find. The SINO WEALTH SH1106 is an OLED display driver that is somewhat compatible with the SSD1306. It supports a slightly wider display, at 132 instead of 128 pixels. The basic commands are the same, but the SH1106 doesn't support the horizontal or vertical address modes. This driver chip is found in some cheap 1.3" OLED panel modules. It acts as a substitute for the SSD1306. Patch 1 adds an entry to the vendor prefixes for SINO WEALTH Eletronics Ltd. Patch 2 adds an entry for SH1106 to the ssd1307fb binding. Patch 3 adds support for the base "page addressing mode" to the ssd130x driver. Patch 4 adds support for the SH1106 to the ssd130x driver. Please have a look. Thanks ChenYu Chen-Yu Tsai (4): dt-bindings: vendor-prefixes: Add prefix for SINO WEALTH Eletronics Ltd. dt-bindings: display: ssd1307fb: Add entry for SINO WEALTH SH1106 drm/ssd130x: Support page addressing mode drm/ssd130x: Add support for SINO WEALTH SH1106 .../bindings/display/solomon,ssd1307fb.yaml | 13 ++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + drivers/gpu/drm/solomon/Kconfig | 9 ++- drivers/gpu/drm/solomon/ssd130x-i2c.c | 11 +++ drivers/gpu/drm/solomon/ssd130x.c | 73 +++++++++++++++++-- drivers/gpu/drm/solomon/ssd130x.h | 2 + 6 files changed, 99 insertions(+), 11 deletions(-)