| Message ID | 20220407072442.4137977-1-wanjiabing@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | scsi: megaraid_sas: remove unnecessary memset | expand |
On Thu, Apr 7, 2022 at 12:55 PM Wan Jiabing <wanjiabing@vivo.com> wrote: > > instance->cmd_list is allocated by kcalloc(). The memory is set to zero. > It is unnecessary to call memset again. > > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> Thank you. Acked-by: Sumit Saxena <sumit.saxena@broadcom.com> > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c > index 8bf72dbc33b7..33f3226023f3 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -4466,8 +4466,6 @@ int megasas_alloc_cmds(struct megasas_instance *instance) > return -ENOMEM; > } > > - memset(instance->cmd_list, 0, sizeof(struct megasas_cmd *) *max_cmd); > - > for (i = 0; i < max_cmd; i++) { > instance->cmd_list[i] = kmalloc(sizeof(struct megasas_cmd), > GFP_KERNEL); > -- > 2.35.1 >
Wan, > instance->cmd_list is allocated by kcalloc(). The memory is set to > zero. It is unnecessary to call memset again. Applied to 5.19/scsi-staging, thanks!
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 8bf72dbc33b7..33f3226023f3 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -4466,8 +4466,6 @@ int megasas_alloc_cmds(struct megasas_instance *instance) return -ENOMEM; } - memset(instance->cmd_list, 0, sizeof(struct megasas_cmd *) *max_cmd); - for (i = 0; i < max_cmd; i++) { instance->cmd_list[i] = kmalloc(sizeof(struct megasas_cmd), GFP_KERNEL);
instance->cmd_list is allocated by kcalloc(). The memory is set to zero. It is unnecessary to call memset again. Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 -- 1 file changed, 2 deletions(-)