| Message ID | Yk3leykDEKGBN8rk@robh.at.kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0dc23d1a8e17839f1c071302b5f3e04a34692d44 |
| Headers | show |
| Series | [RESEND] arm: dts: at91: Fix boolean properties with values | expand |
On 06.04.2022 22:09, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Boolean properties in DT are present or not present and don't take a value. > A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't > matter. > > It may have been intended that 0 values are false, but there is no change > in behavior with this patch. > > Signed-off-by: Rob Herring <robh@kernel.org> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> > --- > Can someone apply this for 5.18 please. > > arch/arm/boot/dts/at91-kizbox3-hs.dts | 2 +- > arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/at91-kizbox3-hs.dts b/arch/arm/boot/dts/at91-kizbox3-hs.dts > index 2799b2a1f4d2..f7d90cf1bb77 100644 > --- a/arch/arm/boot/dts/at91-kizbox3-hs.dts > +++ b/arch/arm/boot/dts/at91-kizbox3-hs.dts > @@ -225,7 +225,7 @@ pinctrl_pio_zbe_rst: gpio_zbe_rst { > pinctrl_pio_io_reset: gpio_io_reset { > pinmux = <PIN_PB30__GPIO>; > bias-disable; > - drive-open-drain = <1>; > + drive-open-drain; > output-low; > }; > pinctrl_pio_input: gpio_input { > diff --git a/arch/arm/boot/dts/at91-kizbox3_common.dtsi b/arch/arm/boot/dts/at91-kizbox3_common.dtsi > index abe27adfa4d6..465664628419 100644 > --- a/arch/arm/boot/dts/at91-kizbox3_common.dtsi > +++ b/arch/arm/boot/dts/at91-kizbox3_common.dtsi > @@ -211,7 +211,7 @@ pinctrl_flx4_default: flx4_i2c6_default { > pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA > <PIN_PD13__FLEXCOM4_IO1>; //CLK > bias-disable; > - drive-open-drain = <1>; > + drive-open-drain; > }; > > pinctrl_pwm0 { > -- > 2.32.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hello: This patch was applied to soc/soc.git (arm/fixes) by Arnd Bergmann <arnd@arndb.de>: On Wed, 6 Apr 2022 14:09:47 -0500 you wrote: > Boolean properties in DT are present or not present and don't take a value. > A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't > matter. > > It may have been intended that 0 values are false, but there is no change > in behavior with this patch. > > [...] Here is the summary with links: - [RESEND] arm: dts: at91: Fix boolean properties with values https://git.kernel.org/soc/soc/c/0dc23d1a8e17 You are awesome, thank you!
On 06/04/2022 at 21:09, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Boolean properties in DT are present or not present and don't take a value. > A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't > matter. > > It may have been intended that 0 values are false, but there is no change > in behavior with this patch. > > Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > Can someone apply this for 5.18 please. Yes, sure, it's now queued in the fixes branch for 5.18. Thanks for your help Rob. Best regards, Nicolas > > arch/arm/boot/dts/at91-kizbox3-hs.dts | 2 +- > arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/at91-kizbox3-hs.dts b/arch/arm/boot/dts/at91-kizbox3-hs.dts > index 2799b2a1f4d2..f7d90cf1bb77 100644 > --- a/arch/arm/boot/dts/at91-kizbox3-hs.dts > +++ b/arch/arm/boot/dts/at91-kizbox3-hs.dts > @@ -225,7 +225,7 @@ pinctrl_pio_zbe_rst: gpio_zbe_rst { > pinctrl_pio_io_reset: gpio_io_reset { > pinmux = <PIN_PB30__GPIO>; > bias-disable; > - drive-open-drain = <1>; > + drive-open-drain; > output-low; > }; > pinctrl_pio_input: gpio_input { > diff --git a/arch/arm/boot/dts/at91-kizbox3_common.dtsi b/arch/arm/boot/dts/at91-kizbox3_common.dtsi > index abe27adfa4d6..465664628419 100644 > --- a/arch/arm/boot/dts/at91-kizbox3_common.dtsi > +++ b/arch/arm/boot/dts/at91-kizbox3_common.dtsi > @@ -211,7 +211,7 @@ pinctrl_flx4_default: flx4_i2c6_default { > pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA > <PIN_PD13__FLEXCOM4_IO1>; //CLK > bias-disable; > - drive-open-drain = <1>; > + drive-open-drain; > }; > > pinctrl_pwm0 { > -- > 2.32.0 >
diff --git a/arch/arm/boot/dts/at91-kizbox3-hs.dts b/arch/arm/boot/dts/at91-kizbox3-hs.dts index 2799b2a1f4d2..f7d90cf1bb77 100644 --- a/arch/arm/boot/dts/at91-kizbox3-hs.dts +++ b/arch/arm/boot/dts/at91-kizbox3-hs.dts @@ -225,7 +225,7 @@ pinctrl_pio_zbe_rst: gpio_zbe_rst { pinctrl_pio_io_reset: gpio_io_reset { pinmux = <PIN_PB30__GPIO>; bias-disable; - drive-open-drain = <1>; + drive-open-drain; output-low; }; pinctrl_pio_input: gpio_input { diff --git a/arch/arm/boot/dts/at91-kizbox3_common.dtsi b/arch/arm/boot/dts/at91-kizbox3_common.dtsi index abe27adfa4d6..465664628419 100644 --- a/arch/arm/boot/dts/at91-kizbox3_common.dtsi +++ b/arch/arm/boot/dts/at91-kizbox3_common.dtsi @@ -211,7 +211,7 @@ pinctrl_flx4_default: flx4_i2c6_default { pinmux = <PIN_PD12__FLEXCOM4_IO0>, //DATA <PIN_PD13__FLEXCOM4_IO1>; //CLK bias-disable; - drive-open-drain = <1>; + drive-open-drain; }; pinctrl_pwm0 {
Boolean properties in DT are present or not present and don't take a value. A property such as 'foo = <0>;' evaluated to true. IOW, the value doesn't matter. It may have been intended that 0 values are false, but there is no change in behavior with this patch. Signed-off-by: Rob Herring <robh@kernel.org> --- Can someone apply this for 5.18 please. arch/arm/boot/dts/at91-kizbox3-hs.dts | 2 +- arch/arm/boot/dts/at91-kizbox3_common.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)