| Message ID | 00ec9d965cac78b252e14444deed8c93f5116bca.1649443080.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | MIPS: DTS: fix some findings by "make ci20_defconfig dt_binding_check dtbs_check" | expand |
On 08/04/2022 20:37, H. Nikolaus Schaller wrote: > arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dmas' is a required property > From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dma-names' is a required property > From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dmas' is a required property > From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dma-names' is a required property > From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dmas' is a required property > From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dma-names' is a required property > From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dmas' is a required property > From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dma-names' is a required property > From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dmas' is a required property > From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dma-names' is a required property > From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml > arch/mips/boot/dts/ingenic/ci20.dtb: i2c@10050000: 'dmas' is a required property All these warnings are the same two warnings... Best regards, Krzysztof
> Am 09.04.2022 um 13:18 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: > > On 08/04/2022 20:37, H. Nikolaus Schaller wrote: >> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dmas' is a required property >> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dma-names' is a required property >> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dmas' is a required property >> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dma-names' is a required property >> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dmas' is a required property >> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dma-names' is a required property >> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dmas' is a required property >> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dma-names' is a required property >> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dmas' is a required property >> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dma-names' is a required property >> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >> arch/mips/boot/dts/ingenic/ci20.dtb: i2c@10050000: 'dmas' is a required property > > All these warnings are the same two warnings... See my earlier explanation that without them you can't verify by just reading commit message and diff that all existing warnings have been addressed.
On 09/04/2022 15:07, H. Nikolaus Schaller wrote: > > >> Am 09.04.2022 um 13:18 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: >> >> On 08/04/2022 20:37, H. Nikolaus Schaller wrote: >>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dmas' is a required property >>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dma-names' is a required property >>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dmas' is a required property >>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dma-names' is a required property >>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dmas' is a required property >>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dma-names' is a required property >>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dmas' is a required property >>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dma-names' is a required property >>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dmas' is a required property >>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dma-names' is a required property >>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>> arch/mips/boot/dts/ingenic/ci20.dtb: i2c@10050000: 'dmas' is a required property >> >> All these warnings are the same two warnings... > > See my earlier explanation that without them you can't verify by just reading commit message > and diff that all existing warnings have been addressed. Which does not make sense and there is no need... Automation does it (see Rob's tools). Don't make human life more difficult... Best regards, Krzysztof
> Am 09.04.2022 um 15:16 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: > > On 09/04/2022 15:07, H. Nikolaus Schaller wrote: >> >> >>> Am 09.04.2022 um 13:18 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: >>> >>> On 08/04/2022 20:37, H. Nikolaus Schaller wrote: >>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dmas' is a required property >>>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dma-names' is a required property >>>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dmas' is a required property >>>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dma-names' is a required property >>>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dmas' is a required property >>>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dma-names' is a required property >>>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dmas' is a required property >>>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dma-names' is a required property >>>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dmas' is a required property >>>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dma-names' is a required property >>>> From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml >>>> arch/mips/boot/dts/ingenic/ci20.dtb: i2c@10050000: 'dmas' is a required property >>> >>> All these warnings are the same two warnings... >> >> See my earlier explanation that without them you can't verify by just reading commit message >> and diff that all existing warnings have been addressed. > > Which does not make sense and there is no need... Automation does it > (see Rob's tools). Don't make human life more difficult... Ok, you are right. If you apply this patch and then run dtbscheck again, there would be a warning left over. But may I honestly ask why you review the commits and read the commit message at all? You could simply ignore it... And it would be easier for both of us to leave it completely to Rob's tools :) BR and thanks, Nikolaus
On 09/04/2022 15:26, H. Nikolaus Schaller wrote: >> >> Which does not make sense and there is no need... Automation does it >> (see Rob's tools). Don't make human life more difficult... > > Ok, you are right. If you apply this patch and then run dtbscheck again, there would be > a warning left over. > > But may I honestly ask why you review the commits and read the commit message at all? > You could simply ignore it... And it would be easier for both of us to leave it completely > to Rob's tools :) > I am not reading it. :) It takes more effort to scroll to the actual contents. Best regards, Krzysztof
> Am 09.04.2022 um 15:28 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: > > On 09/04/2022 15:26, H. Nikolaus Schaller wrote: >>> >>> Which does not make sense and there is no need... Automation does it >>> (see Rob's tools). Don't make human life more difficult... >> >> Ok, you are right. If you apply this patch and then run dtbscheck again, there would be >> a warning left over. >> >> But may I honestly ask why you review the commits and read the commit message at all? >> You could simply ignore it... And it would be easier for both of us to leave it completely >> to Rob's tools :) >> > > I am not reading it. :) It takes more effort to scroll to the actual > contents. Ok, now I got it... Maybe I have a larger screen so that it doesn't even need scrolling and therefore don't notice this difference. So may I leave it as it is since you don't read it anyways :) > > Best regards, > Krzysztof BR and thanks, Nikolaus
diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi index dc88f9e813453..73cd05cf26472 100644 --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi @@ -283,6 +283,10 @@ uart0: serial@10030000 { clocks = <&ext>, <&cgu JZ4780_CLK_UART0>; clock-names = "baud", "module"; + dmas = <&dma JZ4780_DMA_UART0_RX 0xffffffff>, + <&dma JZ4780_DMA_UART0_TX 0xffffffff>; + dma-names = "rx", "tx"; + status = "disabled"; }; @@ -296,6 +300,10 @@ uart1: serial@10031000 { clocks = <&ext>, <&cgu JZ4780_CLK_UART1>; clock-names = "baud", "module"; + dmas = <&dma JZ4780_DMA_UART1_RX 0xffffffff>, + <&dma JZ4780_DMA_UART1_TX 0xffffffff>; + dma-names = "rx", "tx"; + status = "disabled"; }; @@ -309,6 +317,10 @@ uart2: serial@10032000 { clocks = <&ext>, <&cgu JZ4780_CLK_UART2>; clock-names = "baud", "module"; + dmas = <&dma JZ4780_DMA_UART2_RX 0xffffffff>, + <&dma JZ4780_DMA_UART2_TX 0xffffffff>; + dma-names = "rx", "tx"; + status = "disabled"; }; @@ -322,6 +334,10 @@ uart3: serial@10033000 { clocks = <&ext>, <&cgu JZ4780_CLK_UART3>; clock-names = "baud", "module"; + dmas = <&dma JZ4780_DMA_UART3_RX 0xffffffff>, + <&dma JZ4780_DMA_UART3_TX 0xffffffff>; + dma-names = "rx", "tx"; + status = "disabled"; }; @@ -335,6 +351,10 @@ uart4: serial@10034000 { clocks = <&ext>, <&cgu JZ4780_CLK_UART4>; clock-names = "baud", "module"; + dmas = <&dma JZ4780_DMA_UART4_RX 0xffffffff>, + <&dma JZ4780_DMA_UART4_TX 0xffffffff>; + dma-names = "rx", "tx"; + status = "disabled"; };
arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dmas' is a required property From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml arch/mips/boot/dts/ingenic/ci20.dtb: serial@10030000: 'dma-names' is a required property From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dmas' is a required property From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml arch/mips/boot/dts/ingenic/ci20.dtb: serial@10031000: 'dma-names' is a required property From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dmas' is a required property From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml arch/mips/boot/dts/ingenic/ci20.dtb: serial@10032000: 'dma-names' is a required property From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dmas' is a required property From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml arch/mips/boot/dts/ingenic/ci20.dtb: serial@10033000: 'dma-names' is a required property From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dmas' is a required property From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml arch/mips/boot/dts/ingenic/ci20.dtb: serial@10034000: 'dma-names' is a required property From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml arch/mips/boot/dts/ingenic/ci20.dtb: i2c@10050000: 'dmas' is a required property Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- arch/mips/boot/dts/ingenic/jz4780.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)