| Message ID | 20220411144427.874-1-ggiraudon@prism19.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1 | expand |
On 11/04/2022 16:44, Guillaume Giraudon wrote: > The labels for lines 61 through 84 on the periphs-banks were offset by 2. > 2 lines are missing in the BOOT GPIO lines (contains 14, should be 16) > Added 2 empty entries in BOOT to realigned the rest of GPIO labels > to match the Banana Pi M5 schematics. > > (Thanks to Neil Armstrong for the heads up on the position of the missing pins) > > Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts") > > Signed-off-by: Guillaume Giraudon <ggiraudon@prism19.com> > --- > arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > index 5751c48620ed..84489525c75f 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts > @@ -437,6 +437,7 @@ > "", > "eMMC_RST#", /* BOOT_12 */ > "eMMC_DS", /* BOOT_13 */ > + "","", Missing space after first comma, will add while applying. > /* GPIOC */ > "SD_D0_B", /* GPIOC_0 */ > "SD_D1_B", /* GPIOC_1 */ Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Hi, On Mon, 11 Apr 2022 10:44:28 -0400, Guillaume Giraudon wrote: > The labels for lines 61 through 84 on the periphs-banks were offset by 2. > 2 lines are missing in the BOOT GPIO lines (contains 14, should be 16) > Added 2 empty entries in BOOT to realigned the rest of GPIO labels > to match the Banana Pi M5 schematics. > > (Thanks to Neil Armstrong for the heads up on the position of the missing pins) > > [...] Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v5.18/fixes) [1/1] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO pin labeling for CON1 https://git.kernel.org/amlogic/c/962dd65e575dde950ef0844568edc37cfb39f302
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts index 5751c48620ed..84489525c75f 100644 --- a/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts @@ -437,6 +437,7 @@ "", "eMMC_RST#", /* BOOT_12 */ "eMMC_DS", /* BOOT_13 */ + "","", /* GPIOC */ "SD_D0_B", /* GPIOC_0 */ "SD_D1_B", /* GPIOC_1 */
The labels for lines 61 through 84 on the periphs-banks were offset by 2. 2 lines are missing in the BOOT GPIO lines (contains 14, should be 16) Added 2 empty entries in BOOT to realigned the rest of GPIO labels to match the Banana Pi M5 schematics. (Thanks to Neil Armstrong for the heads up on the position of the missing pins) Fixes: 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts") Signed-off-by: Guillaume Giraudon <ggiraudon@prism19.com> --- arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 1 + 1 file changed, 1 insertion(+)