| Message ID | 20220405194747.2386619-2-jane.chu@oracle.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | DAX poison recovery | expand |
On Tue, Apr 5, 2022 at 12:48 PM Jane Chu <jane.chu@oracle.com> wrote: > > There is no _set_memory_prot internal helper, while coming across > the code, might as well fix the comment. Looks good, Reviewed-by: Dan Williams <dan.j.williams@intel.com> > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Jane Chu <jane.chu@oracle.com> > --- > arch/x86/mm/pat/set_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c > index abf5ed76e4b7..38af155aaba9 100644 > --- a/arch/x86/mm/pat/set_memory.c > +++ b/arch/x86/mm/pat/set_memory.c > @@ -1816,7 +1816,7 @@ static inline int cpa_clear_pages_array(struct page **pages, int numpages, > } > > /* > - * _set_memory_prot is an internal helper for callers that have been passed > + * __set_memory_prot is an internal helper for callers that have been passed > * a pgprot_t value from upper layers and a reservation has already been taken. > * If you want to set the pgprot to a specific page protocol, use the > * set_memory_xx() functions. > -- > 2.18.4 >
On Tue, Apr 05, 2022 at 01:47:42PM -0600, Jane Chu wrote: > There is no _set_memory_prot internal helper, while coming across > the code, might as well fix the comment. > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Jane Chu <jane.chu@oracle.com> > --- > arch/x86/mm/pat/set_memory.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c > index abf5ed76e4b7..38af155aaba9 100644 > --- a/arch/x86/mm/pat/set_memory.c > +++ b/arch/x86/mm/pat/set_memory.c > @@ -1816,7 +1816,7 @@ static inline int cpa_clear_pages_array(struct page **pages, int numpages, > } > > /* > - * _set_memory_prot is an internal helper for callers that have been passed > + * __set_memory_prot is an internal helper for callers that have been passed > * a pgprot_t value from upper layers and a reservation has already been taken. > * If you want to set the pgprot to a specific page protocol, use the > * set_memory_xx() functions. > -- This is such a trivial change so that having it as a separate patch is probably not needed - might as well merge it with patch 3... Thx.
On 4/12/2022 2:53 AM, Borislav Petkov wrote: > On Tue, Apr 05, 2022 at 01:47:42PM -0600, Jane Chu wrote: >> There is no _set_memory_prot internal helper, while coming across >> the code, might as well fix the comment. >> >> Reviewed-by: Christoph Hellwig <hch@lst.de> >> Signed-off-by: Jane Chu <jane.chu@oracle.com> >> --- >> arch/x86/mm/pat/set_memory.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c >> index abf5ed76e4b7..38af155aaba9 100644 >> --- a/arch/x86/mm/pat/set_memory.c >> +++ b/arch/x86/mm/pat/set_memory.c >> @@ -1816,7 +1816,7 @@ static inline int cpa_clear_pages_array(struct page **pages, int numpages, >> } >> >> /* >> - * _set_memory_prot is an internal helper for callers that have been passed >> + * __set_memory_prot is an internal helper for callers that have been passed >> * a pgprot_t value from upper layers and a reservation has already been taken. >> * If you want to set the pgprot to a specific page protocol, use the >> * set_memory_xx() functions. >> -- > > This is such a trivial change so that having it as a separate patch is > probably not needed - might as well merge it with patch 3... This change used to be folded in the mce patch, but for that I received a review comment pointing out that the change is unrelated to the said patch and doesn't belong, hence I pulled it out to stand by itself. :) thanks! -jane > > Thx. >
On Thu, Apr 14, 2022 at 01:00:05AM +0000, Jane Chu wrote: > This change used to be folded in the mce patch, but for that I received > a review comment pointing out that the change is unrelated to the said > patch and doesn't belong, hence I pulled it out to stand by itself. :) Aha, someone is being very pedantic. For trivial unrelated changes like that I usually add them to a patch which already touches that file and put in the commit message: "While at it, fixup a function name in a comment." Less patches to handle.
On 4/14/2022 1:44 AM, Borislav Petkov wrote: > On Thu, Apr 14, 2022 at 01:00:05AM +0000, Jane Chu wrote: >> This change used to be folded in the mce patch, but for that I received >> a review comment pointing out that the change is unrelated to the said >> patch and doesn't belong, hence I pulled it out to stand by itself. :) > > Aha, someone is being very pedantic. > > For trivial unrelated changes like that I usually add them to a patch > which already touches that file and put in the commit message: > > "While at it, fixup a function name in a comment." > > Less patches to handle. > Sounds good, I'll fold it to one of the mce patches and make a note that it is a BTW-kind of fix, not something related. thanks! -jane
diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c index abf5ed76e4b7..38af155aaba9 100644 --- a/arch/x86/mm/pat/set_memory.c +++ b/arch/x86/mm/pat/set_memory.c @@ -1816,7 +1816,7 @@ static inline int cpa_clear_pages_array(struct page **pages, int numpages, } /* - * _set_memory_prot is an internal helper for callers that have been passed + * __set_memory_prot is an internal helper for callers that have been passed * a pgprot_t value from upper layers and a reservation has already been taken. * If you want to set the pgprot to a specific page protocol, use the * set_memory_xx() functions.