mbox series

[0/4] i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi

Message ID 20220411224319.467166-1-matthew.d.roper@intel.com (mailing list archive)
Headers show
Series i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi | expand

Message

Matt Roper April 11, 2022, 10:43 p.m. UTC
This is a continuation of Matt Atwood's new geometry topology query from
here:

    https://patchwork.freedesktop.org/series/101219/#rev4

This does a bit of initial cleanup/clarification of the query interface
documentation (including converting more of it to kerneldoc so it will
actually show up in the generated html/pdf) and then applies MattA's
changes on top of that.

Cc: Matt Atwood <matthew.s.atwood@intel.com>
Cc: Francisco Jerez <currojerez@riseup.net>
Cc: Daniel Vetter <daniel@ffwll.ch>
UMD(Mesa): https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14143

Matt Atwood (1):
  drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES

Matt Roper (3):
  drm/i915/doc: Convert drm_i915_query_topology_info comment to
    kerneldoc
  drm/i915/doc: Convert perf UAPI comments to kerneldoc
  drm/i915/doc: Link query items to their uapi structs

 drivers/gpu/drm/i915/i915_query.c |  71 ++++++--
 include/uapi/drm/i915_drm.h       | 285 +++++++++++++++++++++---------
 2 files changed, 258 insertions(+), 98 deletions(-)

Comments

Matt Roper April 12, 2022, 3:10 a.m. UTC | #1
On Tue, Apr 12, 2022 at 12:43:28AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi
> URL   : https://patchwork.freedesktop.org/series/102553/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_11484 -> Patchwork_102553v1
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_102553v1 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_102553v1, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/index.html
> 
> Participating hosts (49 -> 36)
> ------------------------------
> 
>   Additional (1): fi-hsw-4770 
>   Missing    (14): shard-tglu bat-dg1-6 bat-dg2-8 shard-rkl bat-dg2-9 fi-bsw-cyan bat-adlp-6 bat-adlp-4 fi-kbl-x1275 bat-rpls-1 bat-rpls-2 shard-dg1 bat-jsl-2 bat-jsl-1 
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_102553v1:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_selftest@live@gt_engines:
>     - fi-glk-j4005:       [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11484/fi-glk-j4005/igt@i915_selftest@live@gt_engines.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-glk-j4005/igt@i915_selftest@live@gt_engines.html

(i915_selftest:5830) igt_kmod-WARNING: rcs0 elapsed:100430ns, CTX_TIMESTAMP:145261ns, RING_TIMESTAMP:145261ns
(i915_selftest:5830) igt_kmod-WARNING: rcs0 Mismatch between ring timestamp and walltime!
(i915_selftest:5830) igt_kmod-WARNING: i915/live_engine_pm_selftests: live_engine_timestamps failed with error -22

Doesn't appear to be related to this series since the query interface
isn't being used by the test.  I don't see any similar failures from a
quick fdo search though.


Matt

> 
>   
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_102553v1 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_softpin@allocator-basic-reserve:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][3] ([fdo#109271]) +9 similar issues
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-hsw-4770/igt@gem_softpin@allocator-basic-reserve.html
> 
>   * igt@i915_pm_backlight@basic-brightness:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#3012])
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-hsw-4770/igt@i915_pm_backlight@basic-brightness.html
> 
>   * igt@kms_chamelium@dp-crc-fast:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-hsw-4770/igt@kms_chamelium@dp-crc-fast.html
> 
>   * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#533])
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
> 
>   * igt@kms_psr@primary_mmap_gtt:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1072]) +3 similar issues
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-hsw-4770/igt@kms_psr@primary_mmap_gtt.html
> 
>   * igt@runner@aborted:
>     - fi-bdw-5557u:       NOTRUN -> [FAIL][8] ([i915#4312])
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-bdw-5557u/igt@runner@aborted.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
>     - fi-cfl-8109u:       [DMESG-WARN][9] ([i915#5341] / [i915#62]) -> [PASS][10]
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11484/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
> 
>   * igt@kms_pipe_crc_basic@read-crc-pipe-b:
>     - fi-cfl-8109u:       [DMESG-WARN][11] ([i915#62]) -> [PASS][12] +11 similar issues
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11484/fi-cfl-8109u/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-cfl-8109u/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
> 
>   
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
>   [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
>   [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
>   [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
>   [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
>   [i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
>   [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_11484 -> Patchwork_102553v1
> 
>   CI-20190529: 20190529
>   CI_DRM_11484: 8034f05811fe63be8ced11c140e59a8cea07a3d6 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_6419: 33a5adf20dc435cc2c6dd584caa3674c89032762 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_102553v1: 102553v1 @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Linux commits ==
> 
> 3e5b0ebc4047 drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES
> a2139ca1ff95 drm/i915/doc: Link query items to their uapi structs
> a1e892df2288 drm/i915/doc: Convert perf UAPI comments to kerneldoc
> de268f63097a drm/i915/doc: Convert drm_i915_query_topology_info comment to kerneldoc
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/index.html
Vudum, Lakshminarayana April 12, 2022, 4:39 a.m. UTC | #2
Yeah that something new
https://gitlab.freedesktop.org/drm/intel/-/issues/5631
igt@i915_selftest@live@gt_engines - fail - rcs0 Mismatch between ring timestamp and walltime! i915/live_engine_pm_selftests: live_engine_timestamps failed with error -22

Thanks,
Lakshmi.

-----Original Message-----
From: Roper, Matthew D <matthew.d.roper@intel.com> 
Sent: Monday, April 11, 2022 8:11 PM
To: intel-gfx@lists.freedesktop.org
Cc: Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Subject: Re: ✗ Fi.CI.BAT: failure for i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi

On Tue, Apr 12, 2022 at 12:43:28AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: i915: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES uapi
> URL   : https://patchwork.freedesktop.org/series/102553/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_11484 -> Patchwork_102553v1 
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_102553v1 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_102553v1, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/index.html
> 
> Participating hosts (49 -> 36)
> ------------------------------
> 
>   Additional (1): fi-hsw-4770 
>   Missing    (14): shard-tglu bat-dg1-6 bat-dg2-8 shard-rkl bat-dg2-9 fi-bsw-cyan bat-adlp-6 bat-adlp-4 fi-kbl-x1275 bat-rpls-1 bat-rpls-2 shard-dg1 bat-jsl-2 bat-jsl-1 
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_102553v1:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_selftest@live@gt_engines:
>     - fi-glk-j4005:       [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11484/fi-glk-j4005/igt@i915_selftest@live@gt_engines.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-glk-j40
> 05/igt@i915_selftest@live@gt_engines.html

(i915_selftest:5830) igt_kmod-WARNING: rcs0 elapsed:100430ns, CTX_TIMESTAMP:145261ns, RING_TIMESTAMP:145261ns
(i915_selftest:5830) igt_kmod-WARNING: rcs0 Mismatch between ring timestamp and walltime!
(i915_selftest:5830) igt_kmod-WARNING: i915/live_engine_pm_selftests: live_engine_timestamps failed with error -22

Doesn't appear to be related to this series since the query interface isn't being used by the test.  I don't see any similar failures from a quick fdo search though.


Matt

> 
>   
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_102553v1 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_softpin@allocator-basic-reserve:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][3] ([fdo#109271]) +9 similar issues
>    [3]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-hsw-477
> 0/igt@gem_softpin@allocator-basic-reserve.html
> 
>   * igt@i915_pm_backlight@basic-brightness:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#3012])
>    [4]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-hsw-477
> 0/igt@i915_pm_backlight@basic-brightness.html
> 
>   * igt@kms_chamelium@dp-crc-fast:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues
>    [5]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-hsw-477
> 0/igt@kms_chamelium@dp-crc-fast.html
> 
>   * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#533])
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-hsw-477
> 0/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
> 
>   * igt@kms_psr@primary_mmap_gtt:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1072]) +3 similar issues
>    [7]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-hsw-477
> 0/igt@kms_psr@primary_mmap_gtt.html
> 
>   * igt@runner@aborted:
>     - fi-bdw-5557u:       NOTRUN -> [FAIL][8] ([i915#4312])
>    [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-bdw-555
> 7u/igt@runner@aborted.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
>     - fi-cfl-8109u:       [DMESG-WARN][9] ([i915#5341] / [i915#62]) -> [PASS][10]
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11484/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-cfl-810
> 9u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
> 
>   * igt@kms_pipe_crc_basic@read-crc-pipe-b:
>     - fi-cfl-8109u:       [DMESG-WARN][11] ([i915#62]) -> [PASS][12] +11 similar issues
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11484/fi-cfl-8109u/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
>    [12]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/fi-cfl-810
> 9u/igt@kms_pipe_crc_basic@read-crc-pipe-b.html
> 
>   
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
>   [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
>   [i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
>   [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
>   [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
>   [i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
>   [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_11484 -> Patchwork_102553v1
> 
>   CI-20190529: 20190529
>   CI_DRM_11484: 8034f05811fe63be8ced11c140e59a8cea07a3d6 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_6419: 33a5adf20dc435cc2c6dd584caa3674c89032762 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_102553v1: 102553v1 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Linux commits ==
> 
> 3e5b0ebc4047 drm/i915/uapi: Add DRM_I915_QUERY_GEOMETRY_SUBSLICES
> a2139ca1ff95 drm/i915/doc: Link query items to their uapi structs
> a1e892df2288 drm/i915/doc: Convert perf UAPI comments to kerneldoc 
> de268f63097a drm/i915/doc: Convert drm_i915_query_topology_info 
> comment to kerneldoc
> 
> == Logs ==
> 
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102553v1/index.html

--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795