| Message ID | 20220408212121.9368-2-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | power: supply: Add Support for RK817 Charger | expand |
On 08/04/2022 23:21, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Create dt-binding documentation to document rk817 battery and charger > usage. New device-tree properties have been added. Note that this > patch requires the following commit (still pending): > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20220404215754.30126-2-macroalpha82@gmail.com/ > > - rockchip,resistor-sense-micro-ohms: The value in microohms of the > sample resistor. > - rockchip,sleep-enter-current-microamp: The value in microamps of the > sleep enter current. > - rockchip,sleep-filter-current: The value in microamps of the sleep > filter current. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com> > --- > .../bindings/mfd/rockchip,rk817.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Apr 08, 2022 at 04:21:18PM -0500, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Create dt-binding documentation to document rk817 battery and charger > usage. New device-tree properties have been added. Note that this > patch requires the following commit (still pending): > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20220404215754.30126-2-macroalpha82@gmail.com/ Thanks for adding this, but it should be below the '---' as this will not be relevant once committed. Note that any links to patches that we do want preserved should be lore.kernel.org links. > > - rockchip,resistor-sense-micro-ohms: The value in microohms of the > sample resistor. > - rockchip,sleep-enter-current-microamp: The value in microamps of the > sleep enter current. > - rockchip,sleep-filter-current: The value in microamps of the sleep > filter current. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com> > --- > .../bindings/mfd/rockchip,rk817.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml > index bfc1720adc43..d0dccb1aaf4c 100644 > --- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml > +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml > @@ -117,6 +117,47 @@ properties: > description: > Describes if the microphone uses differential mode. > > + charger: > + description: | > + The child node for the charger to hold additional properties. If a > + battery is not in use, this node can be omitted. > + type: object > + properties: > + monitored-battery: > + description: | > + A phandle to a monitored battery node that contains a valid > + value for: > + charge-full-design-microamp-hours, > + charge-term-current-microamp, > + constant-charge-current-max-microamp, > + constant-charge-voltage-max-microvolt, > + voltage-max-design-microvolt, > + voltage-min-design-microvolt, > + and a valid ocv-capacity table. > + > + rockchip,resistor-sense-micro-ohms: > + description: | > + Value in microohms of the battery sense resistor. This value is > + used by the driver to set the correct divisor value to translate > + ADC readings into the proper units of measure. > + enum: [10000, 20000] > + > + rockchip,sleep-enter-current-microamp: > + description: | > + Value in microamps of the sleep enter current for the charger. > + Value is used by the driver to calibrate the relax threshold. > + > + rockchip,sleep-filter-current-microamp: > + description: > + Value in microamps of the sleep filter current for the charger. > + Value is used by the driver to derive the sleep sample current. > + > + required: > + - monitored-battery > + - rockchip,resistor-sense-micro-ohms > + - rockchip,sleep-enter-current-microamp > + - rockchip,sleep-filter-current-microamp > + > allOf: > - if: > properties: > @@ -323,6 +364,13 @@ examples: > }; > }; > > + rk817_charger: charger { > + monitored-battery = <&battery>; > + rockchip,resistor-sense-micro-ohms = <10000>; > + rockchip,sleep-enter-current-microamp = <300000>; > + rockchip,sleep-filter-current-microamp = <100000>; > + }; > + > rk817_codec: codec { > rockchip,mic-in-differential; > }; > -- > 2.25.1 > >
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml index bfc1720adc43..d0dccb1aaf4c 100644 --- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml +++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml @@ -117,6 +117,47 @@ properties: description: Describes if the microphone uses differential mode. + charger: + description: | + The child node for the charger to hold additional properties. If a + battery is not in use, this node can be omitted. + type: object + properties: + monitored-battery: + description: | + A phandle to a monitored battery node that contains a valid + value for: + charge-full-design-microamp-hours, + charge-term-current-microamp, + constant-charge-current-max-microamp, + constant-charge-voltage-max-microvolt, + voltage-max-design-microvolt, + voltage-min-design-microvolt, + and a valid ocv-capacity table. + + rockchip,resistor-sense-micro-ohms: + description: | + Value in microohms of the battery sense resistor. This value is + used by the driver to set the correct divisor value to translate + ADC readings into the proper units of measure. + enum: [10000, 20000] + + rockchip,sleep-enter-current-microamp: + description: | + Value in microamps of the sleep enter current for the charger. + Value is used by the driver to calibrate the relax threshold. + + rockchip,sleep-filter-current-microamp: + description: + Value in microamps of the sleep filter current for the charger. + Value is used by the driver to derive the sleep sample current. + + required: + - monitored-battery + - rockchip,resistor-sense-micro-ohms + - rockchip,sleep-enter-current-microamp + - rockchip,sleep-filter-current-microamp + allOf: - if: properties: @@ -323,6 +364,13 @@ examples: }; }; + rk817_charger: charger { + monitored-battery = <&battery>; + rockchip,resistor-sense-micro-ohms = <10000>; + rockchip,sleep-enter-current-microamp = <300000>; + rockchip,sleep-filter-current-microamp = <100000>; + }; + rk817_codec: codec { rockchip,mic-in-differential; };