[v7,2/2] dt-bindings:thermal: Add Sunplus SP7021 schema

Commit Message

Li-hao Kuo April 11, 2022, 8:52 a.m. UTC

Add bindings for Sunplus SP7021 thermal driver

Signed-off-by: Li-hao Kuo <[e-mail]>
---
Changes in v7:
 - Modify yaml file.
 - Change the filename sunplus_thermal to sunplus-thermal.
 - Change the nvmem-cell-names thermal_calib to calib.

 .../bindings/thermal/sunplus-thermal.yaml          | 43 ++++++++++++++++++++++
 MAINTAINERS                                        |  1 +
 2 files changed, 44 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml

Comments

Krzysztof Kozlowski April 12, 2022, 8:48 a.m. UTC | #1

On 11/04/2022 10:52, Li-hao Kuo wrote:
> Add bindings for Sunplus SP7021 thermal driver
> 
> Signed-off-by: Li-hao Kuo <[e-mail]>

Thank you for your patch. There is something to discuss/improve.

> ---
> Changes in v7:
>  - Modify yaml file.
>  - Change the filename sunplus_thermal to sunplus-thermal.
>  - Change the nvmem-cell-names thermal_calib to calib.
> 
>  .../bindings/thermal/sunplus-thermal.yaml          | 43 ++++++++++++++++++++++
>  MAINTAINERS                                        |  1 +
>  2 files changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml
> 

I commented with v5 [1] how the naming should look like. That's the
Devicetree convention.

You sent v6 without implementing the changes. I pointed out that you did
not follow what I asked for.
Now you sent v7 also without implementing these changes, again.

You also did not discuss it with me, did not come with counter
arguments, other proposals. Therefore it looks like either you
misunderstood me or you ignored my comments.

Let's assume first case, so I will repeat. Name should be one of:
1. sunplus,thermal.yaml
2. sunplus,sp7021-thermal.yaml

Not other names. No other characters, no undescores, no hyphens after
vendor name. If this is unclear, please respond instead of ignoring.

Without implementing the changes:
NAK

[1]
https://lore.kernel.org/linux-devicetree/[e-mail]/

Best regards,
Krzysztof

Lh Kuo 郭力豪 April 13, 2022, 1:49 a.m. UTC | #2

Hi Mr. Krzysztof

I'm sorry for that. I misunderstood at the beginning

I will change the name to sunplus,thermal.yaml in the next commit.

Thanks for your comment.

Best regards,
Li Hao Kuo

> You sent v6 without implementing the changes. I pointed out that you did not follow what I asked for.
> Now you sent v7 also without implementing these changes, again.
> 
> You also did not discuss it with me, did not come with counter arguments, other proposals. Therefore it
> looks like either you misunderstood me or you ignored my comments.
> 
> Let's assume first case, so I will repeat. Name should be one of:
> 1. sunplus,thermal.yaml
> 2. sunplus,sp7021-thermal.yaml

Patch

diff --git a/Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml b/Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml
new file mode 100644
index 0000000..b9d69b8
--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/sunplus-thermal.yaml
@@ -0,0 +1,43 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright (C) Sunplus Co., Ltd.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/thermal/sunplus-thermal.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sunplus Thermal controller
+
+maintainers:
+  - Li-hao Kuo <[e-mail]>
+
+properties:
+  compatible:
+    enum:
+      - sunplus,sp7021-thermal
+
+  reg:
+    maxItems: 1
+
+  nvmem-cells:
+    maxItems: 1
+
+  nvmem-cell-names:
+    const: calib
+
+required:
+  - compatible
+  - reg
+  - nvmem-cells
+  - nvmem-cell-names
+
+additionalProperties: false
+
+examples:
+  - |
+    thermal@9c000280 {
+        compatible = "sunplus,sp7021-thermal";
+        reg = <0x9c000280 0xc>;
+        nvmem-cells = <&calib>;
+        nvmem-cell-names = "calib";
+    };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 307570c..0eb22a0 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18889,6 +18889,7 @@  SUNPLUS THERMAL DRIVER
 M:	Li-hao Kuo <[e-mail]>
 L:	[e-mail]
 S:	Maintained
+F:	Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml
 F:	drivers/thermal/sunplus_thermal.c
 
 SUNPLUS UART DRIVER