[v2,0/2] x86/kexec: fix memory leak of elf header buffer

Message

Baoquan He Feb. 23, 2022, 11:32 a.m. UTC

The memory leak is reported by kmemleak detector, has been existing
for very long time. It casue much memory loss on large machine
with huge memory hotplug which will trigger kdump kernel reloading
many times, with kexec_file_load interface.

And in patch 2, clean up is done to remove unneeded
arch_kexec_kernel_image_load() and rename functions.

V1 post can be found here:
https://lore.kernel.org/all/[e-mail]/T/#u

v1->v2:
 No code change. The v1 post has been acked by Dave Young but not
merged. In v2, just merging the old patch 1 and 2 as per Dave's concern
in v1 post.

Baoquan He (2):
  x86/kexec: fix memory leak of elf header buffer
  kexec_file: clean up arch_kexec_kernel_image_load

 arch/x86/kernel/machine_kexec_64.c | 23 +++++++++--------------
 include/linux/kexec.h              |  1 -
 kernel/kexec_file.c                |  9 ++-------
 3 files changed, 11 insertions(+), 22 deletions(-)

Comments

Baoquan He March 31, 2022, 11:32 a.m. UTC | #1

Hi Andrew,

On 02/23/22 at 07:32pm, Baoquan He wrote:
> The memory leak is reported by kmemleak detector, has been existing
> for very long time. It casue much memory loss on large machine
> with huge memory hotplug which will trigger kdump kernel reloading
> many times, with kexec_file_load interface.

Could you merge these two patches? Or should I ping x86 maintainers to
take them? 

Thanks
Baoquan

> 
> And in patch 2, clean up is done to remove unneeded
> arch_kexec_kernel_image_load() and rename functions.
> 
> V1 post can be found here:
> https://lore.kernel.org/all/[e-mail]/T/#u
> 
> v1->v2:
>  No code change. The v1 post has been acked by Dave Young but not
> merged. In v2, just merging the old patch 1 and 2 as per Dave's concern
> in v1 post.
> 
> Baoquan He (2):
>   x86/kexec: fix memory leak of elf header buffer
>   kexec_file: clean up arch_kexec_kernel_image_load
> 
>  arch/x86/kernel/machine_kexec_64.c | 23 +++++++++--------------
>  include/linux/kexec.h              |  1 -
>  kernel/kexec_file.c                |  9 ++-------
>  3 files changed, 11 insertions(+), 22 deletions(-)
> 
> -- 
> 2.31.1
>

Andrew Morton April 13, 2022, 2:27 a.m. UTC | #2

On Thu, 31 Mar 2022 19:32:17 +0800 Baoquan He <[e-mail]> wrote:

> Hi Andrew,
> 
> On 02/23/22 at 07:32pm, Baoquan He wrote:
> > The memory leak is reported by kmemleak detector, has been existing
> > for very long time. It casue much memory loss on large machine
> > with huge memory hotplug which will trigger kdump kernel reloading
> > many times, with kexec_file_load interface.
> 
> Could you merge these two patches? Or should I ping x86 maintainers to
> take them? 

Ah, sorry, I tend to fall asleep if there's "x86" in the subject. 
Poking a sleeping Andrew is always the right thing to do.  Shall look
at them.

Baoquan He April 13, 2022, 2:47 a.m. UTC | #3

On 04/12/22 at 07:27pm, Andrew Morton wrote:
> On Thu, 31 Mar 2022 19:32:17 +0800 Baoquan He <[e-mail]> wrote:
> 
> > Hi Andrew,
> > 
> > On 02/23/22 at 07:32pm, Baoquan He wrote:
> > > The memory leak is reported by kmemleak detector, has been existing
> > > for very long time. It casue much memory loss on large machine
> > > with huge memory hotplug which will trigger kdump kernel reloading
> > > many times, with kexec_file_load interface.
> > 
> > Could you merge these two patches? Or should I ping x86 maintainers to
> > take them? 
> 
> Ah, sorry, I tend to fall asleep if there's "x86" in the subject. 
> Poking a sleeping Andrew is always the right thing to do.  Shall look
> at them.

Thanks, Andrew.

Since it's also MM related, so ping you and x86 maintainers to see who
can help pick them.

Borislav Petkov April 13, 2022, 8:32 a.m. UTC | #4

On Wed, Apr 13, 2022 at 10:47:49AM +0800, Baoquan He wrote:
> Since it's also MM related, so ping you and x86 maintainers to see who
> can help pick them.

I'd leave that decision to akpm. :-)

Thx.