| Message ID | 20220411095516.24754-1-rogerq@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | memory: omap-gpmc: Allow module build | expand |
On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote: > These patches allow OMAP_GPMC config to be visible in menuconfig > and buildable as a module. > > Changelog: > v3: > - Remove not required MODULE_ALIAS > - Mention in commit message why we need to remove of_match_node() call > > [...] Applied, thanks! [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable commit: 656d1be692be78b825954e0a2a47fcae81834633 [2/2] memory: omap-gpmc: Allow building as a module commit: eb55c7180be67774aa728a3c450de441e0dedb5d Best regards,
On 13/04/2022 11:43, Krzysztof Kozlowski wrote: > On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote: >> These patches allow OMAP_GPMC config to be visible in menuconfig >> and buildable as a module. >> >> Changelog: >> v3: >> - Remove not required MODULE_ALIAS >> - Mention in commit message why we need to remove of_match_node() call >> >> [...] > > Applied, thanks! > > [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable > commit: 656d1be692be78b825954e0a2a47fcae81834633 > [2/2] memory: omap-gpmc: Allow building as a module > commit: eb55c7180be67774aa728a3c450de441e0dedb5d And dropped. You have a checkpatch issue: WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") #127: FILE: drivers/memory/omap-gpmc.c:2664: +MODULE_LICENSE("GPL v2"); Best regards, Krzysztof
On 13/04/2022 11:50, Krzysztof Kozlowski wrote: > On 13/04/2022 11:43, Krzysztof Kozlowski wrote: >> On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote: >>> These patches allow OMAP_GPMC config to be visible in menuconfig >>> and buildable as a module. >>> >>> Changelog: >>> v3: >>> - Remove not required MODULE_ALIAS >>> - Mention in commit message why we need to remove of_match_node() call >>> >>> [...] >> >> Applied, thanks! >> >> [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable >> commit: 656d1be692be78b825954e0a2a47fcae81834633 >> [2/2] memory: omap-gpmc: Allow building as a module >> commit: eb55c7180be67774aa728a3c450de441e0dedb5d > > And dropped. You have a checkpatch issue: > > WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: > Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") > #127: FILE: drivers/memory/omap-gpmc.c:2664: > +MODULE_LICENSE("GPL v2"); I kept your first patch (visible/selectable) but I think it should be dropped as well. You need to test it more: https://krzk.eu/#/builders/63/builds/162 Best regards, Krzysztof
Hi Krzysztof, On 13/04/2022 13:20, Krzysztof Kozlowski wrote: > On 13/04/2022 11:50, Krzysztof Kozlowski wrote: >> On 13/04/2022 11:43, Krzysztof Kozlowski wrote: >>> On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote: >>>> These patches allow OMAP_GPMC config to be visible in menuconfig >>>> and buildable as a module. >>>> >>>> Changelog: >>>> v3: >>>> - Remove not required MODULE_ALIAS >>>> - Mention in commit message why we need to remove of_match_node() call >>>> >>>> [...] >>> >>> Applied, thanks! >>> >>> [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable >>> commit: 656d1be692be78b825954e0a2a47fcae81834633 >>> [2/2] memory: omap-gpmc: Allow building as a module >>> commit: eb55c7180be67774aa728a3c450de441e0dedb5d >> >> And dropped. You have a checkpatch issue: >> >> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: >> Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") >> #127: FILE: drivers/memory/omap-gpmc.c:2664: >> +MODULE_LICENSE("GPL v2"); > > I kept your first patch (visible/selectable) but I think it should be > dropped as well. You need to test it more: > > https://krzk.eu/#/builders/63/builds/162 Thanks for the report. I will fix the issues. cheers, -roger
On 13/04/2022 13:20, Krzysztof Kozlowski wrote: > On 13/04/2022 11:50, Krzysztof Kozlowski wrote: >> On 13/04/2022 11:43, Krzysztof Kozlowski wrote: >>> On Mon, 11 Apr 2022 12:55:14 +0300, Roger Quadros wrote: >>>> These patches allow OMAP_GPMC config to be visible in menuconfig >>>> and buildable as a module. >>>> >>>> Changelog: >>>> v3: >>>> - Remove not required MODULE_ALIAS >>>> - Mention in commit message why we need to remove of_match_node() call >>>> >>>> [...] >>> >>> Applied, thanks! >>> >>> [1/2] memory: omap-gpmc: Make OMAP_GPMC config visible and selectable >>> commit: 656d1be692be78b825954e0a2a47fcae81834633 >>> [2/2] memory: omap-gpmc: Allow building as a module >>> commit: eb55c7180be67774aa728a3c450de441e0dedb5d >> >> And dropped. You have a checkpatch issue: >> >> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: >> Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") >> #127: FILE: drivers/memory/omap-gpmc.c:2664: >> +MODULE_LICENSE("GPL v2"); > > I kept your first patch (visible/selectable) but I think it should be > dropped as well. You need to test it more: > > https://krzk.eu/#/builders/63/builds/162 > > >> config OMAP_GPMC >> - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >> - depends on OF_ADDRESS >> + bool "Texas Instruments OMAP SoC GPMC driver" >> + depends on OF_ADDRESS || COMPILE_TEST Looks like include/linux/irqdomain.h does not have fallbacks if CONFIG_IRQ_DOMAIN is not enabled. I'll have to drop COMPILE_TEST and add depends on IRQ_DOMAIN. Is that OK? cheers, -roger
On 13/04/2022 13:01, Roger Quadros wrote: >> https://krzk.eu/#/builders/63/builds/162 >> >> >>> config OMAP_GPMC >>> - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >>> - depends on OF_ADDRESS >>> + bool "Texas Instruments OMAP SoC GPMC driver" >>> + depends on OF_ADDRESS || COMPILE_TEST > > > Looks like include/linux/irqdomain.h does not have fallbacks if > CONFIG_IRQ_DOMAIN is not enabled. > > I'll have to drop COMPILE_TEST and add depends on IRQ_DOMAIN. > Is that OK? Previously it was building with COMPILE_TEST on sparc, so what else changed? Best regards, Krzysztof
On 13/04/2022 14:05, Krzysztof Kozlowski wrote: > On 13/04/2022 13:01, Roger Quadros wrote: >>> https://krzk.eu/#/builders/63/builds/162 >>> >>> >>>> config OMAP_GPMC >>>> - bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >>>> - depends on OF_ADDRESS >>>> + bool "Texas Instruments OMAP SoC GPMC driver" >>>> + depends on OF_ADDRESS || COMPILE_TEST >> >> >> Looks like include/linux/irqdomain.h does not have fallbacks if >> CONFIG_IRQ_DOMAIN is not enabled. >> >> I'll have to drop COMPILE_TEST and add depends on IRQ_DOMAIN. >> Is that OK? > > Previously it was building with COMPILE_TEST on sparc, so what else changed? > Previously it was like so bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST depends on OF_ADDRESS Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set. And OF_ADDRESS is not set for sparc config OF_ADDRESS def_bool y depends on !SPARC && (HAS_IOMEM || UML) cheers, -roger
On 13/04/2022 13:33, Roger Quadros wrote: >> Previously it was building with COMPILE_TEST on sparc, so what else changed? >> > Previously it was like so > > bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST > depends on OF_ADDRESS > > Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set. > > And OF_ADDRESS is not set for sparc > Ah, yes, so dropping COMPILE_TEST seems the solution. There are no other "depends" here. Best regards, Krzysztof
On 13/04/2022 14:47, Krzysztof Kozlowski wrote: > On 13/04/2022 13:33, Roger Quadros wrote: >>> Previously it was building with COMPILE_TEST on sparc, so what else changed? >>> >> Previously it was like so >> >> bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >> depends on OF_ADDRESS >> >> Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set. >> >> And OF_ADDRESS is not set for sparc >> > > Ah, yes, so dropping COMPILE_TEST seems the solution. There are no other > "depends" here. But the build failed at irq_domain_remove() which is only available if IRQ_DOMAIN is enabled. It could be possible that OF_ADDRESS is enabled but IRQ_DOMAIN is not right? cheers, -roger
On 13/04/2022 13:56, Roger Quadros wrote: > > > On 13/04/2022 14:47, Krzysztof Kozlowski wrote: >> On 13/04/2022 13:33, Roger Quadros wrote: >>>> Previously it was building with COMPILE_TEST on sparc, so what else changed? >>>> >>> Previously it was like so >>> >>> bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >>> depends on OF_ADDRESS >>> >>> Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set. >>> >>> And OF_ADDRESS is not set for sparc >>> >> >> Ah, yes, so dropping COMPILE_TEST seems the solution. There are no other >> "depends" here. > > But the build failed at irq_domain_remove() which is only available if IRQ_DOMAIN > is enabled. > > It could be possible that OF_ADDRESS is enabled but IRQ_DOMAIN is not right? I must admit I did not dig this that much. OF_ADDRESS has !SPARC dependency, so after removing COMPILE_TEST the issue should not happen on SPARC. What about other platforms? They should behave I think the same as before - fail if they were failing. Nothing gets worse which is my main concern here. If you have spare time, maybe you could investigate the compile testing on other platforms as well and if something fails, fix it. But it seems it is separate problem. Best regards, Krzysztof
On 13/04/2022 15:31, Krzysztof Kozlowski wrote: > On 13/04/2022 13:56, Roger Quadros wrote: >> >> >> On 13/04/2022 14:47, Krzysztof Kozlowski wrote: >>> On 13/04/2022 13:33, Roger Quadros wrote: >>>>> Previously it was building with COMPILE_TEST on sparc, so what else changed? >>>>> >>>> Previously it was like so >>>> >>>> bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST >>>> depends on OF_ADDRESS >>>> >>>> Means it won't build if OF_ADDRESS is not set even if COMPILE_TEST is set. >>>> >>>> And OF_ADDRESS is not set for sparc >>>> >>> >>> Ah, yes, so dropping COMPILE_TEST seems the solution. There are no other >>> "depends" here. >> >> But the build failed at irq_domain_remove() which is only available if IRQ_DOMAIN >> is enabled. >> >> It could be possible that OF_ADDRESS is enabled but IRQ_DOMAIN is not right? > > I must admit I did not dig this that much. OF_ADDRESS has !SPARC > dependency, so after removing COMPILE_TEST the issue should not happen > on SPARC. What about other platforms? They should behave I think the > same as before - fail if they were failing. Nothing gets worse which is > my main concern here. > > If you have spare time, maybe you could investigate the compile testing > on other platforms as well and if something fails, fix it. But it seems > it is separate problem. > I won't be able to test on all platforms. I'm ok to not add more dependency and just drop COMPILE_TEST. cheers, -roger
On 13/04/2022 14:56, Roger Quadros wrote: >> >> If you have spare time, maybe you could investigate the compile testing >> on other platforms as well and if something fails, fix it. But it seems >> it is separate problem. >> > > I won't be able to test on all platforms. I'm ok to not add more dependency and > just drop COMPILE_TEST. I understand that. You can still test 8-12 popular ones on a regular Ubuntu machine (there are like 10 or 12 cross compile toolchains now in standard Ubuntu repos). Another way is to put your patches on Github and ask kbuild folks to test your trees. I think this was the repo (but double check): https://github.com/fengguang/lkp-tests Best regards, Krzysztof
On 13/04/2022 15:00, Krzysztof Kozlowski wrote: > I understand that. You can still test 8-12 popular ones on a regular > Ubuntu machine (there are like 10 or 12 cross compile toolchains now in > standard Ubuntu repos). > > Another way is to put your patches on Github and ask kbuild folks to > test your trees. I think this was the repo (but double check): > https://github.com/fengguang/lkp-tests I think this is correct one: https://github.com/intel/lkp-tests.git Best regards, Krzysztof