diff mbox series

[V2,1/3] dt-bindings: display: mediatek: Update disp_aal binding for MT8183

Message ID 20220411035843.19847-2-rex-bc.chen@mediatek.com (mailing list archive)
State New, archived
Headers show
Series Update MediaTek disp_aal dt-binding | expand

Commit Message

Rex-BC Chen (陳柏辰) April 11, 2022, 3:58 a.m. UTC 
The driver data of MT8183 and MT8173 are different.

For MT8173, the gamma module is inside disp_aal. When we need to adjust
gamma value, we need to use "has_gamma" to control gamma function
inside disp_aal to adjust the gamma value.

For successors like MT8183, disp_gamma is separated from disp_aal. We
just need to control disp_gamma directly and don't need to control gamma
function inside disp_aal.

With this modification, the driver doesn't require any functional changes.
We only update the dt-binding and DTS node to make it clear.

Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
 .../devicetree/bindings/display/mediatek/mediatek,aal.yaml  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Rob Herring April 13, 2022, 11:02 p.m. UTC | #1 
On Mon, 11 Apr 2022 11:58:41 +0800, Rex-BC Chen wrote:
> The driver data of MT8183 and MT8173 are different.
> 
> For MT8173, the gamma module is inside disp_aal. When we need to adjust
> gamma value, we need to use "has_gamma" to control gamma function
> inside disp_aal to adjust the gamma value.
> 
> For successors like MT8183, disp_gamma is separated from disp_aal. We
> just need to control disp_gamma directly and don't need to control gamma
> function inside disp_aal.
> 
> With this modification, the driver doesn't require any functional changes.
> We only update the dt-binding and DTS node to make it clear.
> 
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
>  .../devicetree/bindings/display/mediatek/mediatek,aal.yaml  | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Chun-Kuang Hu April 16, 2022, 2:20 p.m. UTC | #2 
Rob Herring <robh@kernel.org> 於 2022年4月14日 週四 上午7:02寫道：
>
> On Mon, 11 Apr 2022 11:58:41 +0800, Rex-BC Chen wrote:
> > The driver data of MT8183 and MT8173 are different.
> >
> > For MT8173, the gamma module is inside disp_aal. When we need to adjust
> > gamma value, we need to use "has_gamma" to control gamma function
> > inside disp_aal to adjust the gamma value.
> >
> > For successors like MT8183, disp_gamma is separated from disp_aal. We
> > just need to control disp_gamma directly and don't need to control gamma
> > function inside disp_aal.
> >
> > With this modification, the driver doesn't require any functional changes.
> > We only update the dt-binding and DTS node to make it clear.
> >
> > Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > ---
> >  .../devicetree/bindings/display/mediatek/mediatek,aal.yaml  | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
>
> Acked-by: Rob Herring <robh@kernel.org>

Applied to mediatek-drm-next [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next

Regards,
Chun-Kuang.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
index cb4a2f39ff88..f118075e4a89 100644
--- a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
+++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yaml
@@ -21,12 +21,12 @@  description: |
 properties:
   compatible:
     oneOf:
-      - items:
-          - const: mediatek,mt8173-disp-aal
+      - enum:
+          - mediatek,mt8173-disp-aal
+          - mediatek,mt8183-disp-aal
       - items:
           - enum:
               - mediatek,mt2712-disp-aal
-              - mediatek,mt8183-disp-aal
               - mediatek,mt8192-disp-aal
               - mediatek,mt8195-disp-aal
           - const: mediatek,mt8173-disp-aal